build: Convert core, hub, minimal and types to use eslint (#2794)

* build: Switch `@sentry/core` to using eslint

* build: Switch `@sentry/hub` to using eslint

* build: Switch `@sentry/minimal` to using eslint

* build: Switch `@sentry/types` to using eslint

Author: AbhiPrasad

.eslintignore

@@ -2,15 +2,11 @@
 # THIS WILL BE REMOVED AFTER WE FINISH ESLINT UPGRADE
 
 packages/apm/**/*
-packages/core/**/*
 packages/ember/**/*
 packages/gatsby/**/*
-packages/hub/**/*
 packages/integrations/**/*
-packages/minimal/**/*
 packages/node/**/*
 packages/react/**/*
 packages/tracing/**/*
-packages/types/**/*
 packages/typescript/**/*
 packages/utils/**/*

.eslintrc.js

@@ -93,6 +93,8 @@ module.exports = {
       files: ['*.test.ts', '*.test.tsx', '*.test.js', '*.test.jsx'],
       rules: {
         'max-lines': 'off',
+
+        '@typescript-eslint/explicit-function-return-type': 'off',
       },
     },
     {
@@ -123,5 +125,8 @@ module.exports = {
 
     // Limit maximum file size to reduce complexity. Turned off in tests.
     'max-lines': 'error',
+
+    // We should require a whitespace beginning a comment
+    'spaced-comment': 'error',
   },
 };

dangerfile.ts

@@ -6,7 +6,7 @@ import tslint from 'danger-plugin-tslint';
 import { prettyResults } from 'danger-plugin-tslint/dist/prettyResults';
 import { CLIEngine } from 'eslint';
 
-const PACKAGES = ['apm', 'core', 'hub', 'integrations', 'minimal', 'node', 'types', 'utils'];
+const PACKAGES = ['apm', 'integrations', 'node', 'utils'];
 const EXTENSIONS = ['.js', '.jsx', '.ts', '.tsx'];
 
 /**

packages/browser/src/helpers.ts

@@ -153,9 +153,8 @@ export function wrap(
         },
       });
     }
-  } catch (_oO) {
-    /*no-empty*/
-  }
+    // eslint-disable-next-line no-empty
+  } catch (_oO) {}
 
   return sentryWrapped;
 }

packages/browser/test/integration/common/utils.js

@@ -50,6 +50,7 @@ function supportsOnunhandledRejection() {
 }
 
 function isBelowIE11() {
+  // eslint-disable-next-line spaced-comment
   return /*@cc_on!@*/ false == !false;
 }
 

packages/browser/test/integration/polyfills/fetch.js

@@ -1,4 +1,4 @@
-/*!
+/* !
  * @overview whatwg-fetch - an implementation of Fetch API.
  * @copyright Copyright (c) 2014-2016 GitHub, Inc.
  * @license   Licensed under MIT license

packages/browser/test/integration/polyfills/promise.js

@@ -1,4 +1,4 @@
-/*!
+/* !
  * @overview es6-promise - an implementation of Promise API.
  * @copyright Copyright (c) 2014 Yehuda Katz, Tom Dale, Stefan Penner and contributors (Conversion to ES6 API by Jake Archibald)
  * @license   Licensed under MIT license
@@ -222,7 +222,7 @@
   `value`
 */
   function resolve$1(object) {
-    /*jshint validthis:true */
+    /* jshint validthis:true */
     var Constructor = this;
 
     if (
@@ -722,7 +722,7 @@
   promise to settle.
 */
   function race(entries) {
-    /*jshint validthis:true */
+    /* jshint validthis:true */
     var Constructor = this;
 
     if (!isArray(entries)) {
@@ -774,7 +774,7 @@
   @return {Promise} a promise rejected with the given `reason`.
 */
   function reject$1(reason) {
-    /*jshint validthis:true */
+    /* jshint validthis:true */
     var Constructor = this;
     var promise = new Constructor(noop);
     reject(promise, reason);

packages/browser/test/integration/suites/loader.js

@@ -45,7 +45,7 @@ if (IS_LOADER) {
         setTimeout(function() {
           Sentry.captureMessage("test");
         });
-        undefinedMethod(); //trigger error
+        undefinedMethod(); // trigger error
       }).then(function(summary) {
         assert.ok(summary.events[0].breadcrumbs);
         assert.lengthOf(summary.events[0].breadcrumbs, 1);

packages/core/.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  root: true,
+  env: {
+    es6: true,
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+  },
+  extends: ['../../.eslintrc.js'],
+  ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx', '*.d.ts'],
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+    },
+    {
+      files: ['test/**/*'],
+      rules: {
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-non-null-assertion': 'off',
+      },
+    },
+  ],
+};

packages/core/package.json

@@ -28,7 +28,6 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "5.16.0",
     "typescript": "3.4.5"
   },
   "scripts": {
@@ -40,13 +39,13 @@
     "build:watch:esm": "tsc -p tsconfig.esm.json -w --preserveWatchOutput",
     "clean": "rimraf dist coverage",
     "link:yarn": "yarn link",
-    "lint": "run-s lint:prettier lint:tslint",
+    "lint": "run-s lint:prettier lint:eslint",
     "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
-    "lint:tslint": "tslint -t stylish -p .",
-    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
-    "fix": "run-s fix:tslint fix:prettier",
+    "lint:eslint": "eslint . --format stylish",
+    "lint:eslint:json": "eslint . --format json | tee lint-results.json",
+    "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
-    "fix:tslint": "tslint --fix -t stylish -p .",
+    "fix:eslint": "lint:eslint --fix",
     "test": "jest",
     "test:watch": "jest --watch"
   },