handle falsy flags

mydea · mydea · commit 086958eafec7 · 2025-07-15T10:32:54.000+02:00
diff --git a/packages/core/src/utils/featureFlags.ts b/packages/core/src/utils/featureFlags.ts
@@ -140,7 +140,7 @@ export function _INTERNAL_addFeatureFlagToActiveSpan(
   const attributes = spanToJSON(span).data;
 
   // If the flag already exists, always update it
-  if (attributes[`${SPAN_FLAG_ATTRIBUTE_PREFIX}${name}`]) {
+  if (attributes[`${SPAN_FLAG_ATTRIBUTE_PREFIX}${name}`] != null) {
     span.setAttribute(`${SPAN_FLAG_ATTRIBUTE_PREFIX}${name}`, value);
     return;
   }

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ export function _INTERNAL_addFeatureFlagToActiveSpan(`
`140`	`140`	`const attributes = spanToJSON(span).data;`
`141`	`141`
`142`	`142`	`// If the flag already exists, always update it`
`143`		- if (attributes[`${SPAN_FLAG_ATTRIBUTE_PREFIX}${name}`]) {
	`143`	+ if (attributes[`${SPAN_FLAG_ATTRIBUTE_PREFIX}${name}`] != null) {
`144`	`144`	span.setAttribute(`${SPAN_FLAG_ATTRIBUTE_PREFIX}${name}`, value);
`145`	`145`	`return;`
`146`	`146`	`}`