Skip to content

Commit 090e7cc

Browse files
authored
test(e2e/firebase): Fix firebase e2e test failing due to outdated rules file (#17448)
To test our firebase instrumentation, we spin up a firebase emulator with firestore rules. Looks like by default, the generated rules file was set to only allow general data access for 30 days. This caused CI to suddenly fail from Aug 17 onwards (and went unnoticed until today due to Hackweek). Since this is just us running the emulator in a CI job, I think it's okay to allow access unconditionally. Not sure though, so happy to think of something else if reviewers have concerns.
1 parent 3bf4a30 commit 090e7cc

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,8 @@ rules_version='2'
33
service cloud.firestore {
44
match /databases/{database}/documents {
55
match /{document=**} {
6-
// This rule allows anyone with your database reference to view, edit,
7-
// and delete all data in your database. It is useful for getting
8-
// started, but it is configured to expire after 30 days because it
9-
// leaves your app open to attackers. At that time, all client
10-
// requests to your database will be denied.
11-
//
12-
// Make sure to write security rules for your app before that time, or
13-
// else all client requests to your database will be denied until you
14-
// update your rules.
15-
allow read, write: if request.time < timestamp.date(2025, 8, 17);
6+
// general access within this test app's emulator is fine
7+
allow read, write: if true;
168
}
179
}
1810
}

0 commit comments

Comments
 (0)