Skip to content

Commit 0942281

Browse files
Lms24AbhiPrasad
andauthored
fix(replay): Add CDN bundle path to release artifacts (#6452)
Craft uses the release artifacts zip generated by our "Upload Artifacts" job to search for files to upload. Our bundle path (`packages/replay/build/bundles`) wasn't added to this job's config so it wasn't included in the release. This patch fixes that and it also adds an entry to our release checklist. It furthermore bumps the minimum version for the CDN bundles in the Replay README. Docs should automatically pick up the newest version, so we don't need to bump anything in getsentry/sentry-docs#5899 Co-authored-by: Abhijeet Prasad <[email protected]>
1 parent 0366852 commit 0942281

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ jobs:
344344
${{ github.workspace }}/packages/browser/build/bundles/**
345345
${{ github.workspace }}/packages/integrations/build/bundles/**
346346
${{ github.workspace }}/packages/tracing/build/bundles/**
347+
${{ github.workspace }}/packages/replay/build/bundles/**
347348
${{ github.workspace }}/packages/**/*.tgz
348349
349350
job_unit_test:

docs/new-sdk-release-checklist.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ This page serves as a checklist of what to do when releasing a new SDK for the f
4040
- [ ] Ensure dependent packages are correctly set for “Determine changed packages”
4141
- [ ] Ensure unit tests run correctly
4242

43+
- [ ] Make sure the file paths in the ["Upload Artifacts" job](https://github.com/getsentry/sentry-javascript/blob/e5c1486eed236b878f2c49d6a04be86093816ac9/.github/workflows/build.yml#L314-L349) in `build.yml` include your new artifacts.
44+
- **This is especially important, if you're adding new CDN bundles!**
45+
- Tarballs (*.tgz archives) should work OOTB
46+
4347
## Cutting the Release
4448

4549
When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important:

0 commit comments

Comments
 (0)