rename to maxIncomingRequestBodySize

Author: s1gr1d

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/generatePayload.ts renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/generatePayload.ts

@@ -6,5 +6,5 @@ Sentry.init({
   release: '1.0',
   tracesSampleRate: 1.0,
   transport: loggingTransport,
-  integrations: [Sentry.httpIntegration({ maxRequestBodySize: 'always' })],
+  integrations: [Sentry.httpIntegration({ maxIncomingRequestBodySize: 'always' })],
 });

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/instrument-always.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-always.mjs

@@ -6,5 +6,5 @@ Sentry.init({
   release: '1.0',
   tracesSampleRate: 1.0,
   transport: loggingTransport,
-  integrations: [Sentry.httpIntegration({ maxRequestBodySize: 'medium' })],
+  integrations: [Sentry.httpIntegration({ maxIncomingRequestBodySize: 'medium' })],
 });

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/instrument-default.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-default.mjs

@@ -8,7 +8,7 @@ Sentry.init({
   transport: loggingTransport,
   integrations: [
     Sentry.httpIntegration({
-      maxRequestBodySize: 'none',
+      maxIncomingRequestBodySize: 'none',
       ignoreIncomingRequestBody: url => url.includes('/ignore-request-body'),
     }),
   ],

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/instrument-medium.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-medium.mjs

@@ -6,5 +6,5 @@ Sentry.init({
   release: '1.0',
   tracesSampleRate: 1.0,
   transport: loggingTransport,
-  integrations: [Sentry.httpIntegration({ maxRequestBodySize: 'small' })],
+  integrations: [Sentry.httpIntegration({ maxIncomingRequestBodySize: 'small' })],
 });

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/instrument-none.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-none.mjs

@@ -12,7 +12,7 @@ const MAX_GENERAL = 1024 * 1024; // 1MB
 const MAX_MEDIUM = 10_000;
 const MAX_SMALL = 1000;
 
-describe('express with httpIntegration and not defined maxRequestBodySize', () => {
+describe('express with httpIntegration and not defined maxIncomingRequestBodySize', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
@@ -60,7 +60,7 @@ describe('express with httpIntegration and not defined maxRequestBodySize', () =
   });
 });
 
-describe('express with httpIntegration and maxRequestBodySize: "none"', () => {
+describe('express with httpIntegration and maxIncomingRequestBodySize: "none"', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
@@ -127,7 +127,7 @@ describe('express with httpIntegration and maxRequestBodySize: "none"', () => {
   );
 });
 
-describe('express with httpIntegration and maxRequestBodySize: "always"', () => {
+describe('express with httpIntegration and maxIncomingRequestBodySize: "always"', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
@@ -181,7 +181,7 @@ describe('express with httpIntegration and maxRequestBodySize: "always"', () =>
   );
 });
 
-describe('express with httpIntegration and maxRequestBodySize: "small"', () => {
+describe('express with httpIntegration and maxIncomingRequestBodySize: "small"', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
@@ -256,7 +256,7 @@ describe('express with httpIntegration and maxRequestBodySize: "small"', () => {
   );
 });
 
-describe('express with httpIntegration and maxRequestBodySize: "medium"', () => {
+describe('express with httpIntegration and maxIncomingRequestBodySize: "medium"', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/instrument-small.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/instrument-small.mjs

@@ -70,7 +70,7 @@ export type SentryHttpInstrumentationOptions = InstrumentationConfig & {
   ignoreIncomingRequestBody?: (url: string, request: http.RequestOptions) => boolean;
 
   /**
-   * Controls the maximum size of HTTP request bodies attached to events.
+   * Controls the maximum size of incoming HTTP request bodies attached to events.
    *
    * Available options:
    * - 'none': No request bodies will be attached
@@ -83,7 +83,7 @@ export type SentryHttpInstrumentationOptions = InstrumentationConfig & {
    *
    * @default 'medium'
    */
-  maxRequestBodySize?: 'none' | 'small' | 'medium' | 'always';
+  maxIncomingRequestBodySize?: 'none' | 'small' | 'medium' | 'always';
 
   /**
    * Whether the integration should create [Sessions](https://docs.sentry.io/product/releases/health/#sessions) for incoming requests to track the health and crash-free rate of your releases in Sentry.
@@ -242,7 +242,7 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
 
     // eslint-disable-next-line @typescript-eslint/no-this-alias
     const instrumentation = this;
-    const { ignoreIncomingRequestBody, maxRequestBodySize = 'medium' } = instrumentation.getConfig();
+    const { ignoreIncomingRequestBody, maxIncomingRequestBodySize = 'medium' } = instrumentation.getConfig();
 
     const newEmit = new Proxy(originalEmit, {
       apply(target, thisArg, args: [event: string, ...args: unknown[]]) {
@@ -263,8 +263,8 @@ export class SentryHttpInstrumentation extends InstrumentationBase<SentryHttpIns
         const ipAddress = (request as { ip?: string }).ip || request.socket?.remoteAddress;
 
         const url = request.url || '/';
-        if (!ignoreIncomingRequestBody?.(url, request) && maxRequestBodySize !== 'none') {
-          patchRequestToCaptureBody(request, isolationScope, maxRequestBodySize);
+        if (!ignoreIncomingRequestBody?.(url, request) && maxIncomingRequestBodySize !== 'none') {
+          patchRequestToCaptureBody(request, isolationScope, maxIncomingRequestBodySize);
         }
 
         // Update the isolation scope, isolate this request
@@ -372,7 +372,7 @@ function getBreadcrumbData(request: http.ClientRequest): Partial<SanitizedReques
 function patchRequestToCaptureBody(
   req: http.IncomingMessage,
   isolationScope: Scope,
-  maxRequestBodySize: 'small' | 'medium' | 'always',
+  maxIncomingRequestBodySize: 'small' | 'medium' | 'always',
 ): void {
   let bodyByteLength = 0;
   const chunks: Buffer[] = [];
@@ -387,7 +387,11 @@ function patchRequestToCaptureBody(
   const callbackMap = new WeakMap();
 
   const maxBodySize =
-    maxRequestBodySize === 'small' ? 1_000 : maxRequestBodySize === 'medium' ? 10_000 : MAX_BODY_BYTE_LENGTH;
+    maxIncomingRequestBodySize === 'small'
+      ? 1_000
+      : maxIncomingRequestBodySize === 'medium'
+        ? 10_000
+        : MAX_BODY_BYTE_LENGTH;
 
   try {
     // eslint-disable-next-line @typescript-eslint/unbound-method

dev-packages/node-integration-tests/suites/express/with-http/maxRequestBodySize/scenario.mjs renamed to dev-packages/node-integration-tests/suites/express/with-http/maxIncomingRequestBodySize/scenario.mjs

@@ -91,7 +91,7 @@ interface HttpOptions {
   ignoreIncomingRequestBody?: (url: string, request: RequestOptions) => boolean;
 
   /**
-   * Controls the maximum size of HTTP request bodies attached to events.
+   * Controls the maximum size of incoming HTTP request bodies attached to events.
    *
    * Available options:
    * - 'none': No request bodies will be attached
@@ -104,7 +104,7 @@ interface HttpOptions {
    *
    * @default 'medium'
    */
-  maxRequestBodySize?: 'none' | 'small' | 'medium' | 'always';
+  maxIncomingRequestBodySize?: 'none' | 'small' | 'medium' | 'always';
 
   /**
    * If true, do not generate spans for incoming requests at all.