Merge branch 'develop' into onur/firebase-instrumentation

Author: onurtemizkan

.size-limit.js

@@ -233,7 +233,7 @@ module.exports = [
     import: createImport('init'),
     ignore: [...builtinModules, ...nodePrefixedBuiltinModules],
     gzip: true,
-    limit: '145 KB',
+    limit: '146 KB',
   },
   {
     name: '@sentry/node - without tracing',

MIGRATION.md

@@ -61,16 +61,6 @@ Sentry.init({
 });
 ```
 
-## No Version Support Timeline
-
-Version support timelines are stressful for everybody using the SDK, so we won't be defining one.
-Instead, we will be applying bug fixes and features to older versions as long as there is demand.
-
-Additionally, we hold ourselves accountable to any security issues, meaning that if any vulnerabilities are found, we will in almost all cases backport them.
-
-Note, that it is decided on a case-per-case basis, what gets backported or not.
-If you need a fix or feature in a previous version of the SDK, please reach out via a GitHub Issue.
-
 ## 3. Behaviour Changes
 
 ### Removal of First Input Delay (FID) Web Vital Reporting
@@ -87,3 +77,13 @@ The removal entails **no breaking API changes**. However, in rare cases, you mig
 - Remove any logic in `beforeSend` or other filtering/event processing logic that depends on FID or replace it with INP logic.
 - If you set up Sentry Alerts that depend on FID, be aware that these could trigger once you upgrade the SDK, due to a lack of new values.
   To replace them, adjust your alerts (or dashbaords) to use INP.
+
+## No Version Support Timeline
+
+Version support timelines are stressful for everybody using the SDK, so we won't be defining one.
+Instead, we will be applying bug fixes and features to older versions as long as there is demand.
+
+Additionally, we hold ourselves accountable to any security issues, meaning that if any vulnerabilities are found, we will in almost all cases backport them.
+
+Note, that it is decided on a case-per-case basis, what gets backported or not.
+If you need a fix or feature in a previous version of the SDK, please reach out via a GitHub Issue.

dev-packages/e2e-tests/test-applications/aws-lambda-layer-cjs/package.json

@@ -19,8 +19,5 @@
   },
   "volta": {
     "extends": "../../package.json"
-  },
-  "sentryTest": {
-    "skip": true
   }
 }

dev-packages/e2e-tests/test-applications/aws-lambda-layer-esm/package.json

@@ -19,8 +19,5 @@
   },
   "volta": {
     "extends": "../../package.json"
-  },
-  "sentryTest": {
-    "skip": true
   }
 }

dev-packages/e2e-tests/test-applications/nextjs-15/.gitignore

@@ -44,3 +44,5 @@ next-env.d.ts
 
 test-results
 event-dumps
+
+.tmp_dev_server_logs

dev-packages/e2e-tests/test-applications/nextjs-15/app/page.tsx

@@ -0,0 +1,3 @@
+export default function Page() {
+  return <p>Next 15 test app</p>;
+}

dev-packages/e2e-tests/test-applications/nextjs-15/package.json

@@ -4,7 +4,7 @@
   "private": true,
   "scripts": {
     "build": "next build > .tmp_build_stdout 2> .tmp_build_stderr || (cat .tmp_build_stdout && cat .tmp_build_stderr && exit 1)",
-    "clean": "npx rimraf node_modules pnpm-lock.yaml",
+    "clean": "npx rimraf node_modules pnpm-lock.yaml .tmp_dev_server_logs",
     "test:prod": "TEST_ENV=production playwright test",
     "test:dev": "TEST_ENV=development playwright test",
     "test:dev-turbo": "TEST_ENV=dev-turbopack playwright test",

dev-packages/e2e-tests/test-applications/nextjs-15/playwright.config.mjs

@@ -7,11 +7,11 @@ if (!testEnv) {
 
 const getStartCommand = () => {
   if (testEnv === 'dev-turbopack') {
-    return 'pnpm next dev -p 3030 --turbopack';
+    return 'pnpm next dev -p 3030 --turbopack 2>&1 | tee .tmp_dev_server_logs';
   }
 
   if (testEnv === 'development') {
-    return 'pnpm next dev -p 3030';
+    return 'pnpm next dev -p 3030 2>&1 | tee .tmp_dev_server_logs';
   }
 
   if (testEnv === 'production') {

dev-packages/e2e-tests/test-applications/nextjs-15/tests/async-params.test.ts

@@ -0,0 +1,16 @@
+import { expect, test } from '@playwright/test';
+import fs from 'fs';
+
+test('should not print warning for async params', async ({ page }) => {
+  test.skip(
+    process.env.TEST_ENV !== 'development' && process.env.TEST_ENV !== 'dev-turbopack',
+    'should be skipped for non-dev mode',
+  );
+  await page.goto('/');
+
+  // If the server exits with code 1, the test will fail (see instrumentation.ts)
+  const devStdout = fs.readFileSync('.tmp_dev_server_logs', 'utf-8');
+  expect(devStdout).not.toContain('`params` should be awaited before using its properties.');
+
+  await expect(page.getByText('Next 15 test app')).toBeVisible();
+});

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/devErrorSymbolification.test.ts

@@ -1,35 +1,30 @@
 import { expect, test } from '@playwright/test';
 import { waitForError } from '@sentry-internal/test-utils';
 
-test.describe('dev mode error symbolification', () => {
-  if (process.env.TEST_ENV !== 'development') {
-    test.skip('should be skipped for non-dev mode', () => {});
-    return;
-  }
+test('should have symbolicated dev errors', async ({ page }) => {
+  test.skip(process.env.TEST_ENV !== 'development', 'should be skipped for non-dev mode');
 
-  test('should have symbolicated dev errors', async ({ page }) => {
-    await page.goto('/');
+  await page.goto('/');
 
-    const errorEventPromise = waitForError('nextjs-app-dir', errorEvent => {
-      return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
-    });
+  const errorEventPromise = waitForError('nextjs-app-dir', errorEvent => {
+    return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
+  });
 
-    await page.getByText('Throw error').click();
+  await page.getByText('Throw error').click();
 
-    const errorEvent = await errorEventPromise;
-    const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;
+  const errorEvent = await errorEventPromise;
+  const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;
 
-    expect(errorEventFrames?.[errorEventFrames?.length - 1]).toEqual(
-      expect.objectContaining({
-        function: 'onClick',
-        filename: 'components/client-error-debug-tools.tsx',
-        lineno: 54,
-        colno: expect.any(Number),
-        in_app: true,
-        pre_context: ['       <button', '         onClick={() => {'],
-        context_line: "           throw new Error('Click Error');",
-        post_context: ['         }}', '       >', '         Throw error'],
-      }),
-    );
-  });
+  expect(errorEventFrames?.[errorEventFrames?.length - 1]).toEqual(
+    expect.objectContaining({
+      function: 'onClick',
+      filename: 'components/client-error-debug-tools.tsx',
+      lineno: 54,
+      colno: expect.any(Number),
+      in_app: true,
+      pre_context: ['       <button', '         onClick={() => {'],
+      context_line: "           throw new Error('Click Error');",
+      post_context: ['         }}', '       >', '         Throw error'],
+    }),
+  );
 });