Skip to content

Commit 0f4e2f6

Browse files
committed
Merge branch 'aliu/span-flags-v2' of https://github.com/getsentry/sentry-javascript into aliu/move-ffs-to-core
2 parents b3d746b + a323c38 commit 0f4e2f6

File tree

5 files changed

+30
-0
lines changed

5 files changed

+30
-0
lines changed

packages/browser/src/integrations/featureFlags/launchdarkly/integration.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,13 @@ export function buildLaunchDarklyFlagUsedHandler(): LDInspectionFlagUsedHandler
4949
* Handle a flag evaluation by storing its name and value on the current scope.
5050
*/
5151
method: (flagKey: string, flagDetail: LDEvaluationDetail, _context: LDContext) => {
52+
<<<<<<< HEAD
5253
_INTERNAL_insertFlagToScope(flagKey, flagDetail.value);
5354
_INTERNAL_addFeatureFlagToActiveSpan(flagKey, flagDetail.value);
55+
=======
56+
insertFlagToScope(flagKey, flagDetail.value);
57+
addFeatureFlagToActiveSpan(flagKey, flagDetail.value);
58+
>>>>>>> a323c38aad748683232bdae557dd0afc4e682c74
5459
},
5560
};
5661
}

packages/browser/src/integrations/featureFlags/openfeature/integration.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,25 @@ export class OpenFeatureIntegrationHook implements OpenFeatureHook {
4040
* Successful evaluation result.
4141
*/
4242
public after(_hookContext: Readonly<HookContext<JsonValue>>, evaluationDetails: EvaluationDetails<JsonValue>): void {
43+
<<<<<<< HEAD
4344
_INTERNAL_insertFlagToScope(evaluationDetails.flagKey, evaluationDetails.value);
4445
_INTERNAL_addFeatureFlagToActiveSpan(evaluationDetails.flagKey, evaluationDetails.value);
46+
=======
47+
insertFlagToScope(evaluationDetails.flagKey, evaluationDetails.value);
48+
addFeatureFlagToActiveSpan(evaluationDetails.flagKey, evaluationDetails.value);
49+
>>>>>>> a323c38aad748683232bdae557dd0afc4e682c74
4550
}
4651

4752
/**
4853
* On error evaluation result.
4954
*/
5055
public error(hookContext: Readonly<HookContext<JsonValue>>, _error: unknown, _hookHints?: HookHints): void {
56+
<<<<<<< HEAD
5157
_INTERNAL_insertFlagToScope(hookContext.flagKey, hookContext.defaultValue);
5258
_INTERNAL_addFeatureFlagToActiveSpan(hookContext.flagKey, hookContext.defaultValue);
59+
=======
60+
insertFlagToScope(hookContext.flagKey, hookContext.defaultValue);
61+
addFeatureFlagToActiveSpan(hookContext.flagKey, hookContext.defaultValue);
62+
>>>>>>> a323c38aad748683232bdae557dd0afc4e682c74
5363
}
5464
}

packages/browser/src/integrations/featureFlags/statsig/integration.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,13 @@ export const statsigIntegration = defineIntegration(
3737

3838
setup(_client: Client) {
3939
statsigClient.on('gate_evaluation', (event: { gate: FeatureGate }) => {
40+
<<<<<<< HEAD
4041
_INTERNAL_insertFlagToScope(event.gate.name, event.gate.value);
4142
_INTERNAL_addFeatureFlagToActiveSpan(event.gate.name, event.gate.value);
43+
=======
44+
insertFlagToScope(event.gate.name, event.gate.value);
45+
addFeatureFlagToActiveSpan(event.gate.name, event.gate.value);
46+
>>>>>>> a323c38aad748683232bdae557dd0afc4e682c74
4247
});
4348
},
4449

packages/browser/src/integrations/featureFlags/unleash/integration.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,13 @@ function _wrappedIsEnabled(
7070
const result = original.apply(this, args);
7171

7272
if (typeof toggleName === 'string' && typeof result === 'boolean') {
73+
<<<<<<< HEAD
7374
_INTERNAL_insertFlagToScope(toggleName, result);
7475
_INTERNAL_addFeatureFlagToActiveSpan(toggleName, result);
76+
=======
77+
insertFlagToScope(toggleName, result);
78+
addFeatureFlagToActiveSpan(toggleName, result);
79+
>>>>>>> a323c38aad748683232bdae557dd0afc4e682c74
7580
} else if (DEBUG_BUILD) {
7681
logger.error(
7782
`[Feature Flags] UnleashClient.isEnabled does not match expected signature. arg0: ${toggleName} (${typeof toggleName}), result: ${result} (${typeof result})`,

packages/core/src/integrations/featureFlags/featureFlagsIntegration.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,13 @@ export const featureFlagsIntegration = defineIntegration(() => {
4545
},
4646

4747
addFeatureFlag(name: string, value: unknown): void {
48+
<<<<<<< HEAD:packages/core/src/integrations/featureFlags/featureFlagsIntegration.ts
4849
_INTERNAL_insertFlagToScope(name, value);
4950
_INTERNAL_addFeatureFlagToActiveSpan(name, value);
51+
=======
52+
insertFlagToScope(name, value);
53+
addFeatureFlagToActiveSpan(name, value);
54+
>>>>>>> a323c38aad748683232bdae557dd0afc4e682c74:packages/browser/src/integrations/featureFlags/featureFlagsIntegration.ts
5055
},
5156
};
5257
}) as IntegrationFn<FeatureFlagsIntegration>;

0 commit comments

Comments
 (0)