feat: enable biome recommended linter rules

Author: anonrig

.eslintrc.js

@@ -28,6 +28,10 @@ module.exports = {
       rules: {
         // Disabled because it's included with Biome's linter
         'no-control-regex': 'off',
+        'no-param-reassign': 'off',
+        'prefer-const': 'off',
+        '@typescript-eslint/ban-types': 'off',
+        'react-hooks/exhaustive-deps': 'off',
       },
     },
     {

.size-limit.js

@@ -20,7 +20,7 @@ module.exports = [
     import: '{ init, Replay, BrowserTracing }',
     gzip: true,
     limit: '75 KB',
-    modifyWebpackConfig: function (config) {
+    modifyWebpackConfig: config => {
       const webpack = require('webpack');
       config.plugins.push(
         new webpack.DefinePlugin({

biome.json

@@ -11,18 +11,60 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": false,
+      "recommended": true,
+      "a11y": {
+        "all": false
+      },
+      "complexity": {
+        "noForEach": "off",
+        "noUselessConstructor": "off",
+        "noStaticOnlyClass": "off",
+        "useOptionalChain": "off",
+        "useLiteralKeys": "off"
+      },
       "correctness": {
-        "all": false,
-        "noUnusedVariables": "error",
-        "noPrecisionLoss": "error"
+        "noEmptyPattern": "off",
+        "noInnerDeclarations": "off",
+        "noVoidTypeReturn": "off",
+        "noEmptyCharacterClassInRegex": "off"
+      },
+      "performance": {
+        "noDelete": "off"
+      },
+      "security": {
+        "all": true
+      },
+      "style": {
+        "noArguments": "off",
+        "noCommaOperator": "off",
+        "noNonNullAssertion": "off",
+        "noUselessElse": "off",
+        "useTemplate": "off",
+        "noVar": "off",
+        "useSingleVarDeclarator": "off",
+        "useDefaultParameterLast": "off",
+        "useExponentiationOperator": "off"
       },
       "suspicious": {
-        "all": false,
-        "noControlCharactersInRegex": "error"
+        "noDebugger": "off",
+        "noDoubleEquals": "off",
+        "noExplicitAny": "off",
+        "noRedeclare": "off",
+        "noAssignInExpressions": "off",
+        "noConfusingVoidType": "off",
+        "noPrototypeBuiltins": "off",
+        "noShadowRestrictedNames": "off",
+        "noControlCharactersInRegex": "off"
       }
     },
-    "ignore": [".vscode/*", "**/*.json"]
+    "ignore": [
+      ".vscode/*",
+      "**/*.json",
+      "**/*.min.js",
+      "packages/browser-integration-tests/fixtures/loader.js",
+      "packages/browser/test/integration/polyfills/*.js",
+      "packages/replay-worker/examples/worker.js"
+    ]
   },
   "files": {
     "ignoreUnknown": true
@@ -44,6 +86,7 @@
     ]
   },
   "javascript": {
+    "globals": ["expect", "describe", "test", "it", "beforeEach", "afterEach", "beforeAll", "afterAll"],
     "formatter": {
       "enabled": true,
       "quoteStyle": "single",

package.json

@@ -20,7 +20,7 @@
     "codecov": "codecov",
     "fix": "run-s fix:lerna fix:biome",
     "fix:lerna": "lerna run fix",
-    "fix:biome": "biome check --apply-unsafe .",
+    "fix:biome": "biome check --apply .",
     "changelog": "ts-node ./scripts/get-commit-list.ts",
     "link:yarn": "lerna exec yarn link",
     "lint": "run-s lint:lerna lint:biome",

packages/angular/src/tracing.ts

@@ -27,8 +27,8 @@ let stashedStartTransactionOnLocationChange: boolean;
  */
 export function routingInstrumentation(
   customStartTransaction: (context: TransactionContext) => Transaction | undefined,
-  startTransactionOnPageLoad: boolean = true,
-  startTransactionOnLocationChange: boolean = true,
+  startTransactionOnPageLoad = true,
+  startTransactionOnLocationChange = true,
 ): void {
   instrumentationInitialized = true;
   stashedStartTransaction = customStartTransaction;
@@ -260,7 +260,8 @@ export function TraceClassDecorator(): ClassDecorator {
  * Decorator function that can be used to capture a single lifecycle methods of the component.
  */
 export function TraceMethodDecorator(): MethodDecorator {
-  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+  // biome-ignore lint/complexity/noBannedTypes: Disable
   return (target: Object, propertyKey: string | symbol, descriptor: PropertyDescriptor) => {
     const originalMethod = descriptor.value;
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -300,7 +301,7 @@ export function getParameterizedRouteFromSnapshot(route?: ActivatedRouteSnapshot
   let currentRoute = route && route.firstChild;
   while (currentRoute) {
     const path = currentRoute && currentRoute.routeConfig && currentRoute.routeConfig.path;
-    if (path === null || path === undefined) {
+    if (path == null) {
       break;
     }
 

packages/browser-integration-tests/loader-suites/loader/noOnLoad/unhandeledPromiseRejectionHandler/subject.js

@@ -1,3 +1,3 @@
-new Promise(function (resolve, reject) {
+new Promise((resolve, reject) => {
   reject('this is unhandled');
 });

packages/browser-integration-tests/loader-suites/loader/onLoad/captureExceptionInOnLoad/init.js

@@ -1,4 +1,4 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   // You _have_ to call Sentry.init() before calling Sentry.captureException() in Sentry.onLoad()!
   Sentry.init();
   Sentry.captureException('Test exception');

packages/browser-integration-tests/loader-suites/loader/onLoad/customBrowserTracing/init.js

@@ -1,6 +1,6 @@
 window._testBaseTimestamp = performance.timeOrigin / 1000;
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [
       // Without this syntax, this will be re-written by the test framework

packages/browser-integration-tests/loader-suites/loader/onLoad/customInit/init.js

@@ -1,7 +1,7 @@
 window.__sentryOnLoad = 0;
 
 setTimeout(() => {
-  Sentry.onLoad(function () {
+  Sentry.onLoad(() => {
     window.__hadSentry = window.sentryIsLoaded();
 
     Sentry.init({

packages/browser-integration-tests/loader-suites/loader/onLoad/customIntegrations/init.js

@@ -6,7 +6,7 @@ class CustomIntegration {
   setupOnce() {}
 }
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [new CustomIntegration()],
   });