ref: Use optional chaining where possible (#14954)

This PR updates our code to use optional chaining, where possible.

This was mostly search-and-replace by `xx && xx.` regex, so there may
def. be some remaining places, but this should cover a good amount of
usage.

---------

Co-authored-by: Lukas Stracke <[email protected]>

Author: mydea

dev-packages/browser-integration-tests/loader-suites/loader/noOnLoad/customOnErrorHandler/subject.js

@@ -2,7 +2,7 @@ const oldOnError = window.onerror;
 
 window.onerror = function () {
   console.log('custom error');
-  oldOnError && oldOnError.apply(this, arguments);
+  oldOnError?.apply(this, arguments);
 };
 
 window.doSomethingWrong();

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/init.js

@@ -13,7 +13,7 @@ Sentry.init({
 // Also, no SDK has mock utils for FlagUsedHandler's.
 const MockLaunchDarkly = {
   initialize(_clientId, context, options) {
-    const flagUsedHandler = options && options.inspectors ? options.inspectors[0].method : undefined;
+    const flagUsedHandler = options.inspectors ? options.inspectors[0].method : undefined;
 
     return {
       variation(key, defaultValue) {

dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/subject.js

@@ -1,4 +1,4 @@
-const sentryCarrier = window && window.__SENTRY__;
+const sentryCarrier = window?.__SENTRY__;
 
 /**
  * Simulate an old pre v8 SDK obtaining the hub from the global sentry carrier

dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/subject.js

@@ -1,4 +1,4 @@
-const sentryCarrier = window && window.__SENTRY__;
+const sentryCarrier = window?.__SENTRY__;
 
 /**
  * Simulate an old pre v8 SDK obtaining the hub from the global sentry carrier

dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/app/routes/navigate.tsx

@@ -14,7 +14,7 @@ export default function LoaderError() {
 
   return (
     <div>
-      <h1>{data && data.test ? data.test : 'Not Found'}</h1>
+      <h1>{data?.test ? data.test : 'Not Found'}</h1>
     </div>
   );
 }

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/app/routes/navigate.tsx

@@ -14,7 +14,7 @@ export default function LoaderError() {
 
   return (
     <div>
-      <h1>{data && data.test ? data.test : 'Not Found'}</h1>
+      <h1>{data?.test ? data.test : 'Not Found'}</h1>
     </div>
   );
 }

dev-packages/e2e-tests/test-applications/create-remix-app-express/app/routes/navigate.tsx

@@ -14,7 +14,7 @@ export default function LoaderError() {
 
   return (
     <div>
-      <h1>{data && data.test ? data.test : 'Not Found'}</h1>
+      <h1>{data?.test ? data.test : 'Not Found'}</h1>
     </div>
   );
 }

dev-packages/e2e-tests/test-applications/create-remix-app-legacy/app/routes/navigate.tsx

@@ -14,7 +14,7 @@ export default function LoaderError() {
 
   return (
     <div>
-      <h1>{data && data.test ? data.test : 'Not Found'}</h1>
+      <h1>{data?.test ? data.test : 'Not Found'}</h1>
     </div>
   );
 }

dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/app/routes/navigate.tsx

@@ -14,7 +14,7 @@ export default function LoaderError() {
 
   return (
     <div>
-      <h1>{data && data.test ? data.test : 'Not Found'}</h1>
+      <h1>{data?.test ? data.test : 'Not Found'}</h1>
     </div>
   );
 }

dev-packages/e2e-tests/test-applications/create-remix-app-v2/app/routes/navigate.tsx

@@ -14,7 +14,7 @@ export default function LoaderError() {
 
   return (
     <div>
-      <h1>{data && data.test ? data.test : 'Not Found'}</h1>
+      <h1>{data?.test ? data.test : 'Not Found'}</h1>
     </div>
   );
 }