Merge branch 'develop' into cg-add-route-handler-tests

Author: chargome

CHANGELOG.md

@@ -4,8 +4,55 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 10.12.0
+
 ### Important Changes
 
+- **ref: Add and Adjust error event `mechanism` values**
+
+  This release includes a variety of changes aimed at setting the `mechanism` field on errors captured automatically by the Sentry SDKs. [The intention](https://github.com/getsentry/sentry-javascript/issues/17212) is to clearly mark which instrumentation captured an error. In addition, some instrumentations previously did not yet annotate the error as handled or unhandled which this series of PRs corrects as well.
+
+  <details>
+  <summary> Relevant PRs </summary>
+
+  <br/>
+
+  Released in `10.12.0`:
+  - ref(angular): Adjust ErrorHandler event mechanism ([#17608](https://github.com/getsentry/sentry-javascript/pull/17608))
+  - ref(astro): Adjust `mechanism` on error events captured by astro middleware ([#17613](https://github.com/getsentry/sentry-javascript/pull/17613))
+  - ref(aws-severless): Slightly adjust aws-serverless mechanism type ([#17614](https://github.com/getsentry/sentry-javascript/pull/17614))
+  - ref(bun): Adjust `mechanism` of errors captured in Bun.serve ([#17616](https://github.com/getsentry/sentry-javascript/pull/17616))
+  - ref(cloudflare): Adjust event `mechanisms` and durable object origin ([#17618](https://github.com/getsentry/sentry-javascript/pull/17618))
+  - ref(core): Adjust `mechanism` in `captureConsoleIntegration` ([#17633](https://github.com/getsentry/sentry-javascript/pull/17633))
+  - ref(core): Adjust MCP server error event `mechanism` ([#17622](https://github.com/getsentry/sentry-javascript/pull/17622))
+  - ref(core): Simplify `linkedErrors` mechanism logic ([#17600](https://github.com/getsentry/sentry-javascript/pull/17600))
+  - ref(deno): Adjust `mechanism` of errors caught by `globalHandlersIntegration` ([#17635](https://github.com/getsentry/sentry-javascript/pull/17635))
+  - ref(nextjs): Set more specific event `mechanism`s ([#17543](https://github.com/getsentry/sentry-javascript/pull/17543))
+  - ref(node): Adjust mechanism of express, hapi and fastify error handlers ([#17623](https://github.com/getsentry/sentry-javascript/pull/17623))
+  - ref(node-core): Add `mechanism` to cron instrumentations ([#17544](https://github.com/getsentry/sentry-javascript/pull/17544))
+  - ref(node-core): Add more specific `mechanism.type` to worker thread errors from `childProcessIntegration` ([#17578](https://github.com/getsentry/sentry-javascript/pull/17578))
+  - ref(node-core): Adjust `mechanism` of `onUnhandledRejection` and `onUnhandledException` integrations ([#17636](https://github.com/getsentry/sentry-javascript/pull/17636))
+  - ref(node): Add mechanism to errors captured via connect and koa integrations ([#17579](https://github.com/getsentry/sentry-javascript/pull/17579))
+  - ref(nuxt): Add and adjust `mechanism.type` in error events ([#17599](https://github.com/getsentry/sentry-javascript/pull/17599))
+  - ref(react): Add mechanism to `reactErrorHandler` and adjust mechanism in `ErrorBoundary` ([#17602](https://github.com/getsentry/sentry-javascript/pull/17602))
+  - ref(remix): Adjust event mechanism of `captureRemixServerException` ([#17629](https://github.com/getsentry/sentry-javascript/pull/17629))
+  - ref(replay-internal): Add mechanism to error caught by `replayIntegration` in debug mode ([#17606](https://github.com/getsentry/sentry-javascript/pull/17606))
+  - ref(solid): Add `mechanism` to error captured by `withSentryErrorBoundary` ([#17607](https://github.com/getsentry/sentry-javascript/pull/17607))
+  - ref(solidstart): Adjust event mechanism in withServerActionInstrumentation ([#17637](https://github.com/getsentry/sentry-javascript/pull/17637))
+  - ref(sveltekit): Adjust `mechanism` of error events ([#17646](https://github.com/getsentry/sentry-javascript/pull/17646))
+  - ref(vue): Adjust mechanism in Vue error handler ([#17647](https://github.com/getsentry/sentry-javascript/pull/17647))
+
+  <br/>
+
+  Released in `10.11.0`:
+  - ref(browser): Add more specific `mechanism.type` to errors captured by `httpClientIntegration` ([#17254](https://github.com/getsentry/sentry-javascript/pull/17254))
+  - ref(browser): Set more descriptive `mechanism.type` in `browserApiErrorsIntergation` ([#17251](https://github.com/getsentry/sentry-javascript/pull/17251))
+  - ref(core): Add `mechanism.type` to `trpcMiddleware` errors ([#17287](https://github.com/getsentry/sentry-javascript/pull/17287))
+  - ref(core): Add more specific event `mechanism`s and span origins to `openAiIntegration` ([#17288](https://github.com/getsentry/sentry-javascript/pull/17288))
+  - ref(nestjs): Add `mechanism` to captured errors ([#17312](https://github.com/getsentry/sentry-javascript/pull/17312))
+
+</details>
+
 - **feat(node) Ensure `prismaIntegration` works with Prisma 5 ([#17595](https://github.com/getsentry/sentry-javascript/pull/17595))**
 
 We used to require to pass in the v5 version of `@prisma/instrumentation` into `prismaIntegration({ prismaInstrumentation: new PrismaInstrumentation() })`, if you wanted to get full instrumentation for Prisma v5. However, it turns out this does not work on v10 of the SDK anymore, because `@prisma/instrumentation@5` requires OTEL v1.
@@ -44,6 +91,47 @@ With this release, we dropped the requirement to configure anything to get v5 su
   - @opentelemetry/instrumentation-undici bumped to ^0.15.0
   - @prisma/instrumentation bumped to 6.15.0
 
+### Other Changes
+
+- feat(browser): Add timing and status atttributes to resource spans ([#17562](https://github.com/getsentry/sentry-javascript/pull/17562))
+- feat(cloudflare,vercel-edge): Add support for Anthropic AI instrumentation ([#17571](https://github.com/getsentry/sentry-javascript/pull/17571))
+- feat(core): Add Consola integration ([#17435](https://github.com/getsentry/sentry-javascript/pull/17435))
+- feat(deps): Update OpenTelemetry dependencies ([#17569](https://github.com/getsentry/sentry-javascript/pull/17569))
+- feat(core): Export `TracesSamplerSamplingContext` type ([#17523](https://github.com/getsentry/sentry-javascript/pull/17523))
+- feat(deno): Add OpenTelemetry support and vercelAI integration ([#17445](https://github.com/getsentry/sentry-javascript/pull/17445))
+- feat(node-core): Remove experimental note from winston api ([#17626](https://github.com/getsentry/sentry-javascript/pull/17626))
+- feat(node): Ensure `prismaIntegration` works with Prisma v5 ([#17595](https://github.com/getsentry/sentry-javascript/pull/17595))
+- feat(node): Tidy existing ESM loader hook ([#17566](https://github.com/getsentry/sentry-javascript/pull/17566))
+- feat(sveltekit): Align build time options with shared type ([#17413](https://github.com/getsentry/sentry-javascript/pull/17413))
+- fix(core): Fix error handling when sending envelopes ([#17662](https://github.com/getsentry/sentry-javascript/pull/17662))
+- fix(browser): Always start navigation as root span ([#17648](https://github.com/getsentry/sentry-javascript/pull/17648))
+- fix(browser): Ensure propagated `parentSpanId` stays consistent during trace in TwP mode ([#17526](https://github.com/getsentry/sentry-javascript/pull/17526))
+- fix(cloudflare): Initialize once per workflow run and preserve scope for `step.do` ([#17582](https://github.com/getsentry/sentry-javascript/pull/17582))
+- fix(nextjs): Add edge polyfills for nextjs-13 in dev mode ([#17488](https://github.com/getsentry/sentry-javascript/pull/17488))
+- fix(nitro): Support nested `_platform` properties in Nitro 2.11.7+ ([#17596](https://github.com/getsentry/sentry-javascript/pull/17596))
+- fix(node): Preserve synchronous return behavior for streamText and other methods for AI ([#17580](https://github.com/getsentry/sentry-javascript/pull/17580))
+- ref(node): Inline types imported from `shimmer` ([#17597](https://github.com/getsentry/sentry-javascript/pull/17597)) - ref(nuxt): Add and adjust `mechanism.type` in error events ([#17599](https://github.com/getsentry/sentry-javascript/pull/17599))
+- ref(browser): Improve `fetchTransport` error handling ([#17661](https://github.com/getsentry/sentry-javascript/pull/17661))
+
+<details>
+  <summary> <strong>Internal Changes</strong> </summary>
+
+- chore: Add changelog note about mechanism changes ([#17632](https://github.com/getsentry/sentry-javascript/pull/17632))
+- chore(aws): Update README.md ([#17601](https://github.com/getsentry/sentry-javascript/pull/17601))
+- chore(deps): bump hono from 4.7.10 to 4.9.7 in /dev-packages/e2e-tests/test-applications/cloudflare-hono ([#17630](https://github.com/getsentry/sentry-javascript/pull/17630))
+- chore(deps): bump next from 14.2.25 to 14.2.32 in /dev-packages/e2e-tests/test-applications/nextjs-app-dir ([#17627](https://github.com/getsentry/sentry-javascript/pull/17627))
+- chore(deps): bump next from 14.2.25 to 14.2.32 in /dev-packages/e2e-tests/test-applications/nextjs-pages-dir ([#17620](https://github.com/getsentry/sentry-javascript/pull/17620))
+- chore(deps): bump next from 14.2.29 to 14.2.32 in /dev-packages/e2e-tests/test-applications/nextjs-orpc ([#17494](https://github.com/getsentry/sentry-javascript/pull/17494))
+- chore(deps): bump next from 14.2.30 to 14.2.32 in /dev-packages/e2e-tests/test-applications/nextjs-14 ([#17628](https://github.com/getsentry/sentry-javascript/pull/17628))
+- chore(repo): Rename `.claude/settings.local.json` to `.claude/settings.json` ([#17591](https://github.com/getsentry/sentry-javascript/pull/17591))
+- docs(issue-template): Add note about prioritization ([#17590](https://github.com/getsentry/sentry-javascript/pull/17590))
+- ref(core): Streamline event processor handling ([#17634](https://github.com/getsentry/sentry-javascript/pull/17634))
+- test(angular): Bump TS version to 5.9.0 in Angular 20 e2e test ([#17605](https://github.com/getsentry/sentry-javascript/pull/17605))
+- test(nextjs): Remove Next 13 and pin Next 14 canary and latest tests ([#17577](https://github.com/getsentry/sentry-javascript/pull/17577))
+- test(react-router): Unflake `flushIfServerless` test ([#17610](https://github.com/getsentry/sentry-javascript/pull/17610))
+
+</details>
+
 ## 10.11.0
 
 ### Important Changes

dev-packages/browser-integration-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "10.11.0",
+  "version": "10.12.0",
   "main": "index.js",
   "license": "MIT",
   "engines": {
@@ -43,7 +43,7 @@
     "@babel/preset-typescript": "^7.16.7",
     "@playwright/test": "~1.53.2",
     "@sentry-internal/rrweb": "2.34.0",
-    "@sentry/browser": "10.11.0",
+    "@sentry/browser": "10.12.0",
     "@supabase/supabase-js": "2.49.3",
     "axios": "1.8.2",
     "babel-loader": "^8.2.2",

dev-packages/browser-integration-tests/suites/integrations/captureConsole-attachStackTrace/test.ts

@@ -37,7 +37,7 @@ sentryTest(
     expect(logEvent?.exception?.values![0]).toMatchObject({
       mechanism: {
         handled: true,
-        type: 'console',
+        type: 'auto.core.capture_console',
         synthetic: true,
       },
       value: 'console log',
@@ -59,7 +59,7 @@ sentryTest(
     expect(warnEvent?.exception?.values![0]).toMatchObject({
       mechanism: {
         handled: true,
-        type: 'console',
+        type: 'auto.core.capture_console',
         synthetic: true,
       },
       value: 'console warn',
@@ -81,7 +81,7 @@ sentryTest(
     expect(infoEvent?.exception?.values![0]).toMatchObject({
       mechanism: {
         handled: true,
-        type: 'console',
+        type: 'auto.core.capture_console',
         synthetic: true,
       },
       value: 'console info',
@@ -103,7 +103,7 @@ sentryTest(
     expect(errorEvent?.exception?.values![0]).toMatchObject({
       mechanism: {
         handled: true,
-        type: 'console',
+        type: 'auto.core.capture_console',
         synthetic: true,
       },
       value: 'console error',
@@ -125,7 +125,7 @@ sentryTest(
     expect(traceEvent?.exception?.values![0]).toMatchObject({
       mechanism: {
         handled: true,
-        type: 'console',
+        type: 'auto.core.capture_console',
         synthetic: true,
       },
       value: 'console trace',
@@ -153,7 +153,7 @@ sentryTest(
     expect(errorWithErrorEvent?.exception?.values?.[0].value).toBe('console error with error object');
     expect(errorWithErrorEvent?.exception?.values?.[0].mechanism).toEqual({
       handled: true,
-      type: 'console',
+      type: 'auto.core.capture_console',
     });
     expect(traceWithErrorEvent).toEqual(
       expect.objectContaining({

dev-packages/browser-integration-tests/suites/integrations/captureConsole/test.ts

@@ -96,7 +96,7 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
   expect(errorWithErrorEvent?.exception?.values?.[0].value).toBe('console error with error object');
   expect(errorWithErrorEvent?.exception?.values?.[0].mechanism).toEqual({
     handled: true,
-    type: 'console',
+    type: 'auto.core.capture_console',
   });
   expect(traceWithErrorEvent).toEqual(
     expect.objectContaining({

dev-packages/browser-integration-tests/suites/integrations/thirdPartyErrorsFilter/init.js

@@ -0,0 +1,34 @@
+import * as Sentry from '@sentry/browser';
+// eslint-disable-next-line import/no-duplicates
+import { thirdPartyErrorFilterIntegration } from '@sentry/browser';
+// eslint-disable-next-line import/no-duplicates
+import { captureConsoleIntegration } from '@sentry/browser';
+
+// This is the code the bundler plugin would inject to mark the init bundle as a first party module:
+var _sentryModuleMetadataGlobal =
+  typeof window !== 'undefined'
+    ? window
+    : typeof global !== 'undefined'
+      ? global
+      : typeof self !== 'undefined'
+        ? self
+        : {};
+
+_sentryModuleMetadataGlobal._sentryModuleMetadata = _sentryModuleMetadataGlobal._sentryModuleMetadata || {};
+
+_sentryModuleMetadataGlobal._sentryModuleMetadata[new Error().stack] = Object.assign(
+  {},
+  _sentryModuleMetadataGlobal._sentryModuleMetadata[new Error().stack],
+  {
+    '_sentryBundlerPluginAppKey:my-app': true,
+  },
+);
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  integrations: [
+    thirdPartyErrorFilterIntegration({ behaviour: 'apply-tag-if-contains-third-party-frames', filterKeys: ['my-app'] }),
+    captureConsoleIntegration({ levels: ['error'], handled: false }),
+  ],
+  attachStacktrace: true,
+});

dev-packages/browser-integration-tests/suites/integrations/thirdPartyErrorsFilter/subject.js

@@ -0,0 +1,28 @@
+// This is the code the bundler plugin would inject to mark the subject bundle as a first party module:
+var _sentryModuleMetadataGlobal =
+  typeof window !== 'undefined'
+    ? window
+    : typeof global !== 'undefined'
+      ? global
+      : typeof self !== 'undefined'
+        ? self
+        : {};
+
+_sentryModuleMetadataGlobal._sentryModuleMetadata = _sentryModuleMetadataGlobal._sentryModuleMetadata || {};
+
+_sentryModuleMetadataGlobal._sentryModuleMetadata[new Error().stack] = Object.assign(
+  {},
+  _sentryModuleMetadataGlobal._sentryModuleMetadata[new Error().stack],
+  {
+    '_sentryBundlerPluginAppKey:my-app': true,
+  },
+);
+
+const errorBtn = document.getElementById('errBtn');
+errorBtn.addEventListener('click', async () => {
+  Promise.allSettled([Promise.reject('I am a first party Error')]).then(values =>
+    values.forEach(value => {
+      if (value.status === 'rejected') console.error(value.reason);
+    }),
+  );
+});

dev-packages/browser-integration-tests/suites/integrations/thirdPartyErrorsFilter/template.html

@@ -0,0 +1,10 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <body>
+    <script src="thirdPartyScript.js"></script>
+    <button id="errBtn">Throw 1st part yerror</button>
+  </body>
+</html>

dev-packages/browser-integration-tests/suites/integrations/thirdPartyErrorsFilter/test.ts

@@ -0,0 +1,82 @@
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { expect } from '@playwright/test';
+import { sentryTest } from '../../../utils/fixtures';
+import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';
+
+const bundle = process.env.PW_BUNDLE || '';
+// We only want to run this in non-CDN bundle mode because
+// thirdPartyErrorFilterIntegration is only available in the NPM package
+if (bundle.startsWith('bundle')) {
+  sentryTest.skip();
+}
+
+sentryTest('tags event if contains at least one third-party frame', async ({ getLocalTestUrl, page }) => {
+  const url = await getLocalTestUrl({ testDir: __dirname });
+
+  const errorEventPromise = waitForErrorRequest(page, e => {
+    return e.exception?.values?.[0]?.value === 'I am a third party Error';
+  });
+
+  await page.route('**/thirdPartyScript.js', route =>
+    route.fulfill({
+      status: 200,
+      body: readFileSync(join(__dirname, 'thirdPartyScript.js')),
+    }),
+  );
+
+  await page.goto(url);
+
+  const errorEvent = envelopeRequestParser(await errorEventPromise);
+  expect(errorEvent.tags?.third_party_code).toBe(true);
+});
+
+/**
+ * This test seems a bit more complicated than necessary but this is intentional:
+ * When using `captureConsoleIntegration` in combination with `thirdPartyErrorFilterIntegration`
+ * and `attachStacktrace: true`, the stack trace includes native code stack frames which previously broke
+ * the third party error filtering logic.
+ *
+ * see https://github.com/getsentry/sentry-javascript/issues/17674
+ */
+sentryTest(
+  "doesn't tag event if doesn't contain third-party frames",
+  async ({ getLocalTestUrl, page, browserName }) => {
+    const url = await getLocalTestUrl({ testDir: __dirname });
+
+    const errorEventPromise = waitForErrorRequest(page, e => {
+      return e.exception?.values?.[0]?.value === 'I am a first party Error';
+    });
+
+    await page.route('**/thirdPartyScript.js', route =>
+      route.fulfill({
+        status: 200,
+        body: readFileSync(join(__dirname, 'thirdPartyScript.js')),
+      }),
+    );
+
+    await page.goto(url);
+
+    await page.click('#errBtn');
+
+    const errorEvent = envelopeRequestParser(await errorEventPromise);
+
+    expect(errorEvent.tags?.third_party_code).toBeUndefined();
+
+    // ensure the stack trace includes native code stack frames which previously broke
+    // the third party error filtering logic
+    if (browserName === 'chromium') {
+      expect(errorEvent.exception?.values?.[0]?.stacktrace?.frames).toContainEqual({
+        filename: '<anonymous>',
+        function: 'Array.forEach',
+        in_app: true,
+      });
+    } else if (browserName === 'webkit') {
+      expect(errorEvent.exception?.values?.[0]?.stacktrace?.frames).toContainEqual({
+        filename: '[native code]',
+        function: 'forEach',
+        in_app: true,
+      });
+    }
+  },
+);

dev-packages/browser-integration-tests/suites/integrations/thirdPartyErrorsFilter/thirdPartyScript.js

@@ -0,0 +1,3 @@
+setTimeout(() => {
+  throw new Error('I am a third party Error');
+}, 100);

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions-navigation-click/init.js

@@ -0,0 +1,13 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://[email protected]/1337',
+  tracesSampleRate: 1,
+  integrations: [
+    Sentry.browserTracingIntegration({
+      _experiments: { enableInteractions: true },
+    }),
+  ],
+});