build: update biome to v1.5.2 (#10102)

anonrig · andreiborza · web-flow · commit 13bb652e0686 · 2024-12-12T11:20:43.000+01:00
Co-authored-by: Andrei Borza &lt;andrei.borza@sentry.io&gt;
diff --git a/biome.json b/biome.json
@@ -3,7 +3,8 @@
   "vcs": {
     "enabled": true,
     "clientKind": "git",
-    "useIgnoreFile": true
+    "useIgnoreFile": true,
+    "defaultBranch": "develop"
   },
   "organizeImports": {
     "enabled": true
@@ -17,13 +18,15 @@
         "noUnusedVariables": "error",
         "noPrecisionLoss": "error"
       },
+      "complexity": {
+        "useRegexLiterals": "error"
+      },
       "suspicious": {
         "all": false,
         "noControlCharactersInRegex": "error"
       },
       "nursery": {
-        "noUnusedImports": "error",
-        "useRegexLiterals": "error"
+        "noUnusedImports": "error"
       },
       "performance": {
         "all": true,
@@ -92,6 +95,10 @@
   "json": {
     "formatter": {
       "enabled": true
+    },
+    "parser": {
+      "allowComments": true,
+      "allowTrailingCommas": true
     }
   }
 }
diff --git a/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/subject.js b/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));
diff --git a/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/subject.js b/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));
diff --git a/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized/subject.js b/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));
diff --git a/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp/subject.js b/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp/subject.js
@@ -1,17 +1,19 @@
-const blockUI = (delay = 70) => e => {
-  const startTime = Date.now();
+const blockUI =
+  (delay = 70) =>
+  e => {
+    const startTime = Date.now();
 
-  function getElasped() {
-    const time = Date.now();
-    return time - startTime;
-  }
+    function getElasped() {
+      const time = Date.now();
+      return time - startTime;
+    }
 
-  while (getElasped() < delay) {
-    //
-  }
+    while (getElasped() < delay) {
+      //
+    }
 
-  e.target.classList.add('clicked');
-};
+    e.target.classList.add('clicked');
+  };
 
 document.querySelector('[data-test-id=not-so-slow-button]').addEventListener('click', blockUI(300));
 document.querySelector('[data-test-id=slow-button]').addEventListener('click', blockUI(450));
diff --git a/dev-packages/browser-integration-tests/utils/helpers.ts b/dev-packages/browser-integration-tests/utils/helpers.ts
@@ -134,13 +134,10 @@ export const countEnvelopes = async (
 
     page.on('request', requestHandler);
 
-    setTimeout(
-      () => {
-        page.off('request', requestHandler);
-        resolve(reqCount);
-      },
-      options?.timeout || 1000,
-    );
+    setTimeout(() => {
+      page.off('request', requestHandler);
+      resolve(reqCount);
+    }, options?.timeout || 1000);
   });
 
   if (options?.url) {
diff --git a/dev-packages/e2e-tests/test-applications/angular-17/tsconfig.app.json b/dev-packages/e2e-tests/test-applications/angular-17/tsconfig.app.json
@@ -5,10 +5,6 @@
     "outDir": "./out-tsc/app",
     "types": []
   },
-  "files": [
-    "src/main.ts"
-  ],
-  "include": [
-    "src/**/*.d.ts"
-  ]
+  "files": ["src/main.ts"],
+  "include": ["src/**/*.d.ts"]
 }
diff --git a/dev-packages/e2e-tests/test-applications/angular-18/tsconfig.app.json b/dev-packages/e2e-tests/test-applications/angular-18/tsconfig.app.json
@@ -5,10 +5,6 @@
     "outDir": "./out-tsc/app",
     "types": []
   },
-  "files": [
-    "src/main.ts"
-  ],
-  "include": [
-    "src/**/*.d.ts"
-  ]
+  "files": ["src/main.ts"],
+  "include": ["src/**/*.d.ts"]
 }
diff --git a/dev-packages/e2e-tests/test-applications/angular-19/tsconfig.app.json b/dev-packages/e2e-tests/test-applications/angular-19/tsconfig.app.json
@@ -6,10 +6,6 @@
     "outDir": "./out-tsc/app",
     "types": []
   },
-  "files": [
-    "src/main.ts"
-  ],
-  "include": [
-    "src/**/*.d.ts"
-  ]
+  "files": ["src/main.ts"],
+  "include": ["src/**/*.d.ts"]
 }
diff --git a/dev-packages/e2e-tests/test-applications/angular-19/tsconfig.spec.json b/dev-packages/e2e-tests/test-applications/angular-19/tsconfig.spec.json
@@ -4,12 +4,7 @@
   "extends": "./tsconfig.json",
   "compilerOptions": {
     "outDir": "./out-tsc/spec",
-    "types": [
-      "jasmine"
-    ]
+    "types": ["jasmine"]
   },
-  "include": [
-    "src/**/*.spec.ts",
-    "src/**/*.d.ts"
-  ]
+  "include": ["src/**/*.spec.ts", "src/**/*.d.ts"]
 }
diff --git a/dev-packages/e2e-tests/test-applications/ember-classic/tsconfig.app.json b/dev-packages/e2e-tests/test-applications/ember-classic/tsconfig.app.json
@@ -18,15 +18,11 @@
       ],
     }
   },
-  "include": [
-    "app/**/*",
-    "types/**/*"
-  ],
+  "include": ["app/**/*", "types/**/*"],
   "exclude": ["tests/**/*"],
   "ts-node": {
     "compilerOptions": {
       "module": "CommonJS"
     }
   }
-
 }
diff --git a/dev-packages/e2e-tests/test-applications/ember-embroider/tsconfig.app.json b/dev-packages/e2e-tests/test-applications/ember-embroider/tsconfig.app.json
@@ -18,15 +18,11 @@
       ],
     }
   },
-  "include": [
-    "app/**/*",
-    "types/**/*"
-  ],
+  "include": ["app/**/*", "types/**/*"],
   "exclude": ["tests/**/*"],
   "ts-node": {
     "compilerOptions": {
       "module": "CommonJS"
     }
   }
-
 }
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-t3/tailwind.config.ts b/dev-packages/e2e-tests/test-applications/nextjs-t3/tailwind.config.ts
@@ -1,7 +1,7 @@
 import { type Config } from 'tailwindcss';
 import { fontFamily } from 'tailwindcss/defaultTheme';
 
-export default ({
+export default {
   content: ['./src/**/*.tsx'],
   theme: {
     extend: {
@@ -11,4 +11,4 @@ export default ({
     },
   },
   plugins: [],
-} satisfies Config);
+} satisfies Config;
diff --git a/package.json b/package.json
@@ -98,7 +98,7 @@
     "dev-packages/rollup-utils"
   ],
   "devDependencies": {
-    "@biomejs/biome": "^1.4.0",
+    "@biomejs/biome": "^1.5.2",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-esm-shim": "^0.1.5",
     "@rollup/plugin-json": "^6.1.0",
diff --git a/packages/angular/test/errorhandler.test.ts b/packages/angular/test/errorhandler.test.ts
@@ -24,7 +24,10 @@ class CustomError extends Error {
 }
 
 class ErrorLikeShapedClass implements Partial<Error> {
-  constructor(public name: string, public message: string) {}
+  constructor(
+    public name: string,
+    public message: string,
+  ) {}
 }
 
 function createErrorEvent(message: string, innerError: any): ErrorEvent {
diff --git a/packages/browser-utils/tsconfig.types.json b/packages/browser-utils/tsconfig.types.json
@@ -4,11 +4,7 @@
   // the fact that it introduces a dependency on `@sentry/browser` which doesn't exist anywhere else in the SDK, which
   // then prevents us from building that and this at the same time when doing a parallellized build from the repo root
   // level.
-  "exclude": [
-    "src/index.bundle.ts",
-    "src/index.bundle.feedback.ts",
-    "src/index.bundle.replay.ts"
-  ],
+  "exclude": ["src/index.bundle.ts", "src/index.bundle.feedback.ts", "src/index.bundle.replay.ts"],
   "compilerOptions": {
     "declaration": true,
     "declarationMap": true,
diff --git a/packages/browser/src/integrations/browserapierrors.ts b/packages/browser/src/integrations/browserapierrors.ts
@@ -171,7 +171,7 @@ function _wrapEventTarget(target: string): void {
     return;
   }
 
-  fill(proto, 'addEventListener', function (original: VoidFunction,): (
+  fill(proto, 'addEventListener', function (original: VoidFunction): (
     ...args: Parameters<typeof WINDOW.addEventListener>
   ) => ReturnType<typeof WINDOW.addEventListener> {
     return function (this: unknown, eventName, fn, options): VoidFunction {
@@ -217,7 +217,7 @@ function _wrapEventTarget(target: string): void {
     };
   });
 
-  fill(proto, 'removeEventListener', function (originalRemoveEventListener: VoidFunction,): (
+  fill(proto, 'removeEventListener', function (originalRemoveEventListener: VoidFunction): (
     this: unknown,
     ...args: Parameters<typeof WINDOW.removeEventListener>
   ) => ReturnType<typeof WINDOW.removeEventListener> {
diff --git a/packages/browser/src/integrations/reportingobserver.ts b/packages/browser/src/integrations/reportingobserver.ts
@@ -54,7 +54,10 @@ interface ReportingObserverOptions {
 
 /** This is experimental and the types are not included with TypeScript, sadly. */
 interface ReportingObserverClass {
-  new (handler: (reports: Report[]) => void, options: { buffered?: boolean; types?: ReportTypes[] }): {
+  new (
+    handler: (reports: Report[]) => void,
+    options: { buffered?: boolean; types?: ReportTypes[] },
+  ): {
     observe: () => void;
   };
 }
diff --git a/packages/core/src/utils-hoist/error.ts b/packages/core/src/utils-hoist/error.ts
@@ -7,7 +7,10 @@ export class SentryError extends Error {
 
   public logLevel: ConsoleLevel;
 
-  public constructor(public message: string, logLevel: ConsoleLevel = 'warn') {
+  public constructor(
+    public message: string,
+    logLevel: ConsoleLevel = 'warn',
+  ) {
     super(message);
 
     this.name = new.target.prototype.constructor.name;
diff --git a/packages/core/src/utils-hoist/object.ts b/packages/core/src/utils-hoist/object.ts
@@ -109,9 +109,7 @@ export function urlEncode(object: { [key: string]: any }): string {
  * @returns An Event or Error turned into an object - or the value argument itself, when value is neither an Event nor
  *  an Error.
  */
-export function convertToPlainObject<V>(
-  value: V,
-):
+export function convertToPlainObject<V>(value: V):
   | {
       [ownProps: string]: unknown;
       type: string;
diff --git a/packages/nextjs/src/common/pages-router-instrumentation/wrapPageComponentWithSentry.ts b/packages/nextjs/src/common/pages-router-instrumentation/wrapPageComponentWithSentry.ts
@@ -5,7 +5,9 @@ interface FunctionComponent {
 }
 
 interface ClassComponent {
-  new (...args: unknown[]): {
+  new (
+    ...args: unknown[]
+  ): {
     props?: unknown;
     render(...args: unknown[]): unknown;
   };
diff --git a/packages/nextjs/src/config/loaders/valueInjectionLoader.ts b/packages/nextjs/src/config/loaders/valueInjectionLoader.ts
@@ -12,7 +12,7 @@ export type ValueInjectionLoaderOptions = {
 // This regex is shamelessly stolen from: https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/7f984482c73e4284e8b12a08dfedf23b5a82f0af/packages/bundler-plugin-core/src/index.ts#L535-L539
 const SKIP_COMMENT_AND_DIRECTIVE_REGEX =
   // Note: CodeQL complains that this regex potentially has n^2 runtime. This likely won't affect realistic files.
-  // biome-ignore lint/nursery/useRegexLiterals: No user input
+  // biome-ignore lint/complexity/useRegexLiterals: No user input
   new RegExp('^(?:\\s*|/\\*(?:.|\\r|\\n)*?\\*/|//.*[\\n\\r])*(?:"[^"]*";?|\'[^\']*\';?)?');
 
 /**
diff --git a/packages/node/src/sdk/client.ts b/packages/node/src/sdk/client.ts
diff --git a/packages/remix/test/integration/test/server/utils/helpers.ts b/packages/remix/test/integration/test/server/utils/helpers.ts
diff --git a/packages/replay-worker/src/worker.ts b/packages/replay-worker/src/worker.ts
diff --git a/yarn.lock b/yarn.lock
