Apply suggestions from Copilot review

Co-authored-by: Copilot <[email protected]>

Author: onurtemizkan

packages/react/src/reactrouter-compat-utils/instrumentation.tsx

@@ -112,10 +112,7 @@ const allRoutes = new Set<RouteObject>();
 /**
  * Processes resolved routes by adding them to allRoutes and checking for nested async handlers.
  */
-export function processResolvedRoutes(
-  resolvedRoutes: RouteObject[],
-  parentRoute?: RouteObject,
-  currentLocation?: Location,
+  currentLocation: Location | null = null,
 ): void {
   resolvedRoutes.forEach(child => {
     allRoutes.add(child);
@@ -137,11 +134,7 @@ export function processResolvedRoutes(
 
     // Try to use the provided location first, then fall back to global window location if needed
     let location = currentLocation;
-    if (!location) {
-      if (typeof WINDOW !== 'undefined') {
-        const globalLocation = WINDOW.location;
-        if (globalLocation) {
-          location = { pathname: globalLocation.pathname };
+          location = createDefaultLocation(globalLocation.pathname);
         }
       }
     }
@@ -553,9 +546,8 @@ function wrapPatchRoutesOnNavigation(
       // Update navigation span after routes are patched
       const activeRootSpan = getActiveRootSpan();
       if (activeRootSpan && (spanToJSON(activeRootSpan) as { op?: string }).op === 'navigation') {
-        // For memory routers, we don't have a reliable way to get the current pathname
-        // without accessing window.location, so we'll use targetPath for both cases
-        const pathname = targetPath || (isMemoryRouter ? WINDOW.location?.pathname : undefined);
+        // For memory routers, we should not access window.location; use targetPath only
+        const pathname = isMemoryRouter ? targetPath : targetPath || WINDOW.location?.pathname;
         if (pathname) {
           updateNavigationSpan(
             activeRootSpan,

packages/react/src/reactrouter-compat-utils/utils.ts

@@ -252,8 +252,8 @@ export function getNormalizedName(
   }
 
   const fallbackTransactionName = _stripBasename
-    ? stripBasenameFromPathname(location.pathname, basename)
-    : location.pathname;
+    ? stripBasenameFromPathname(location.pathname ?? '', basename)
+    : location.pathname ?? '';
 
   return [fallbackTransactionName, 'url'];
 }