review feedback

Author: mjq

packages/nextjs/src/config/manifest/createRouteManifest.ts

@@ -77,10 +77,10 @@ function buildRegexForDynamicRoute(routePath: string): { regex: string; paramNam
 
   let pattern: string;
   if (hasOptionalCatchall) {
-    if (regexSegments.length == 0) {
+    if (regexSegments.length === 0) {
       // If the optional catchall happens at the root, accept any path starting
-      // with a slash.
-      pattern = '^/.*$';
+      // with a slash. Need capturing group for parameter extraction.
+      pattern = '^/(.*)$';
     } else {
       // For optional catchall, make the trailing slash and segments optional
       // This allows matching both /catchall and /catchall/anything

packages/nextjs/test/config/manifest/suites/catchall-at-root/catchall-at-root.test.ts

@@ -11,7 +11,7 @@ describe('catchall', () => {
       dynamicRoutes: [
         {
           path: '/:path*?',
-          regex: '^/.*$',
+          regex: '^/(.*)$',
           paramNames: ['path'],
         },
       ],