Skip to content

Commit 19724f4

Browse files
committed
chore: use playwright image for E2E tests
1 parent fd26569 commit 19724f4

File tree

110 files changed

+115
-153
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+115
-153
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ jobs:
557557
matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
558558
needs: [job_get_metadata, job_build]
559559
if: needs.job_build.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
560-
runs-on: ubuntu-24.04-large-js
560+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
561561
timeout-minutes: 25
562562
strategy:
563563
fail-fast: false
@@ -615,11 +615,6 @@ jobs:
615615
with:
616616
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
617617

618-
- name: Install Playwright
619-
uses: ./.github/actions/install-playwright
620-
with:
621-
browsers: ${{ matrix.project }}
622-
623618
- name: Run Playwright tests
624619
env:
625620
PW_BUNDLE: ${{ matrix.bundle }}
@@ -651,7 +646,7 @@ jobs:
651646
name: PW ${{ matrix.bundle }} Tests
652647
needs: [job_get_metadata, job_build]
653648
if: needs.job_build.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
654-
runs-on: ubuntu-24.04
649+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
655650
timeout-minutes: 15
656651
strategy:
657652
fail-fast: false
@@ -679,11 +674,6 @@ jobs:
679674
with:
680675
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
681676

682-
- name: Install Playwright
683-
uses: ./.github/actions/install-playwright
684-
with:
685-
browsers: chromium
686-
687677
- name: Run Playwright Loader tests
688678
env:
689679
PW_BUNDLE: ${{ matrix.bundle }}
@@ -809,7 +799,7 @@ jobs:
809799
name: Remix (Node ${{ matrix.node }}) Tests
810800
needs: [job_get_metadata, job_build]
811801
if: needs.job_build.outputs.changed_remix == 'true' || github.event_name != 'pull_request'
812-
runs-on: ubuntu-24.04
802+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
813803
timeout-minutes: 10
814804
strategy:
815805
fail-fast: false
@@ -829,11 +819,6 @@ jobs:
829819
with:
830820
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
831821

832-
- name: Install Playwright
833-
uses: ./.github/actions/install-playwright
834-
with:
835-
browsers: chromium
836-
837822
- name: Run integration tests
838823
env:
839824
NODE_VERSION: ${{ matrix.node }}
@@ -918,7 +903,7 @@ jobs:
918903
if:
919904
always() && needs.job_e2e_prepare.result == 'success' && needs.job_e2e_prepare.outputs.matrix != '{"include":[]}'
920905
needs: [job_get_metadata, job_build, job_e2e_prepare]
921-
runs-on: ubuntu-24.04
906+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
922907
timeout-minutes: 15
923908
env:
924909
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -993,12 +978,6 @@ jobs:
993978
timeout-minutes: 7
994979
run: ${{ matrix.build-command || 'pnpm test:build' }}
995980

996-
- name: Install Playwright
997-
uses: ./.github/actions/install-playwright
998-
with:
999-
browsers: chromium
1000-
cwd: ${{ runner.temp }}/test-application
1001-
1002981
- name: Run E2E test
1003982
working-directory: ${{ runner.temp }}/test-application
1004983
timeout-minutes: 10
@@ -1047,7 +1026,7 @@ jobs:
10471026
needs.job_e2e_prepare.outputs.matrix-optional != '{"include":[]}' && (github.event_name != 'pull_request' ||
10481027
github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]'
10491028
needs: [job_get_metadata, job_build, job_e2e_prepare]
1050-
runs-on: ubuntu-24.04
1029+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
10511030
timeout-minutes: 15
10521031
env:
10531032
E2E_TEST_AUTH_TOKEN: ${{ secrets.E2E_TEST_AUTH_TOKEN }}
@@ -1114,12 +1093,6 @@ jobs:
11141093
timeout-minutes: 7
11151094
run: ${{ matrix.build-command || 'pnpm test:build' }}
11161095

1117-
- name: Install Playwright
1118-
uses: ./.github/actions/install-playwright
1119-
with:
1120-
browsers: chromium
1121-
cwd: ${{ runner.temp }}/test-application
1122-
11231096
- name: Run E2E test
11241097
working-directory: ${{ runner.temp }}/test-application
11251098
timeout-minutes: 10

.github/workflows/canary.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
job_e2e_tests:
5555
name: E2E ${{ matrix.label }} Test
5656
needs: [job_e2e_prepare]
57-
runs-on: ubuntu-24.04
57+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
5858
timeout-minutes: 20
5959
env:
6060
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -159,12 +159,6 @@ jobs:
159159
timeout-minutes: 7
160160
run: yarn ${{ matrix.build-command }}
161161

162-
- name: Install Playwright
163-
uses: ./.github/actions/install-playwright
164-
with:
165-
browsers: chromium
166-
cwd: ${{ runner.temp }}/test-application
167-
168162
- name: Run E2E test
169163
working-directory: ${{ runner.temp }}/test-application
170164
timeout-minutes: 15

.github/workflows/flaky-test-detector.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ concurrency:
2323

2424
jobs:
2525
flaky-detector:
26-
runs-on: ubuntu-24.04
26+
runs-on: mcr.microsoft.com/playwright:v1.53.2-jammy
2727
timeout-minutes: 60
2828
name: 'Check tests for flakiness'
2929
# Also skip if PR is from master -> develop
@@ -49,11 +49,6 @@ jobs:
4949
- name: Build packages
5050
run: yarn build
5151

52-
- name: Install Playwright
53-
uses: ./.github/actions/install-playwright
54-
with:
55-
browsers: 'chromium'
56-
5752
- name: Determine changed tests
5853
uses: dorny/[email protected]
5954
id: changed

dev-packages/browser-integration-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"dependencies": {
4242
"@babel/core": "^7.27.7",
4343
"@babel/preset-typescript": "^7.16.7",
44-
"@playwright/test": "~1.53.2",
44+
"@playwright/test": "1.53.2",
4545
"@sentry-internal/rrweb": "2.34.0",
4646
"@sentry/browser": "10.21.0",
4747
"@supabase/supabase-js": "2.49.3",

dev-packages/e2e-tests/test-applications/angular-17/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"zone.js": "~0.14.3"
3030
},
3131
"devDependencies": {
32-
"@playwright/test": "~1.53.2",
32+
"@playwright/test": "1.53.2",
3333
"@sentry-internal/test-utils": "link:../../../test-utils",
3434
"@sentry/core": "latest || *",
3535
"@angular-devkit/build-angular": "^17.1.1",

dev-packages/e2e-tests/test-applications/angular-18/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"zone.js": "~0.14.3"
3030
},
3131
"devDependencies": {
32-
"@playwright/test": "~1.53.2",
32+
"@playwright/test": "1.53.2",
3333
"@sentry-internal/test-utils": "link:../../../test-utils",
3434
"@sentry/core": "latest || *",
3535
"@angular-devkit/build-angular": "^18.0.0",

dev-packages/e2e-tests/test-applications/angular-19/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"@angular-devkit/build-angular": "^19.0.0",
3333
"@angular/cli": "^19.0.0",
3434
"@angular/compiler-cli": "^19.0.0",
35-
"@playwright/test": "~1.53.2",
35+
"@playwright/test": "1.53.2",
3636
"@sentry-internal/test-utils": "link:../../../test-utils",
3737
"@sentry/core": "latest || *",
3838
"@types/jasmine": "~5.1.0",

dev-packages/e2e-tests/test-applications/angular-20/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"@angular-devkit/build-angular": "^20.0.0",
3434
"@angular/cli": "^20.0.0",
3535
"@angular/compiler-cli": "^20.0.0",
36-
"@playwright/test": "~1.53.2",
36+
"@playwright/test": "1.53.2",
3737
"@sentry-internal/test-utils": "link:../../../test-utils",
3838
"@sentry/core": "latest || *",
3939
"@types/jasmine": "~5.1.0",

dev-packages/e2e-tests/test-applications/astro-4/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"dependencies": {
1515
"@astrojs/check": "0.9.2",
1616
"@astrojs/node": "8.3.4",
17-
"@playwright/test": "~1.53.2",
17+
"@playwright/test": "1.53.2",
1818
"@sentry/astro": "* || latest",
1919
"@sentry-internal/test-utils": "link:../../../test-utils",
2020
"@spotlightjs/astro": "2.1.6",

dev-packages/e2e-tests/test-applications/astro-5/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"dependencies": {
1515
"@astrojs/internal-helpers": "^0.4.2",
1616
"@astrojs/node": "^9.0.0",
17-
"@playwright/test": "~1.53.2",
17+
"@playwright/test": "1.53.2",
1818
"@sentry-internal/test-utils": "link:../../../test-utils",
1919
"@sentry/astro": "latest || *",
2020
"astro": "^5.0.3"

0 commit comments

Comments
 (0)