Rm getVariant code

Author: aliu39

dev-packages/browser-integration-tests/suites/integrations/featureFlags/unleash/basic/test.ts

@@ -6,7 +6,7 @@ import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest
 
 const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
 
-sentryTest('Basic isEnabled test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
+sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {
     sentryTest.skip();
   }
@@ -47,45 +47,3 @@ sentryTest('Basic isEnabled test with eviction, update, and no async tasks', asy
 
   expect(event.contexts?.flags?.values).toEqual(expectedFlags);
 });
-
-sentryTest('Basic getVariant test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
-  if (shouldSkipFeatureFlagsTest()) {
-    sentryTest.skip();
-  }
-
-  await page.route('https://dsn.ingest.sentry.io/**/*', route => {
-    return route.fulfill({
-      status: 200,
-      contentType: 'application/json',
-      body: JSON.stringify({ id: 'test-id' }),
-    });
-  });
-
-  const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
-  await page.goto(url);
-
-  await page.evaluate(bufferSize => {
-    const client = new (window as any).UnleashClient();
-    for (let i = 1; i <= bufferSize; i++) {
-      client.getVariant(`feat${i}`);
-    }
-    client.getVariant(`feat${bufferSize + 1}`); // eviction
-    client.getVariant('feat3'); // update
-  }, FLAG_BUFFER_SIZE);
-
-  const reqPromise = waitForErrorRequest(page);
-  await page.locator('#error').click();
-  const req = await reqPromise;
-  const event = envelopeRequestParser(req);
-
-  const expectedFlags = [{ flag: 'feat2', result: true }];
-  expectedFlags.push({ flag: 'feat4', result: true });
-  expectedFlags.push({ flag: 'feat5', result: true });
-  for (let i = 6; i <= FLAG_BUFFER_SIZE; i++) {
-    expectedFlags.push({ flag: `feat${i}`, result: false });
-  }
-  expectedFlags.push({ flag: `feat${FLAG_BUFFER_SIZE + 1}`, result: false });
-  expectedFlags.push({ flag: 'feat3', result: true });
-
-  expect(event.contexts?.flags?.values).toEqual(expectedFlags);
-});

packages/browser/src/integrations/featureFlags/unleash/integration.ts

@@ -2,7 +2,7 @@ import type { Client, Event, EventHint, IntegrationFn } from '@sentry/core';
 
 import { defineIntegration } from '@sentry/core';
 import { copyFlagsFromScopeToEvent, insertFlagToScope } from '../../../utils/featureFlags';
-import type { IVariant, UnleashClient, UnleashClientClass } from './types';
+import type { UnleashClient, UnleashClientClass } from './types';
 
 /**
  * Sentry integration for capturing feature flag evaluations from the Unleash SDK.
@@ -54,22 +54,6 @@ export const unleashIntegration = defineIntegration((unleashClientClass: Unleash
       // eslint-disable-next-line @typescript-eslint/unbound-method
       const originalIsEnabled = unleashClientPrototype.isEnabled;
       unleashClientPrototype.isEnabled = new Proxy(originalIsEnabled, sentryIsEnabled);
-
-      const sentryGetVariant = {
-        apply: (
-          target: (this: UnleashClient, toggleName: string) => IVariant,
-          thisArg: UnleashClient,
-          args: [toggleName: string],
-        ) => {
-          const variant = Reflect.apply(target, thisArg, args);
-          const result = variant.feature_enabled || false; // undefined means the feature does not exist.
-          insertFlagToScope(args[0], result);
-          return variant;
-        },
-      };
-      // eslint-disable-next-line @typescript-eslint/unbound-method
-      const originalGetVariant = unleashClientPrototype.getVariant;
-      unleashClientPrototype.getVariant = new Proxy(originalGetVariant, sentryGetVariant);
     },
   };
 }) satisfies IntegrationFn;