Skip to content

Commit 2c092eb

Browse files
committed
adjust integration test
1 parent 5c9e0a0 commit 2c092eb

File tree

2 files changed

+50
-2
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans
  • packages/browser-utils/src/metrics

2 files changed

+50
-2
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/test.ts

Lines changed: 46 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { type Event, SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORI
44
import { sentryTest } from '../../../../utils/fixtures';
55
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
66

7-
sentryTest('should add resource spans to pageload transaction', async ({ getLocalTestUrl, page, browserName }) => {
7+
sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestUrl, page, browserName }) => {
88
if (shouldSkipTracingTest()) {
99
sentryTest.skip();
1010
}
@@ -74,6 +74,21 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
7474
'http.decoded_response_content_length': expect.any(Number),
7575
'http.response_content_length': expect.any(Number),
7676
'http.response_transfer_size': expect.any(Number),
77+
'http.request.connect_end': expect.any(Number),
78+
'http.request.connect_start': expect.any(Number),
79+
'http.request.domain_lookup_end': expect.any(Number),
80+
'http.request.domain_lookup_start': expect.any(Number),
81+
'http.request.fetch_start': expect.any(Number),
82+
'http.request.redirect_end': expect.any(Number),
83+
'http.request.redirect_start': expect.any(Number),
84+
'http.request.request_start': expect.any(Number),
85+
'http.request.secure_connection_start': expect.any(Number),
86+
'http.request.worker_start': expect.any(Number),
87+
'http.response.end': expect.any(Number),
88+
'http.response.final_response_headers_start': expect.any(Number),
89+
'http.response.first_interim_response_start': expect.any(Number),
90+
'http.response.start': expect.any(Number),
91+
'http.response.status_code': expect.any(Number),
7792
'network.protocol.name': '',
7893
'network.protocol.version': 'unknown',
7994
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.img',
@@ -101,6 +116,21 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
101116
'http.decoded_response_content_length': expect.any(Number),
102117
'http.response_content_length': expect.any(Number),
103118
'http.response_transfer_size': expect.any(Number),
119+
'http.request.connect_end': expect.any(Number),
120+
'http.request.connect_start': expect.any(Number),
121+
'http.request.domain_lookup_end': expect.any(Number),
122+
'http.request.domain_lookup_start': expect.any(Number),
123+
'http.request.fetch_start': expect.any(Number),
124+
'http.request.redirect_end': expect.any(Number),
125+
'http.request.redirect_start': expect.any(Number),
126+
'http.request.request_start': expect.any(Number),
127+
'http.request.secure_connection_start': expect.any(Number),
128+
'http.request.worker_start': expect.any(Number),
129+
'http.response.end': expect.any(Number),
130+
'http.response.final_response_headers_start': expect.any(Number),
131+
'http.response.first_interim_response_start': expect.any(Number),
132+
'http.response.start': expect.any(Number),
133+
'http.response.status_code': expect.any(Number),
104134
'network.protocol.name': '',
105135
'network.protocol.version': 'unknown',
106136
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.link',
@@ -128,6 +158,21 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
128158
'http.decoded_response_content_length': expect.any(Number),
129159
'http.response_content_length': expect.any(Number),
130160
'http.response_transfer_size': expect.any(Number),
161+
'http.request.connect_end': expect.any(Number),
162+
'http.request.connect_start': expect.any(Number),
163+
'http.request.domain_lookup_end': expect.any(Number),
164+
'http.request.domain_lookup_start': expect.any(Number),
165+
'http.request.fetch_start': expect.any(Number),
166+
'http.request.redirect_end': expect.any(Number),
167+
'http.request.redirect_start': expect.any(Number),
168+
'http.request.request_start': expect.any(Number),
169+
'http.request.secure_connection_start': expect.any(Number),
170+
'http.request.worker_start': expect.any(Number),
171+
'http.response.end': expect.any(Number),
172+
'http.response.final_response_headers_start': expect.any(Number),
173+
'http.response.first_interim_response_start': expect.any(Number),
174+
'http.response.start': expect.any(Number),
175+
'http.response.status_code': expect.any(Number),
131176
'network.protocol.name': '',
132177
'network.protocol.version': 'unknown',
133178
'sentry.op': 'resource.script',

packages/browser-utils/src/metrics/browserMetrics.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -808,7 +808,10 @@ type ExperimentalResourceTimingProperty =
808808
| 'firstInterimResponseStart'
809809
| 'finalResponseHeadersStart'
810810
| 'renderBlockingStatus'
811-
| 'deliveryType';
811+
| 'deliveryType'
812+
// for some reason, TS during build things this is not a property of PerformanceResourceTiming
813+
// while it actually is. Hence, we're adding it here
814+
| 'responseStatus';
812815

813816
/**
814817
* Use this to set any attributes we can take directly form the PerformanceResourceTiming entry.

0 commit comments

Comments
 (0)