Skip to content

Commit 36dfb93

Browse files
committed
Merge branch 'develop' into timfish/time-side-effects
2 parents e2332c7 + 33b3b23 commit 36dfb93

File tree

70 files changed

+323
-1132
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+323
-1132
lines changed

.github/dependency-review-config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@ allow-ghsas:
77
- GHSA-fr5h-rqp8-mj6g
88
# we need this for an E2E test for the minimum required version of Nuxt 3.7.0
99
- GHSA-v784-fjjh-f8r4
10+
# Next.js Cache poisoning - We require a vulnerable version for E2E testing
11+
- GHSA-gp8f-8m3g-qvj9

.github/workflows/build.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ on:
44
branches:
55
- develop
66
- master
7+
- v9
8+
- v8
79
- release/**
810
pull_request:
911
merge_group:
@@ -105,7 +107,7 @@ jobs:
105107
outputs:
106108
commit_label: '${{ env.COMMIT_SHA }}: ${{ env.COMMIT_MESSAGE }}'
107109
# Note: These next three have to be checked as strings ('true'/'false')!
108-
is_develop: ${{ github.ref == 'refs/heads/develop' }}
110+
is_base_branch: ${{ github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/v9' || github.ref == 'refs/heads/v8'}}
109111
is_release: ${{ startsWith(github.ref, 'refs/heads/release/') }}
110112
changed_profiling_node: ${{ steps.changed.outputs.profiling_node == 'true' }}
111113
changed_ci: ${{ steps.changed.outputs.workflow == 'true' }}
@@ -126,7 +128,7 @@ jobs:
126128
timeout-minutes: 15
127129
if: |
128130
needs.job_get_metadata.outputs.changed_any_code == 'true' ||
129-
needs.job_get_metadata.outputs.is_develop == 'true' ||
131+
needs.job_get_metadata.outputs.is_base_branch == 'true' ||
130132
needs.job_get_metadata.outputs.is_release == 'true' ||
131133
(needs.job_get_metadata.outputs.is_gitflow_sync == 'false' && needs.job_get_metadata.outputs.has_gitflow_label == 'false')
132134
steps:
@@ -171,7 +173,7 @@ jobs:
171173
key: nx-Linux-${{ github.ref }}-${{ env.HEAD_COMMIT || github.sha }}
172174
# On develop branch, we want to _store_ the cache (so it can be used by other branches), but never _restore_ from it
173175
restore-keys:
174-
${{needs.job_get_metadata.outputs.is_develop == 'false' && env.NX_CACHE_RESTORE_KEYS || 'nx-never-restore'}}
176+
${{needs.job_get_metadata.outputs.is_base_branch == 'false' && env.NX_CACHE_RESTORE_KEYS || 'nx-never-restore'}}
175177

176178
- name: Build packages
177179
# Set the CODECOV_TOKEN for Bundle Analysis
@@ -219,7 +221,7 @@ jobs:
219221
timeout-minutes: 15
220222
runs-on: ubuntu-20.04
221223
if:
222-
github.event_name == 'pull_request' || needs.job_get_metadata.outputs.is_develop == 'true' ||
224+
github.event_name == 'pull_request' || needs.job_get_metadata.outputs.is_base_branch == 'true' ||
223225
needs.job_get_metadata.outputs.is_release == 'true'
224226
steps:
225227
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})

.github/workflows/enforce-license-compliance.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,18 @@ name: "CI: Enforce License Compliance"
22

33
on:
44
push:
5-
branches: [master, develop, release/*]
5+
branches:
6+
- develop
7+
- master
8+
- v9
9+
- v8
10+
- release/**
611
pull_request:
7-
branches: [master, develop]
12+
branches:
13+
- develop
14+
- master
15+
- v9
16+
- v8
817

918
jobs:
1019
enforce-license-compliance:

MIGRATION.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ These docs walk through how to migrate our JavaScript SDKs through different maj
55
- Upgrading from [SDK 4.x to 5.x/6.x](./docs/migration/v4-to-v5_v6.md)
66
- Upgrading from [SDK 6.x to 7.x](./docs/migration/v6-to-v7.md)
77
- Upgrading from [SDK 7.x to 8.x](./MIGRATION.md#upgrading-from-7x-to-8x)
8+
- Upgrading from [SDK 8.x to 9.x](./docs/migration/v8-to-v9.md) (Work in Progress - v9 is not released yet)
89

910
# Upgrading from 7.x to 8.x
1011

dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
"@trpc/react-query": "^11.0.0-rc.446",
2222
"@trpc/server": "^11.0.0-rc.446",
2323
"geist": "^1.3.0",
24-
"next": "^14.2.4",
25-
"react": "^18.3.1",
26-
"react-dom": "^18.3.1",
24+
"next": "14.2.4",
25+
"react": "18.3.1",
26+
"react-dom": "18.3.1",
2727
"server-only": "^0.0.1",
2828
"superjson": "^2.2.1",
2929
"zod": "^3.23.3"

dev-packages/e2e-tests/test-applications/nextjs-t3/src/trpc/server.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import 'server-only';
22

33
import { createHydrationHelpers } from '@trpc/react-query/rsc';
44
import { headers } from 'next/headers';
5-
import { cache } from 'react';
65

76
import { type AppRouter, createCaller } from '~/server/api/root';
87
import { createTRPCContext } from '~/server/api/trpc';
@@ -12,16 +11,16 @@ import { createQueryClient } from './query-client';
1211
* This wraps the `createTRPCContext` helper and provides the required context for the tRPC API when
1312
* handling a tRPC call from a React Server Component.
1413
*/
15-
const createContext = cache(() => {
14+
const createContext = () => {
1615
const heads = new Headers(headers());
1716
heads.set('x-trpc-source', 'rsc');
1817

1918
return createTRPCContext({
2019
headers: heads,
2120
});
22-
});
21+
};
2322

24-
const getQueryClient = cache(createQueryClient);
23+
const getQueryClient = createQueryClient;
2524
const caller = createCaller(createContext);
2625

2726
export const { trpc: api, HydrateClient } = createHydrationHelpers<AppRouter>(caller, getQueryClient);

dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ const DEPENDENTS: Dependent[] = [
5050
ignoreExports: [
5151
// not supported in bun:
5252
'NodeClient',
53-
// Bun doesn't emit the required diagnostics_channel events
54-
'processThreadBreadcrumbIntegration',
5553
'childProcessIntegration',
5654
],
5755
},

dev-packages/e2e-tests/test-applications/node-otel-custom-sampler/src/instrument.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Sentry.init({
1414
skipOpenTelemetrySetup: true,
1515
// By defining _any_ sample rate, tracing integrations will be added by default
1616
tracesSampleRate: 0,
17+
integrations: [Sentry.httpIntegration({ spans: true })],
1718
});
1819

1920
const provider = new NodeTracerProvider({

dev-packages/e2e-tests/test-applications/node-otel-sdk-node/src/instrument.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const sentryClient = Sentry.init({
1414
tracesSampleRate: 1,
1515

1616
skipOpenTelemetrySetup: true,
17+
integrations: [Sentry.httpIntegration({ spans: true })],
1718
});
1819

1920
const sdk = new opentelemetry.NodeSDK({

dev-packages/e2e-tests/test-applications/node-otel-without-tracing/src/instrument.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ Sentry.init({
1515
debug: !!process.env.DEBUG,
1616
tunnel: `http://localhost:3031/`, // proxy server
1717
// Tracing is completely disabled
18-
19-
integrations: [Sentry.httpIntegration({ spans: false })],
20-
2118
// Custom OTEL setup
2219
skipOpenTelemetrySetup: true,
2320
});

0 commit comments

Comments
 (0)