update unit tests for sentryTanstackStart

Author: nicohrubec

packages/tanstackstart-react/src/vite/autoInstrumentMiddleware.ts

@@ -73,7 +73,7 @@ export function makeAutoInstrumentMiddlewarePlugin(options: AutoInstrumentMiddle
  * Returns null if contents contain non-identifier expressions (function calls, etc.)
  * which cannot be converted to object shorthand.
  */
-function arrayToObjectShorthand(contents: string): string | null {
+export function arrayToObjectShorthand(contents: string): string | null {
   const items = contents
     .split(',')
     .map(s => s.trim())

packages/tanstackstart-react/test/vite/sentryTanstackStart.test.ts

@@ -36,59 +36,73 @@ describe('sentryTanstackStart()', () => {
     process.env.NODE_ENV = 'production';
   });
 
-  it('returns plugins in production mode', () => {
-    const plugins = sentryTanstackStart({ org: 'test-org' });
+  describe('middleware auto-instrumentation', () => {
+    it('adds middleware plugin by default', () => {
+      process.env.NODE_ENV = 'development';
+      const plugins = sentryTanstackStart({});
 
-    expect(plugins.length).toBeGreaterThan(0);
-  });
+      expect(plugins).toHaveLength(1);
+      expect(plugins.find(p => p.name === 'sentry-tanstack-middleware-auto-instrument')).toBeDefined();
+    });
 
-  it('returns no plugins in development mode', () => {
-    process.env.NODE_ENV = 'development';
+    it('adds middleware plugin when autoInstrumentMiddleware is true', () => {
+      process.env.NODE_ENV = 'development';
+      const plugins = sentryTanstackStart({ autoInstrumentMiddleware: true });
 
-    const plugins = sentryTanstackStart({ org: 'test-org' });
+      expect(plugins).toHaveLength(1);
+      expect(plugins.find(p => p.name === 'sentry-tanstack-middleware-auto-instrument')).toBeDefined();
+    });
 
-    expect(plugins).toHaveLength(0);
-  });
+    it('does not add middleware plugin when autoInstrumentMiddleware is false', () => {
+      process.env.NODE_ENV = 'development';
+      const plugins = sentryTanstackStart({ autoInstrumentMiddleware: false });
 
-  it('returns Sentry Vite plugins but not enable source maps plugin when sourcemaps.disable is true', () => {
-    const plugins = sentryTanstackStart({
-      sourcemaps: { disable: true },
+      expect(plugins).toHaveLength(0);
     });
-
-    expect(plugins).toHaveLength(2);
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeUndefined();
   });
 
-  it('returns Sentry Vite plugins but not enable source maps plugin when sourcemaps.disable is "disable-upload"', () => {
-    const plugins = sentryTanstackStart({
-      sourcemaps: { disable: 'disable-upload' },
+  describe('source maps', () => {
+    it('returns Sentry Vite plugins but not enable source maps plugin when sourcemaps.disable is true', () => {
+      const plugins = sentryTanstackStart({
+        autoInstrumentMiddleware: false,
+        sourcemaps: { disable: true },
+      });
+
+      expect(plugins).toHaveLength(2);
+      expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
+      expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
+      expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeUndefined();
     });
 
-    expect(plugins).toHaveLength(2);
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeUndefined();
-  });
+    it('returns Sentry Vite plugins but not enable source maps plugin when sourcemaps.disable is "disable-upload"', () => {
+      const plugins = sentryTanstackStart({
+        autoInstrumentMiddleware: false,
+        sourcemaps: { disable: 'disable-upload' },
+      });
 
-  it('returns Sentry Vite plugins and enable source maps plugin when sourcemaps.disable is false', () => {
-    const plugins = sentryTanstackStart({
-      sourcemaps: { disable: false },
+      expect(plugins).toHaveLength(2);
+      expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
+      expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
+      expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeUndefined();
     });
 
-    expect(plugins).toHaveLength(3);
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeDefined();
-  });
+    it('returns Sentry Vite plugins and enable source maps plugin when sourcemaps.disable is false', () => {
+      const plugins = sentryTanstackStart({
+        autoInstrumentMiddleware: false,
+        sourcemaps: { disable: false },
+      });
 
-  it('returns Sentry Vite Plugins and enable source maps plugin by default when sourcemaps is not specified', () => {
-    const plugins = sentryTanstackStart({});
+      expect(plugins).toHaveLength(3);
+      expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
+      expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
+      expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeDefined();
+    });
 
-    expect(plugins).toHaveLength(3);
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-source-maps-config')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-vite-debug-id-upload-plugin')).toBeDefined();
-    expect(plugins.find(p => p.name === 'sentry-tanstackstart-react-source-maps')).toBeDefined();
+    it('returns no source maps plugins in development mode', () => {
+      process.env.NODE_ENV = 'development';
+      const plugins = sentryTanstackStart({ autoInstrumentMiddleware: false });
+
+      expect(plugins).toHaveLength(0);
+    });
   });
 });