Skip to content

Commit 3e137ac

Browse files
committed
set mcp transport and network transport to unknown if transport name is unknown
1 parent 9fcece1 commit 3e137ac

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed

packages/core/src/integrations/mcp-server/attributeExtraction.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ export function getTransportTypes(transport: MCPTransport): { mcpTransport: stri
4949
return { mcpTransport: 'unknown', networkTransport: 'unknown' };
5050
}
5151
const transportName = transport.constructor.name?.toLowerCase() || 'unknown';
52+
53+
if (transportName === 'unknown') {
54+
return { mcpTransport: 'unknown', networkTransport: 'unknown' };
55+
}
56+
5257
const networkTransport = transportName.includes('stdio') ? 'pipe' : 'tcp';
5358

5459
return {

packages/core/test/lib/integrations/mcp-server/transportInstrumentation.test.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,6 +535,30 @@ describe('MCP Server Transport Instrumentation', () => {
535535
expect(result.mcpTransport).toBe('unknown');
536536
expect(result.networkTransport).toBe('unknown');
537537
});
538+
539+
it('handles transport with null/undefined constructor name', () => {
540+
const transport = {
541+
constructor: { name: null },
542+
onmessage: () => {},
543+
send: async () => {},
544+
};
545+
const result = getTransportTypes(transport);
546+
547+
expect(result.mcpTransport).toBe('unknown');
548+
expect(result.networkTransport).toBe('unknown');
549+
});
550+
551+
it('handles transport with empty constructor name', () => {
552+
const transport = {
553+
constructor: { name: '' },
554+
onmessage: () => {},
555+
send: async () => {},
556+
};
557+
const result = getTransportTypes(transport);
558+
559+
expect(result.mcpTransport).toBe('unknown');
560+
expect(result.networkTransport).toBe('unknown');
561+
});
538562
});
539563

540564
describe('buildTransportAttributes sessionId handling', () => {

0 commit comments

Comments
 (0)