PR feedback

Author: mydea

dev-packages/node-overhead-gh-action/lib/getOverheadMeasurements.mjs

@@ -120,8 +120,8 @@ async function startAutocannonProcess(autocannonCommand) {
 export async function getOverheadMeasurements() {
   const GET = {
     baseline: await getMeasurements(undefined, 'yarn test:get'),
-    withInstrument: await getMeasurements('./src/instrument.mjs', 'yarn test:post'),
-    withInstrumentErrorOnly: await getMeasurements('./src/instrument-error-only.mjs', 'yarn test:post'),
+    withInstrument: await getMeasurements('./src/instrument.mjs', 'yarn test:get'),
+    withInstrumentErrorOnly: await getMeasurements('./src/instrument-error-only.mjs', 'yarn test:get'),
   };
 
   const POST = {

dev-packages/node-overhead-gh-action/lib/markdown-table-formatter.mjs

@@ -51,7 +51,7 @@ export function hasChanges(baseScenarios, currentScenarios, threshold = 0) {
         return true;
       }
 
-      return Math.abs((currentResult.size - baseResult.size) / baseResult.size) * 100 > threshold;
+      return Math.abs((currentResult - baseResult) / baseResult) * 100 > threshold;
     });
   });
 }