feat: enable biome recommended linter rules

Author: anonrig

.size-limit.js

@@ -20,7 +20,7 @@ module.exports = [
     import: '{ init, Replay, BrowserTracing }',
     gzip: true,
     limit: '75 KB',
-    modifyWebpackConfig: function (config) {
+    modifyWebpackConfig: config => {
       const webpack = require('webpack');
       config.plugins.push(
         new webpack.DefinePlugin({

biome.json

@@ -11,18 +11,26 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": false,
-      "correctness": {
-        "all": false,
-        "noUnusedVariables": "error",
-        "noPrecisionLoss": "error"
+      "recommended": true,
+      "complexity": {
+        "noForEach": "off",
+        "useOptionalChain": "off"
+      },
+      "security": {
+        "all": true
+      },
+      "style": {
+        "noArguments": "off",
+        "noNonNullAssertion": "off",
+        "noUselessElse": "off",
+        "useTemplate": "off"
       },
       "suspicious": {
-        "all": false,
-        "noControlCharactersInRegex": "error"
+        "noDebugger": "off",
+        "noExplicitAny": "off"
       }
     },
-    "ignore": [".vscode/*", "**/*.json"]
+    "ignore": [".vscode/*", "**/*.json", "**/*.min.js", "packages/browser-integration-tests/fixtures/loader.js"]
   },
   "files": {
     "ignoreUnknown": true
@@ -44,6 +52,7 @@
     ]
   },
   "javascript": {
+    "globals": ["expect", "describe", "test", "it", "beforeEach", "afterEach", "beforeAll", "afterAll"],
     "formatter": {
       "enabled": true,
       "quoteStyle": "single",

packages/angular-ivy/scripts/prepack.ts

@@ -15,12 +15,12 @@ const pkgJson: PackageJson = JSON.parse(fs.readFileSync(pkjJsonPath).toString())
 // This is necessary for Angular 17+ compatibility when SSR is configured which switches dev mode to using Vite.
 // Deleting "main" and adding "type": "module" will direct Vite to
 // use the fesm2015 bundle instead of the UMD bundle.
-delete pkgJson.main;
+pkgJson.main = undefined;
 pkgJson.type = 'module';
 
 // no need to keep around other properties that are only relevant for our reop:
-delete pkgJson.nx;
-delete pkgJson.volta;
+pkgJson.nx = undefined;
+pkgJson.volta = undefined;
 
 fs.writeFileSync(pkjJsonPath, JSON.stringify(pkgJson, null, 2));
 

packages/angular/src/tracing.ts

@@ -27,8 +27,8 @@ let stashedStartTransactionOnLocationChange: boolean;
  */
 export function routingInstrumentation(
   customStartTransaction: (context: TransactionContext) => Transaction | undefined,
-  startTransactionOnPageLoad: boolean = true,
-  startTransactionOnLocationChange: boolean = true,
+  startTransactionOnPageLoad = true,
+  startTransactionOnLocationChange = true,
 ): void {
   instrumentationInitialized = true;
   stashedStartTransaction = customStartTransaction;

packages/astro/test/client/sdk.test.ts

@@ -96,7 +96,7 @@ describe('Sentry client SDK', () => {
         expect(integrationsToInit).not.toContainEqual(expect.objectContaining({ name: 'BrowserTracing' }));
         expect(browserTracing).toBeUndefined();
 
-        delete globalThis.__SENTRY_TRACING__;
+        globalThis.__SENTRY_TRACING__ = undefined;
       });
 
       it('Overrides the automatically default BrowserTracing instance with a a user-provided instance', () => {

packages/browser-integration-tests/loader-suites/loader/noOnLoad/unhandeledPromiseRejectionHandler/subject.js

@@ -1,3 +1,3 @@
-new Promise(function (resolve, reject) {
+new Promise((resolve, reject) => {
   reject('this is unhandled');
 });

packages/browser-integration-tests/loader-suites/loader/onLoad/captureExceptionInOnLoad/init.js

@@ -1,4 +1,4 @@
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   // You _have_ to call Sentry.init() before calling Sentry.captureException() in Sentry.onLoad()!
   Sentry.init();
   Sentry.captureException('Test exception');

packages/browser-integration-tests/loader-suites/loader/onLoad/customBrowserTracing/init.js

@@ -1,10 +1,10 @@
 window._testBaseTimestamp = performance.timeOrigin / 1000;
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [
       // Without this syntax, this will be re-written by the test framework
-      new window['Sentry'].BrowserTracing({
+      new window.Sentry.BrowserTracing({
         tracePropagationTargets: ['http://localhost:1234'],
       }),
     ],

packages/browser-integration-tests/loader-suites/loader/onLoad/customInit/init.js

@@ -1,7 +1,7 @@
 window.__sentryOnLoad = 0;
 
 setTimeout(() => {
-  Sentry.onLoad(function () {
+  Sentry.onLoad(() => {
     window.__hadSentry = window.sentryIsLoaded();
 
     Sentry.init({

packages/browser-integration-tests/loader-suites/loader/onLoad/customIntegrations/init.js

@@ -6,7 +6,7 @@ class CustomIntegration {
   setupOnce() {}
 }
 
-Sentry.onLoad(function () {
+Sentry.onLoad(() => {
   Sentry.init({
     integrations: [new CustomIntegration()],
   });