Skip to content

Commit 3e9847b

Browse files
committed
chore: use playwright image for e2e test
1 parent 7496387 commit 3e9847b

File tree

110 files changed

+116
-147
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+116
-147
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,7 @@ jobs:
558558
needs: [job_get_metadata, job_build]
559559
if: needs.job_build.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
560560
runs-on: ubuntu-24.04-large-js
561+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
561562
timeout-minutes: 25
562563
strategy:
563564
fail-fast: false
@@ -615,11 +616,6 @@ jobs:
615616
with:
616617
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
617618

618-
- name: Install Playwright
619-
uses: ./.github/actions/install-playwright
620-
with:
621-
browsers: ${{ matrix.project }}
622-
623619
- name: Run Playwright tests
624620
env:
625621
PW_BUNDLE: ${{ matrix.bundle }}
@@ -652,6 +648,7 @@ jobs:
652648
needs: [job_get_metadata, job_build]
653649
if: needs.job_build.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request'
654650
runs-on: ubuntu-24.04
651+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
655652
timeout-minutes: 15
656653
strategy:
657654
fail-fast: false
@@ -679,11 +676,6 @@ jobs:
679676
with:
680677
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
681678

682-
- name: Install Playwright
683-
uses: ./.github/actions/install-playwright
684-
with:
685-
browsers: chromium
686-
687679
- name: Run Playwright Loader tests
688680
env:
689681
PW_BUNDLE: ${{ matrix.bundle }}
@@ -810,6 +802,7 @@ jobs:
810802
needs: [job_get_metadata, job_build]
811803
if: needs.job_build.outputs.changed_remix == 'true' || github.event_name != 'pull_request'
812804
runs-on: ubuntu-24.04
805+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
813806
timeout-minutes: 10
814807
strategy:
815808
fail-fast: false
@@ -829,11 +822,6 @@ jobs:
829822
with:
830823
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
831824

832-
- name: Install Playwright
833-
uses: ./.github/actions/install-playwright
834-
with:
835-
browsers: chromium
836-
837825
- name: Run integration tests
838826
env:
839827
NODE_VERSION: ${{ matrix.node }}
@@ -919,6 +907,7 @@ jobs:
919907
always() && needs.job_e2e_prepare.result == 'success' && needs.job_e2e_prepare.outputs.matrix != '{"include":[]}'
920908
needs: [job_get_metadata, job_build, job_e2e_prepare]
921909
runs-on: ubuntu-24.04
910+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
922911
timeout-minutes: 15
923912
env:
924913
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -993,12 +982,6 @@ jobs:
993982
timeout-minutes: 7
994983
run: ${{ matrix.build-command || 'pnpm test:build' }}
995984

996-
- name: Install Playwright
997-
uses: ./.github/actions/install-playwright
998-
with:
999-
browsers: chromium
1000-
cwd: ${{ runner.temp }}/test-application
1001-
1002985
- name: Run E2E test
1003986
working-directory: ${{ runner.temp }}/test-application
1004987
timeout-minutes: 10
@@ -1048,6 +1031,7 @@ jobs:
10481031
github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]'
10491032
needs: [job_get_metadata, job_build, job_e2e_prepare]
10501033
runs-on: ubuntu-24.04
1034+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
10511035
timeout-minutes: 15
10521036
env:
10531037
E2E_TEST_AUTH_TOKEN: ${{ secrets.E2E_TEST_AUTH_TOKEN }}
@@ -1114,12 +1098,6 @@ jobs:
11141098
timeout-minutes: 7
11151099
run: ${{ matrix.build-command || 'pnpm test:build' }}
11161100

1117-
- name: Install Playwright
1118-
uses: ./.github/actions/install-playwright
1119-
with:
1120-
browsers: chromium
1121-
cwd: ${{ runner.temp }}/test-application
1122-
11231101
- name: Run E2E test
11241102
working-directory: ${{ runner.temp }}/test-application
11251103
timeout-minutes: 10

.github/workflows/canary.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ jobs:
5454
job_e2e_tests:
5555
name: E2E ${{ matrix.label }} Test
5656
needs: [job_e2e_prepare]
57-
runs-on: ubuntu-24.04
57+
runs-on: ubuntu-24.04-large-js
58+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
5859
timeout-minutes: 20
5960
env:
6061
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -159,12 +160,6 @@ jobs:
159160
timeout-minutes: 7
160161
run: yarn ${{ matrix.build-command }}
161162

162-
- name: Install Playwright
163-
uses: ./.github/actions/install-playwright
164-
with:
165-
browsers: chromium
166-
cwd: ${{ runner.temp }}/test-application
167-
168163
- name: Run E2E test
169164
working-directory: ${{ runner.temp }}/test-application
170165
timeout-minutes: 15

.github/workflows/flaky-test-detector.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ concurrency:
2424
jobs:
2525
flaky-detector:
2626
runs-on: ubuntu-24.04
27+
container: mcr.microsoft.com/playwright:v1.53.2-jammy
2728
timeout-minutes: 60
2829
name: 'Check tests for flakiness'
2930
# Also skip if PR is from master -> develop
@@ -49,11 +50,6 @@ jobs:
4950
- name: Build packages
5051
run: yarn build
5152

52-
- name: Install Playwright
53-
uses: ./.github/actions/install-playwright
54-
with:
55-
browsers: 'chromium'
56-
5753
- name: Determine changed tests
5854
uses: dorny/[email protected]
5955
id: changed

dev-packages/browser-integration-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"dependencies": {
4242
"@babel/core": "^7.27.7",
4343
"@babel/preset-typescript": "^7.16.7",
44-
"@playwright/test": "~1.53.2",
44+
"@playwright/test": "1.53.2",
4545
"@sentry-internal/rrweb": "2.34.0",
4646
"@sentry/browser": "10.22.0",
4747
"@supabase/supabase-js": "2.49.3",

dev-packages/e2e-tests/test-applications/angular-17/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"zone.js": "~0.14.3"
3030
},
3131
"devDependencies": {
32-
"@playwright/test": "~1.53.2",
32+
"@playwright/test": "1.53.2",
3333
"@sentry-internal/test-utils": "link:../../../test-utils",
3434
"@sentry/core": "latest || *",
3535
"@angular-devkit/build-angular": "^17.1.1",

dev-packages/e2e-tests/test-applications/angular-18/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"zone.js": "~0.14.3"
3030
},
3131
"devDependencies": {
32-
"@playwright/test": "~1.53.2",
32+
"@playwright/test": "1.53.2",
3333
"@sentry-internal/test-utils": "link:../../../test-utils",
3434
"@sentry/core": "latest || *",
3535
"@angular-devkit/build-angular": "^18.0.0",

dev-packages/e2e-tests/test-applications/angular-19/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"@angular-devkit/build-angular": "^19.0.0",
3333
"@angular/cli": "^19.0.0",
3434
"@angular/compiler-cli": "^19.0.0",
35-
"@playwright/test": "~1.53.2",
35+
"@playwright/test": "1.53.2",
3636
"@sentry-internal/test-utils": "link:../../../test-utils",
3737
"@sentry/core": "latest || *",
3838
"@types/jasmine": "~5.1.0",

dev-packages/e2e-tests/test-applications/angular-20/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"@angular-devkit/build-angular": "^20.0.0",
3434
"@angular/cli": "^20.0.0",
3535
"@angular/compiler-cli": "^20.0.0",
36-
"@playwright/test": "~1.53.2",
36+
"@playwright/test": "1.53.2",
3737
"@sentry-internal/test-utils": "link:../../../test-utils",
3838
"@sentry/core": "latest || *",
3939
"@types/jasmine": "~5.1.0",

dev-packages/e2e-tests/test-applications/astro-4/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"dependencies": {
1515
"@astrojs/check": "0.9.2",
1616
"@astrojs/node": "8.3.4",
17-
"@playwright/test": "~1.53.2",
17+
"@playwright/test": "1.53.2",
1818
"@sentry/astro": "* || latest",
1919
"@sentry-internal/test-utils": "link:../../../test-utils",
2020
"@spotlightjs/astro": "2.1.6",

dev-packages/e2e-tests/test-applications/astro-5/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"dependencies": {
1515
"@astrojs/internal-helpers": "^0.4.2",
1616
"@astrojs/node": "^9.0.0",
17-
"@playwright/test": "~1.53.2",
17+
"@playwright/test": "1.53.2",
1818
"@sentry-internal/test-utils": "link:../../../test-utils",
1919
"@sentry/astro": "latest || *",
2020
"astro": "^5.0.3"

0 commit comments

Comments
 (0)