ref: Avoid try-catch with unused parameter

Instead, we can just use the parameter-less version of try-catch.
In future versions of eslint, this will be disallowed, so extracting this out.

Author: mydea

dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

@@ -131,7 +131,7 @@ function getApproximateNumberOfTests(testPath: string): number {
     const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
     const matches = content.match(/sentryTest\(/g);
     return Math.max(matches ? matches.length : 1, 1);
-  } catch (e) {
+  } catch {
     console.error(`Could not read file ${testPath}`);
     return 1;
   }

dev-packages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadata/init.js

@@ -14,7 +14,7 @@ Sentry.init({
             moduleMetadataEntries.push(frame.module_metadata);
           });
         });
-      } catch (e) {
+      } catch {
         // noop
       }
     }

dev-packages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadataWithRewriteFrames/init.js

@@ -28,7 +28,7 @@ Sentry.init({
             moduleMetadataEntries.push(frame.module_metadata);
           });
         });
-      } catch (e) {
+      } catch {
         // noop
       }
     }

dev-packages/browser-integration-tests/utils/helpers.ts

@@ -23,7 +23,7 @@ export const envelopeParser = (request: Request | null): unknown[] => {
   return envelope.split('\n').map(line => {
     try {
       return JSON.parse(line);
-    } catch (error) {
+    } catch {
       return line;
     }
   });
@@ -172,7 +172,7 @@ export async function runScriptInSandbox(
 ): Promise<void> {
   try {
     await page.addScriptTag({ path: impl.path, content: impl.content });
-  } catch (e) {
+  } catch {
     // no-op
   }
 }

dev-packages/e2e-tests/test-applications/ember-classic/app/controllers/index.ts

@@ -22,7 +22,7 @@ export default class IndexController extends Controller {
   public createCaughtEmberError(): void {
     try {
       throw new Error('Looks like you have a caught EmberError');
-    } catch (e) {
+    } catch {
       // do nothing
     }
   }

packages/browser/src/eventbuilder.ts

@@ -120,7 +120,7 @@ function parseStackFrames(
 
   try {
     return stackParser(stacktrace, skipLines, framesToPop);
-  } catch (e) {
+  } catch {
     // no-empty
   }
 
@@ -392,7 +392,7 @@ function getObjectClassName(obj: unknown): string | undefined | void {
   try {
     const prototype: Prototype | null = Object.getPrototypeOf(obj);
     return prototype ? prototype.constructor.name : undefined;
-  } catch (e) {
+  } catch {
     // ignore errors here
   }
 }

packages/browser/src/tracing/request.ts

@@ -277,7 +277,7 @@ export function shouldAttachHeaders(
     try {
       resolvedUrl = new URL(targetUrl, href);
       currentOrigin = new URL(href).origin;
-    } catch (e) {
+    } catch {
       return false;
     }
 
@@ -413,7 +413,7 @@ function setHeaderOnXhr(
         xhr.setRequestHeader!('baggage', sentryBaggageHeader);
       }
     }
-  } catch (_) {
+  } catch {
     // Error: InvalidStateError: Failed to execute 'setRequestHeader' on 'XMLHttpRequest': The object's state must be OPENED.
   }
 }

packages/browser/src/transports/offline.ts

@@ -129,15 +129,15 @@ function createIndexedDbStore(options: BrowserOfflineTransportOptions): OfflineS
       try {
         const serialized = await serializeEnvelope(env);
         await push(getStore(), serialized, options.maxQueueSize || 30);
-      } catch (_) {
+      } catch {
         //
       }
     },
     unshift: async (env: Envelope) => {
       try {
         const serialized = await serializeEnvelope(env);
         await unshift(getStore(), serialized, options.maxQueueSize || 30);
-      } catch (_) {
+      } catch {
         //
       }
     },
@@ -147,7 +147,7 @@ function createIndexedDbStore(options: BrowserOfflineTransportOptions): OfflineS
         if (deserialized) {
           return parseEnvelope(deserialized);
         }
-      } catch (_) {
+      } catch {
         //
       }
 

packages/cloudflare/src/handler.ts

@@ -233,7 +233,7 @@ export function withSentry<Env = unknown, QueueHandlerMessage = unknown, CfHostM
     }
 
     // This is here because Miniflare sometimes cannot get instrumented
-  } catch (e) {
+  } catch {
     // Do not console anything here, we don't want to spam the console with errors
   }
 

packages/core/src/instrument/fetch.ts

@@ -172,7 +172,7 @@ async function resolveResponse(res: Response | undefined, onFinishedResolving: (
           onFinishedResolving();
           readingActive = false;
         }
-      } catch (error) {
+      } catch {
         readingActive = false;
       } finally {
         clearTimeout(chunkTimeout);