Skip to content

Commit 3f71195

Browse files
author
Luca Forstner
committed
braincells--
1 parent 52dd39f commit 3f71195

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

dev-packages/e2e-tests/test-applications/nextjs-app-dir/next-env.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
/// <reference types="next/navigation-types/compat/navigation" />
44

55
// NOTE: This file should not be edited
6-
// see https://nextjs.org/docs/basic-features/typescript for more information.
6+
// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.

dev-packages/e2e-tests/test-applications/nextjs-app-dir/pages/api/async-context-edge-endpoint.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,18 @@ export default async function handler() {
1111
return new Promise<void>(resolve => setTimeout(resolve, 300));
1212
});
1313

14-
setTimeout(() => {
15-
return Sentry.startSpan({ name: 'inner-span' }, () => {
16-
return new Promise<void>(resolve => setTimeout(resolve, 100));
17-
});
18-
}, 100);
14+
const innerSpanPromise = new Promise<void>(resolve => {
15+
setTimeout(() => {
16+
Sentry.startSpan({ name: 'inner-span' }, () => {
17+
return new Promise<void>(resolve => setTimeout(resolve, 100));
18+
}).then(() => {
19+
resolve();
20+
});
21+
}, 100);
22+
});
1923

2024
await outerSpanPromise;
25+
await innerSpanPromise;
2126

2227
return new Response('ok', { status: 200 });
2328
}

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/async-context-edge.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,5 @@ test('Should allow for async context isolation in the edge SDK', async ({ reques
1616
const outerSpan = asyncContextEdgerouteTransaction.spans?.find(span => span.description === 'outer-span');
1717
const innerSpan = asyncContextEdgerouteTransaction.spans?.find(span => span.description === 'inner-span');
1818

19-
expect(outerSpan?.parent_span_id).toStrictEqual(asyncContextEdgerouteTransaction.contexts?.trace?.span_id);
20-
expect(innerSpan?.parent_span_id).toStrictEqual(asyncContextEdgerouteTransaction.contexts?.trace?.span_id);
19+
expect(outerSpan?.parent_span_id).toStrictEqual(innerSpan?.parent_span_id);
2120
});

0 commit comments

Comments
 (0)