Skip to content

Commit 3f9ccf0

Browse files
authored
ci: Only store E2E Test Dumps for failed tests (#17138)
Noticed here: https://github.com/getsentry/sentry-javascript/actions/runs/16490747881?pr=17132 that we always store the dumps as artifacts, IMHO we only need this when the test fails.
1 parent 27e60b7 commit 3f9ccf0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -950,13 +950,13 @@ jobs:
950950
retention-days: 7
951951

952952
- name: Pre-process E2E Test Dumps
953-
if: always()
953+
if: failure()
954954
run: |
955955
node ./scripts/normalize-e2e-test-dump-transaction-events.js
956956
957957
- name: Upload E2E Test Event Dumps
958958
uses: actions/upload-artifact@v4
959-
if: always()
959+
if: failure()
960960
with:
961961
name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
962962
path: ${{ runner.temp }}/test-application/event-dumps
@@ -1062,13 +1062,13 @@ jobs:
10621062
run: pnpm ${{ matrix.assert-command || 'test:assert' }}
10631063

10641064
- name: Pre-process E2E Test Dumps
1065-
if: always()
1065+
if: failure()
10661066
run: |
10671067
node ./scripts/normalize-e2e-test-dump-transaction-events.js
10681068
10691069
- name: Upload E2E Test Event Dumps
10701070
uses: actions/upload-artifact@v4
1071-
if: always()
1071+
if: failure()
10721072
with:
10731073
name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
10741074
path: ${{ runner.temp }}/test-application/event-dumps

0 commit comments

Comments
 (0)