Skip to content

Commit 48fce4d

Browse files
authored
feat: Add danger (#1574)
* feat: Add danger * feat: Add travis danger job * meta: Add sizecheck to danger * ref: Delete dead code
1 parent 9c131a0 commit 48fce4d

File tree

6 files changed

+309
-8
lines changed

6 files changed

+309
-8
lines changed

.travis.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ cache:
1515

1616
matrix:
1717
include:
18+
- name: '@sentry/packages - danger'
19+
node_js: '8'
20+
script: .travis/danger.sh
1821
- name: '@sentry/packages - lint'
1922
node_js: '8'
2023
script: .travis/lint.sh

.travis/danger.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
#!/bin/bash
2+
set -e
3+
4+
yarn
5+
# We have to build it first, so that TypeScript Types are recognized correctly
6+
yarn build
7+
yarn danger ci

.travis/lint.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@ yarn
55
# We have to build it first, so that TypeScript Types are recognized correctly
66
yarn build
77
yarn lint
8-

dangerfile.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { exec } from 'child_process';
2+
import { danger, message, schedule, warn } from 'danger';
3+
import { promisify } from 'util';
4+
5+
export default async () => {
6+
if (!danger.github) {
7+
return;
8+
}
9+
10+
const hasChangelog = danger.git.modified_files.indexOf('CHANGELOG.md') !== -1;
11+
const isTrivial = (danger.github.pr.body + danger.github.pr.title).includes('#trivial');
12+
13+
if (!hasChangelog && !isTrivial) {
14+
warn('Please add a changelog entry for your changes.');
15+
}
16+
17+
schedule(async () => {
18+
const result = (await promisify(exec)('cd packages/browser; yarn size:check')).stdout;
19+
message(`@sentry/browser gzip minified size: ${result.split('\n')[1]}`);
20+
});
21+
};

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"@types/sinon": "^4.3.1",
3030
"chai": "^4.1.2",
3131
"codecov": "^3.0.2",
32+
"danger": "^4.0.2",
3233
"jest": "^22.4.3",
3334
"karma-sinon": "^1.0.5",
3435
"lerna": "3.4.0",

0 commit comments

Comments
 (0)