Skip to content

Commit 512f43c

Browse files
authored
chore(CI): Remove Biome in favour of prettier (#15461)
1 parent 6e9682a commit 512f43c

File tree

28 files changed

+65
-280
lines changed

28 files changed

+65
-280
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,6 @@ jobs:
263263
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
264264
- name: Lint source files
265265
run: yarn lint:lerna
266-
- name: Lint C++ files
267-
run: yarn lint:clang
268266
- name: Lint for ES compatibility
269267
run: yarn lint:es-compatibility
270268

@@ -289,7 +287,7 @@ jobs:
289287
id: install_dependencies
290288

291289
- name: Check file formatting
292-
run: yarn lint:prettier && yarn lint:biome
290+
run: yarn lint:prettier
293291

294292
job_circular_dep_check:
295293
name: Circular Dependency Check

.prettierignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
packages/browser/test/loader.js
2+
packages/replay-worker/examples/worker.min.js

.prettierrc.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"arrowParens": "avoid",
3+
"printWidth": 120,
4+
"proseWrap": "always",
5+
"singleQuote": true,
6+
"trailingComma": "all"
7+
}

.vscode/extensions.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// for the documentation about the extensions.json format
44
"recommendations": [
55
"esbenp.prettier-vscode",
6-
"biomejs.biome",
76
"dbaeumer.vscode-eslint",
87
"augustocdias.tasks-shell-input",
98
"denoland.vscode-deno"

.vscode/settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
}
2626
],
2727
"deno.enablePaths": ["packages/deno/test"],
28-
"editor.defaultFormatter": "biomejs.biome",
28+
"editor.defaultFormatter": "esbenp.prettier-vscode",
2929
"[typescript]": {
30-
"editor.defaultFormatter": "biomejs.biome"
30+
"editor.defaultFormatter": "esbenp.prettier-vscode"
3131
}
3232
}

biome.json

Lines changed: 0 additions & 103 deletions
This file was deleted.

package.json

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,14 @@
2020
"clean:tarballs": "rimraf {packages,dev-packages}/*/*.tgz",
2121
"clean:watchman": "watchman watch-del \".\"",
2222
"clean:all": "run-s clean:build clean:tarballs clean:caches clean:deps clean:watchman",
23-
"fix": "run-s fix:biome fix:prettier fix:lerna",
23+
"fix": "run-s fix:prettier fix:lerna",
2424
"fix:lerna": "lerna run fix",
25-
"fix:biome": "biome check --apply .",
26-
"fix:prettier": "prettier \"**/*.md\" \"**/*.css\" --write",
25+
"fix:prettier": "prettier \"**/*.md\" \"**/*.css\" \"packages/**/**.{ts,js}\" --write",
2726
"changelog": "ts-node ./scripts/get-commit-list.ts",
2827
"link:yarn": "lerna exec yarn link",
29-
"lint": "run-s lint:lerna lint:biome lint:prettier",
30-
"lint:clang": "lerna run lint:clang",
28+
"lint": "run-s lint:prettier lint:lerna",
3129
"lint:lerna": "lerna run lint",
32-
"lint:biome": "biome check .",
33-
"lint:prettier": "prettier \"**/*.md\" \"**/*.css\" --check",
30+
"lint:prettier": "prettier \"**/*.md\" \"**/*.css\" \"packages/**/**.{ts,js}\" --check",
3431
"lint:es-compatibility": "es-check es2020 ./packages/*/build/{bundles,npm/cjs,cjs}/*.js && es-check es2020 ./packages/*/build/{npm/esm,esm}/*.js --module",
3532
"postpublish": "lerna run --stream --concurrency 1 postpublish",
3633
"test": "lerna run --ignore \"@sentry-internal/{browser-integration-tests,e2e-tests,integration-shims,node-integration-tests}\" test",
@@ -98,7 +95,6 @@
9895
"dev-packages/rollup-utils"
9996
],
10097
"devDependencies": {
101-
"@biomejs/biome": "^1.5.2",
10298
"@rollup/plugin-commonjs": "^25.0.7",
10399
"@rollup/plugin-esm-shim": "^0.1.5",
104100
"@rollup/plugin-json": "^6.1.0",

packages/browser/src/exports.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,7 @@ export {
8282
} from './stack-parsers';
8383
export { eventFromException, eventFromMessage, exceptionFromError } from './eventbuilder';
8484
export { createUserFeedbackEnvelope } from './userfeedback';
85-
export {
86-
getDefaultIntegrations,
87-
forceLoad,
88-
init,
89-
onLoad,
90-
showReportDialog,
91-
} from './sdk';
85+
export { getDefaultIntegrations, forceLoad, init, onLoad, showReportDialog } from './sdk';
9286

9387
export { breadcrumbsIntegration } from './integrations/breadcrumbs';
9488
export { globalHandlersIntegration } from './integrations/globalhandlers';

packages/browser/src/index.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,7 @@ export { makeBrowserOfflineTransport } from './transports/offline';
6262
export { browserProfilingIntegration } from './profiling/integration';
6363
export { spotlightBrowserIntegration } from './integrations/spotlight';
6464
export { browserSessionIntegration } from './integrations/browsersession';
65-
export {
66-
featureFlagsIntegration,
67-
type FeatureFlagsIntegration,
68-
} from './integrations/featureFlags';
65+
export { featureFlagsIntegration, type FeatureFlagsIntegration } from './integrations/featureFlags';
6966
export { launchDarklyIntegration, buildLaunchDarklyFlagUsedHandler } from './integrations/featureFlags/launchdarkly';
7067
export { openFeatureIntegration, OpenFeatureIntegrationHook } from './integrations/featureFlags/openfeature';
7168
export { unleashIntegration } from './integrations/featureFlags/unleash';

packages/core/src/index.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,7 @@ export {
3939
getClient,
4040
getTraceContextFromScope,
4141
} from './currentScopes';
42-
export {
43-
getDefaultCurrentScope,
44-
getDefaultIsolationScope,
45-
} from './defaultScopes';
42+
export { getDefaultCurrentScope, getDefaultIsolationScope } from './defaultScopes';
4643
export { setAsyncContextStrategy } from './asyncContext';
4744
export { getGlobalSingleton, getMainCarrier } from './carrier';
4845
export { makeSession, closeSession, updateSession } from './session';
@@ -60,11 +57,7 @@ export { initAndBind, setCurrentClient } from './sdk';
6057
export { createTransport } from './transports/base';
6158
export { makeOfflineTransport } from './transports/offline';
6259
export { makeMultiplexedTransport } from './transports/multiplexed';
63-
export {
64-
getIntegrationsToSetup,
65-
addIntegration,
66-
defineIntegration,
67-
} from './integration';
60+
export { getIntegrationsToSetup, addIntegration, defineIntegration } from './integration';
6861
export { applyScopeDataToEvent, mergeScopeData } from './utils/applyScopeDataToEvent';
6962
export { prepareEvent } from './utils/prepareEvent';
7063
export { createCheckInEnvelope } from './checkin';

0 commit comments

Comments
 (0)