Resolve ai comments

Author: RulaKhaled

packages/core/src/utils/anthropic-ai/index.ts

@@ -48,8 +48,9 @@ function extractRequestAttributes(args: unknown[], methodPath: string): Record<s
     if ('top_p' in params) attributes[GEN_AI_REQUEST_TOP_P_ATTRIBUTE] = params.top_p;
     if ('stream' in params) attributes[GEN_AI_REQUEST_STREAM_ATTRIBUTE] = params.stream;
     if ('top_k' in params) attributes[GEN_AI_REQUEST_TOP_K_ATTRIBUTE] = params.top_k;
-    attributes[GEN_AI_REQUEST_FREQUENCY_PENALTY_ATTRIBUTE] = params.frequency_penalty;
-    attributes[GEN_AI_REQUEST_MAX_TOKENS_ATTRIBUTE] = params.max_tokens;
+    if ('frequency_penalty' in params)
+      attributes[GEN_AI_REQUEST_FREQUENCY_PENALTY_ATTRIBUTE] = params.frequency_penalty;
+    if ('max_tokens' in params) attributes[GEN_AI_REQUEST_MAX_TOKENS_ATTRIBUTE] = params.max_tokens;
   } else {
     if (methodPath === 'models.retrieve' || methodPath === 'models.get') {
       // models.retrieve(model-id) and models.get(model-id)
@@ -90,7 +91,10 @@ function addResponseAttributes(span: Span, response: AnthropicAiResponse, record
     if ('content' in response) {
       if (Array.isArray(response.content)) {
         span.setAttributes({
-          [GEN_AI_RESPONSE_TEXT_ATTRIBUTE]: response.content.map((item: { text: string }) => item.text).join(''),
+          [GEN_AI_RESPONSE_TEXT_ATTRIBUTE]: response.content
+            .map((item: { text: string | undefined }) => item.text)
+            .filter((text): text is string => text !== undefined)
+            .join(''),
         });
       }
     }
@@ -114,11 +118,11 @@ function addResponseAttributes(span: Span, response: AnthropicAiResponse, record
     span.setAttributes({
       [ANTHROPIC_AI_RESPONSE_TIMESTAMP_ATTRIBUTE]: new Date(response.created * 1000).toISOString(),
     });
-    if ('created_at' in response && typeof response.created_at === 'number') {
-      span.setAttributes({
-        [ANTHROPIC_AI_RESPONSE_TIMESTAMP_ATTRIBUTE]: new Date(response.created_at * 1000).toISOString(),
-      });
-    }
+  }
+  if ('created_at' in response && typeof response.created_at === 'number') {
+    span.setAttributes({
+      [ANTHROPIC_AI_RESPONSE_TIMESTAMP_ATTRIBUTE]: new Date(response.created_at * 1000).toISOString(),
+    });
   }
 
   if (response.usage) {