Skip to content

Commit 556d9d5

Browse files
committed
reorder & fix...?
1 parent ccbc735 commit 556d9d5

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

.github/workflows/build.yml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -920,11 +920,6 @@ jobs:
920920
if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
921921
run: yarn build:tarball
922922

923-
- name: Install Playwright
924-
uses: ./.github/actions/install-playwright
925-
with:
926-
browsers: chromium
927-
928923
- name: Get node version
929924
id: versions
930925
run: |
@@ -945,6 +940,12 @@ jobs:
945940
timeout-minutes: 7
946941
run: pnpm ${{ matrix.build-command || 'test:build' }}
947942

943+
- name: Install Playwright
944+
uses: ./.github/actions/install-playwright
945+
with:
946+
browsers: chromium
947+
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
948+
948949
- name: Run E2E test
949950
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
950951
timeout-minutes: 10
@@ -984,7 +985,7 @@ jobs:
984985

985986
# - We skip optional tests on release branches
986987
job_optional_e2e_tests:
987-
name: E2E ${{ matrix.label || matrix.test-application }} Test
988+
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
988989
# We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
989990
# We need to add the `always()` check here because the previous step has this as well :(
990991
# See: https://github.com/actions/runner/issues/2205
@@ -1039,11 +1040,6 @@ jobs:
10391040
if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
10401041
run: yarn build:tarball
10411042

1042-
- name: Install Playwright
1043-
uses: ./.github/actions/install-playwright
1044-
with:
1045-
browsers: chromium
1046-
10471043
- name: Get node version
10481044
id: versions
10491045
run: |
@@ -1064,6 +1060,12 @@ jobs:
10641060
timeout-minutes: 7
10651061
run: pnpm ${{ matrix.build-command || 'test:build' }}
10661062

1063+
- name: Install Playwright
1064+
uses: ./.github/actions/install-playwright
1065+
with:
1066+
browsers: chromium
1067+
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
1068+
10671069
- name: Run E2E test
10681070
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
10691071
timeout-minutes: 10

0 commit comments

Comments
 (0)