Skip to content

Commit 5b81700

Browse files
author
Luca Forstner
committed
.
1 parent 4a2a7ae commit 5b81700

File tree

2 files changed

+3
-1
lines changed
  • dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone
  • packages/core/src

2 files changed

+3
-1
lines changed

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone/test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ sentryTest('sends a segment span envelope', async ({ getLocalTestUrl, page }) =>
4545
data: {
4646
'sentry.origin': 'manual',
4747
'sentry.sample_rate': 1,
48-
'sentry.override_trace_sample_rate': true, // This should probably not be here but for now it will be.
4948
'sentry.source': 'custom',
5049
},
5150
description: 'standalone_segment_span',

packages/core/src/envelope.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,11 @@ export function createSpanEnvelope(spans: [SentrySpan, ...SentrySpan[]], client?
142142
const items: SpanItem[] = [];
143143
for (const span of spans) {
144144
const spanJson = convertToSpanJSON(span);
145+
146+
// This attribute is important for internal logic but should not leak into actual data
145147
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
146148
delete spanJson.data[SEMANTIC_ATTRIBUTE_SENTRY_OVERRIDE_TRACE_SAMPLE_RATE];
149+
147150
if (spanJson) {
148151
items.push(createSpanEnvelopeItem(spanJson));
149152
}

0 commit comments

Comments
 (0)