Skip to content

Commit 5e3f706

Browse files
author
Luca Forstner
committed
don't leak attribute into actual data
1 parent 37b6ca2 commit 5e3f706

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/core/src/tracing/sentrySpan.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
88
SEMANTIC_ATTRIBUTE_SENTRY_OP,
99
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
10+
SEMANTIC_ATTRIBUTE_SENTRY_OVERRIDE_TRACE_SAMPLE_RATE,
1011
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
1112
} from '../semanticAttributes';
1213
import type {
@@ -348,6 +349,7 @@ export class SentrySpan implements Span {
348349
// remove internal root span attributes we don't need to send.
349350
/* eslint-disable @typescript-eslint/no-dynamic-delete */
350351
delete this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME];
352+
delete this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_OVERRIDE_TRACE_SAMPLE_RATE];
351353
spans.forEach(span => {
352354
span.data && delete span.data[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME];
353355
});

0 commit comments

Comments
 (0)