feat(node): Capture pino logger name (#17930)

Pino loggers can be named but we didn't capture this information:

```ts
import pino from 'pino';

const logger = pino({ name: 'my-component' });
```

This PR changes the hook from `start` to `end` which means we can parse
the output JSON and fetch the name if one was supplied.

Author: timfish

dev-packages/node-integration-tests/suites/pino/scenario-next.mjs

@@ -1,7 +1,7 @@
 import * as Sentry from '@sentry/node';
 import pino from 'pino-next';
 
-const logger = pino({});
+const logger = pino({ name: 'myapp' });
 
 Sentry.withIsolationScope(() => {
   Sentry.startSpan({ name: 'startup' }, () => {

dev-packages/node-integration-tests/suites/pino/scenario.mjs

@@ -1,7 +1,7 @@
 import * as Sentry from '@sentry/node';
 import pino from 'pino';
 
-const logger = pino({});
+const logger = pino({ name: 'myapp' });
 
 Sentry.withIsolationScope(() => {
   Sentry.startSpan({ name: 'startup' }, () => {

dev-packages/node-integration-tests/suites/pino/test.ts

@@ -64,13 +64,14 @@ conditionalTest({ min: 20 })('Pino integration', () => {
               trace_id: expect.any(String),
               severity_number: 9,
               attributes: expect.objectContaining({
-                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
-                'sentry.pino.level': { value: 30, type: 'integer' },
+                'pino.logger.name': { value: 'myapp', type: 'string' },
+                'pino.logger.level': { value: 30, type: 'integer' },
                 user: { value: 'user-id', type: 'string' },
                 something: {
                   type: 'string',
                   value: '{"more":3,"complex":"nope"}',
                 },
+                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },
                 'sentry.sdk.name': { value: 'sentry.javascript.node', type: 'string' },
               }),
@@ -82,9 +83,10 @@ conditionalTest({ min: 20 })('Pino integration', () => {
               trace_id: expect.any(String),
               severity_number: 17,
               attributes: expect.objectContaining({
-                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
-                'sentry.pino.level': { value: 50, type: 'integer' },
+                'pino.logger.name': { value: 'myapp', type: 'string' },
+                'pino.logger.level': { value: 50, type: 'integer' },
                 err: { value: '{}', type: 'string' },
+                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },
                 'sentry.sdk.name': { value: 'sentry.javascript.node', type: 'string' },
               }),
@@ -138,13 +140,14 @@ conditionalTest({ min: 20 })('Pino integration', () => {
               trace_id: expect.any(String),
               severity_number: 9,
               attributes: expect.objectContaining({
-                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
-                'sentry.pino.level': { value: 30, type: 'integer' },
+                'pino.logger.name': { value: 'myapp', type: 'string' },
+                'pino.logger.level': { value: 30, type: 'integer' },
                 user: { value: 'user-id', type: 'string' },
                 something: {
                   type: 'string',
                   value: '{"more":3,"complex":"nope"}',
                 },
+                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },
                 'sentry.sdk.name': { value: 'sentry.javascript.node', type: 'string' },
               }),
@@ -156,9 +159,10 @@ conditionalTest({ min: 20 })('Pino integration', () => {
               trace_id: expect.any(String),
               severity_number: 17,
               attributes: expect.objectContaining({
-                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
-                'sentry.pino.level': { value: 50, type: 'integer' },
+                'pino.logger.name': { value: 'myapp', type: 'string' },
+                'pino.logger.level': { value: 50, type: 'integer' },
                 err: { value: '{}', type: 'string' },
+                'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },
                 'sentry.sdk.name': { value: 'sentry.javascript.node', type: 'string' },
               }),

packages/node-core/src/integrations/pino.ts

@@ -94,17 +94,23 @@ export const pinoIntegration = defineIntegration((userOptions: DeepPartial<PinoO
       const injectedChannel = tracingChannel('orchestrion:pino:pino-log');
       const integratedChannel = tracingChannel('pino_asJson');
 
-      function onPinoStart(self: Pino, args: PinoHookArgs): void {
+      function onPinoStart(self: Pino, args: PinoHookArgs, result: string): void {
         const [obj, message, levelNumber] = args;
         const level = self?.levels?.labels?.[levelNumber] || 'info';
 
-        const attributes = {
-          ...obj,
-          'sentry.origin': 'auto.logging.pino',
-          'sentry.pino.level': levelNumber,
-        };
-
         if (enableLogs && options.log.levels.includes(level)) {
+          const attributes: Record<string, unknown> = {
+            ...obj,
+            'sentry.origin': 'auto.logging.pino',
+            'pino.logger.level': levelNumber,
+          };
+
+          const parsedResult = JSON.parse(result) as { name?: string };
+
+          if (parsedResult.name) {
+            attributes['pino.logger.name'] = parsedResult.name;
+          }
+
           _INTERNAL_captureLog({ level, message, attributes });
         }
 
@@ -135,14 +141,18 @@ export const pinoIntegration = defineIntegration((userOptions: DeepPartial<PinoO
         }
       }
 
-      injectedChannel.start.subscribe(data => {
-        const { self, arguments: args } = data as { self: Pino; arguments: PinoHookArgs };
-        onPinoStart(self, args);
+      injectedChannel.end.subscribe(data => {
+        const { self, arguments: args, result } = data as { self: Pino; arguments: PinoHookArgs; result: string };
+        onPinoStart(self, args, result);
       });
 
-      integratedChannel.start.subscribe(data => {
-        const { instance, arguments: args } = data as { instance: Pino; arguments: PinoHookArgs };
-        onPinoStart(instance, args);
+      integratedChannel.end.subscribe(data => {
+        const {
+          instance,
+          arguments: args,
+          result,
+        } = data as { instance: Pino; arguments: PinoHookArgs; result: string };
+        onPinoStart(instance, args, result);
       });
     },
   };