fix webkit test

Author: Lms24

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/test.ts

@@ -85,10 +85,7 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
       'http.request.secure_connection_start': expect.any(Number),
       'http.request.worker_start': expect.any(Number),
       'http.response.end': expect.any(Number),
-      'http.response.final_response_headers_start': expect.any(Number),
-      'http.response.first_interim_response_start': expect.any(Number),
       'http.response.start': expect.any(Number),
-      'http.response.status_code': expect.any(Number),
       'network.protocol.name': '',
       'network.protocol.version': 'unknown',
       [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.img',
@@ -97,6 +94,9 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
       'url.same_origin': false,
       'url.scheme': 'https',
       ...(!isWebkitRun && {
+        'http.response.status_code': expect.any(Number),
+        'http.response.final_response_headers_start': expect.any(Number),
+        'http.response.first_interim_response_start': expect.any(Number),
         'resource.render_blocking_status': 'non-blocking',
         'http.response_delivery_type': '',
       }),
@@ -127,10 +127,7 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
       'http.request.secure_connection_start': expect.any(Number),
       'http.request.worker_start': expect.any(Number),
       'http.response.end': expect.any(Number),
-      'http.response.final_response_headers_start': expect.any(Number),
-      'http.response.first_interim_response_start': expect.any(Number),
       'http.response.start': expect.any(Number),
-      'http.response.status_code': expect.any(Number),
       'network.protocol.name': '',
       'network.protocol.version': 'unknown',
       [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.link',
@@ -139,6 +136,9 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
       'url.same_origin': false,
       'url.scheme': 'https',
       ...(!isWebkitRun && {
+        'http.response.status_code': expect.any(Number),
+        'http.response.final_response_headers_start': expect.any(Number),
+        'http.response.first_interim_response_start': expect.any(Number),
         'resource.render_blocking_status': 'non-blocking',
         'http.response_delivery_type': '',
       }),
@@ -169,10 +169,7 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
       'http.request.secure_connection_start': expect.any(Number),
       'http.request.worker_start': expect.any(Number),
       'http.response.end': expect.any(Number),
-      'http.response.final_response_headers_start': expect.any(Number),
-      'http.response.first_interim_response_start': expect.any(Number),
       'http.response.start': expect.any(Number),
-      'http.response.status_code': expect.any(Number),
       'network.protocol.name': '',
       'network.protocol.version': 'unknown',
       'sentry.op': 'resource.script',
@@ -181,6 +178,9 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
       'url.same_origin': false,
       'url.scheme': 'https',
       ...(!isWebkitRun && {
+        'http.response.status_code': expect.any(Number),
+        'http.response.final_response_headers_start': expect.any(Number),
+        'http.response.first_interim_response_start': expect.any(Number),
         'resource.render_blocking_status': 'non-blocking',
         'http.response_delivery_type': '',
       }),

packages/browser-utils/src/metrics/browserMetrics.ts

@@ -675,7 +675,7 @@ export function _addResourceSpans(
   }
 
   _setResourceRequestAttributes(entry, attributes, [
-    // Resource request response status
+    // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
     ['responseStatus', 'http.response.status_code'],
 
     // Timing attributes (request/response lifecycle)
@@ -809,8 +809,10 @@ type ExperimentalResourceTimingProperty =
   | 'finalResponseHeadersStart'
   | 'renderBlockingStatus'
   | 'deliveryType'
-  // for some reason, TS during build things this is not a property of PerformanceResourceTiming
-  // while it actually is. Hence, we're adding it here
+  // For some reason, TS during build, errors on `responseStatus` not being a property of
+  // PerformanceResourceTiming while it actually is. Hence, we're adding it here.
+  // Perhaps because response status is not yet available in Webkit/Safari.
+  // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
   | 'responseStatus';
 
 /**