Skip to content

Commit 6605b5a

Browse files
authored
Merge branch 'develop' into sig/nitro-utils-just-utils
2 parents 33532cf + 9c55aa0 commit 6605b5a

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
1212

13+
Work in this release was contributed by @lsmurray. Thank you for your contribution!
14+
1315
## 8.42.0
1416

1517
### Important Changes

packages/nextjs/src/config/webpack.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -336,20 +336,11 @@ export function constructWebpackConfigFunction(
336336

337337
if (sentryWebpackPlugin) {
338338
if (!userSentryOptions.sourcemaps?.disable) {
339-
// TODO(v9): Remove this warning
340-
if (newConfig.devtool === false) {
341-
const runtimePrefix = !isServer ? 'Client' : runtime === 'edge' ? 'Edge' : 'Node.js';
342-
// eslint-disable-next-line no-console
343-
console.warn(
344-
`[@sentry/nextjs - ${runtimePrefix}] You disabled sourcemaps with the Webpack \`devtool\` option. Currently, the Sentry SDK will override this option to generate sourcemaps. In future versions, the Sentry SDK will not override the \`devtool\` option if you explicitly disable it. If you want to generate and upload sourcemaps please set the \`devtool\` option to 'hidden-source-map' or undefined.`,
345-
);
346-
}
347-
348339
// TODO(v9): Remove this warning and print warning in case source map deletion is auto configured
349340
if (!isServer && !userSentryOptions.sourcemaps?.deleteSourcemapsAfterUpload) {
350341
// eslint-disable-next-line no-console
351342
console.warn(
352-
"[@sentry/nextjs] The Sentry SDK has enabled source map generation for your Next.js app. If you don't want to serve Source Maps to your users, either set the `deleteSourceMapsAfterUpload` option to true, or manually delete the source maps after the build. In future Sentry SDK versions `deleteSourceMapsAfterUpload` will default to `true`.",
343+
"[@sentry/nextjs] The Sentry SDK has enabled source map generation for your Next.js app. If you don't want to serve Source Maps to your users, either set the `deleteSourceMapsAfterUpload` option to true, or manually delete the source maps after the build. In future Sentry SDK versions `deleteSourceMapsAfterUpload` will default to `true`. If you do not want to generate and upload sourcemaps, set the `sourcemaps.disable` option in `withSentryConfig()`.",
353344
);
354345
}
355346

packages/react/src/tanstackrouter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export function tanstackRouterBrowserTracingIntegration(
4444
if (instrumentPageLoad && initialWindowLocation) {
4545
const matchedRoutes = castRouterInstance.matchRoutes(
4646
initialWindowLocation.pathname,
47-
initialWindowLocation.search,
47+
castRouterInstance.options.parseSearch(initialWindowLocation.search),
4848
{ preload: false, throwOnError: false },
4949
);
5050

packages/react/src/vendor/tanstackrouter-types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ SOFTWARE.
2929
export interface VendoredTanstackRouter {
3030
history: VendoredTanstackRouterHistory;
3131
state: VendoredTanstackRouterState;
32+
options: {
33+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
34+
parseSearch: (search: string) => Record<string, any>;
35+
};
3236
matchRoutes: (
3337
pathname: string,
3438
// eslint-disable-next-line @typescript-eslint/ban-types

0 commit comments

Comments
 (0)