Skip to content

Commit 6a79624

Browse files
committed
Remove dsn, fix cursor complaints
1 parent 1105891 commit 6a79624

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

dev-packages/e2e-tests/test-applications/node-core-express-otel-v1-sdk-node/src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ app.get('/test-exception/:id', function (req, _res) {
4242
app.use(function onError(err: unknown, req: any, res: any, next: any) {
4343
// Explicitly capture the error with Sentry because @sentry/node-core doesn't have
4444
// a way to capture errors from express like @sentry/node does.
45-
Sentry.captureException(err);
45+
res.sentry = Sentry.captureException(err);
4646

4747
// The error id is attached to `res.sentry` to be returned
4848
// and optionally displayed to the user for support.

dev-packages/e2e-tests/test-applications/node-core-express-otel-v1-sdk-node/src/instrument.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ const { SentrySpanProcessor, SentryPropagator, SentrySampler } = require('@sentr
66

77
const sentryClient = Sentry.init({
88
environment: 'qa', // dynamic sampling bias to keep transactions
9-
dsn:
10-
process.env.E2E_TEST_DSN ||
11-
'https://3b6c388182fb435097f41d181be2b2ba@o4504321058471936.ingest.sentry.io/4504321066008576',
9+
dsn: process.env.E2E_TEST_DSN,
1210
includeLocalVariables: true,
1311
debug: true,
1412
tunnel: `http://localhost:3031/`, // proxy server
@@ -22,7 +20,7 @@ if (sentryClient) {
2220
contextManager: new Sentry.SentryContextManager(),
2321
spanProcessors: [
2422
new SentrySpanProcessor(),
25-
new opentelemetry.node.BatchSpanProcessor(
23+
new opentelemetry.BatchSpanProcessor(
2624
new OTLPTraceExporter({
2725
url: 'http://localhost:3032/',
2826
}),

dev-packages/e2e-tests/test-applications/node-core-express-otel-v2-sdk-node/src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ app.get('/test-exception/:id', function (req, _res) {
4242
app.use(function onError(err: unknown, req: any, res: any, next: any) {
4343
// Explicitly capture the error with Sentry because @sentry/node-core doesn't have
4444
// a way to capture errors from express like @sentry/node does.
45-
Sentry.captureException(err);
45+
res.sentry = Sentry.captureException(err);
4646

4747
// The error id is attached to `res.sentry` to be returned
4848
// and optionally displayed to the user for support.

dev-packages/e2e-tests/test-applications/node-core-express-otel-v2-sdk-node/src/instrument.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ const { SentrySpanProcessor, SentryPropagator, SentrySampler } = require('@sentr
66

77
const sentryClient = Sentry.init({
88
environment: 'qa', // dynamic sampling bias to keep transactions
9-
dsn:
10-
process.env.E2E_TEST_DSN ||
11-
'https://3b6c388182fb435097f41d181be2b2ba@o4504321058471936.ingest.sentry.io/4504321066008576',
9+
dsn: process.env.E2E_TEST_DSN,
1210
includeLocalVariables: true,
1311
debug: true,
1412
tunnel: `http://localhost:3031/`, // proxy server
@@ -22,7 +20,7 @@ if (sentryClient) {
2220
contextManager: new Sentry.SentryContextManager(),
2321
spanProcessors: [
2422
new SentrySpanProcessor(),
25-
new opentelemetry.node.BatchSpanProcessor(
23+
new opentelemetry.BatchSpanProcessor(
2624
new OTLPTraceExporter({
2725
url: 'http://localhost:3032/',
2826
}),

0 commit comments

Comments
 (0)