build: Upgrade eslint to 7.27.0 (#3639)

AbhiPrasad · web-flow · commit 6ae95a4774f8 · 2021-06-02T08:33:32.000-04:00
* Upgrade @sentry-internal/eslint-config-sdk to eslint 7.27.0
* Move eslint dep to workspace root package.json
* Fix no-floating-promises errors
diff --git a/package.json b/package.json
@@ -53,6 +53,7 @@
     "@types/sinon": "^7.0.11",
     "chai": "^4.1.2",
     "codecov": "^3.6.5",
+    "eslint": "7.27.0",
     "jest": "^24.7.1",
     "karma-browserstack-launcher": "^1.5.1",
     "karma-firefox-launcher": "^1.1.0",
diff --git a/packages/angular/package.json b/packages/angular/package.json
@@ -32,7 +32,6 @@
     "@angular/core": "^10.0.3",
     "@angular/router": "^10.0.3",
     "@sentry-internal/eslint-config-sdk": "6.5.0",
-    "eslint": "7.6.0",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
     "rimraf": "^2.6.3",
diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -28,7 +28,6 @@
     "btoa": "^1.2.1",
     "chai": "^4.1.2",
     "chokidar": "^3.0.2",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "jsdom": "^15.0.0",
     "karma": "^4.1.0",
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -24,7 +24,6 @@
   },
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
diff --git a/packages/core/src/basebackend.ts b/packages/core/src/basebackend.ts
@@ -91,7 +91,7 @@ export abstract class BaseBackend<O extends Options> implements Backend {
    * @inheritDoc
    */
   public sendEvent(event: Event): void {
-    this._transport.sendEvent(event).then(null, reason => {
+    void this._transport.sendEvent(event).then(null, reason => {
       logger.error(`Error while sending event: ${reason}`);
     });
   }
@@ -105,7 +105,7 @@ export abstract class BaseBackend<O extends Options> implements Backend {
       return;
     }
 
-    this._transport.sendSession(session).then(null, reason => {
+    void this._transport.sendSession(session).then(null, reason => {
       logger.error(`Error while sending session: ${reason}`);
     });
   }
diff --git a/packages/core/src/baseclient.ts b/packages/core/src/baseclient.ts
@@ -559,7 +559,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
    */
   protected _process<T>(promise: PromiseLike<T>): void {
     this._processing += 1;
-    promise.then(
+    void promise.then(
       value => {
         this._processing -= 1;
         return value;
diff --git a/packages/ember/package.json b/packages/ember/package.json
@@ -73,7 +73,6 @@
     "ember-test-selectors": "^4.1.0",
     "ember-try": "^1.4.0",
     "ember-window-mock": "^0.7.1",
-    "eslint": "7.6.0",
     "eslint-plugin-ember": "^8.6.0",
     "eslint-plugin-node": "^11.1.0",
     "loader.js": "^4.7.0",
diff --git a/packages/eslint-config-sdk/package.json b/packages/eslint-config-sdk/package.json
@@ -33,7 +33,7 @@
     "eslint": ">=5"
   },
   "devDependencies": {
-    "eslint": "7.6.0",
+    "eslint": "7.27.0",
     "typescript": "3.7.5"
   },
   "scripts": {
diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json
@@ -35,7 +35,6 @@
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
     "@testing-library/react": "^10.4.9",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
diff --git a/packages/hub/package.json b/packages/hub/package.json
@@ -22,7 +22,6 @@
   },
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
diff --git a/packages/integrations/package.json b/packages/integrations/package.json
@@ -24,7 +24,6 @@
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
     "chai": "^4.1.2",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
diff --git a/packages/minimal/package.json b/packages/minimal/package.json
@@ -22,7 +22,6 @@
   },
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
diff --git a/packages/node/package.json b/packages/node/package.json
@@ -32,7 +32,6 @@
     "@types/express": "^4.17.2",
     "@types/lru-cache": "^5.1.0",
     "@types/node": "~10.17.0",
-    "eslint": "7.6.0",
     "express": "^4.17.1",
     "jest": "^24.7.1",
     "nock": "^13.0.5",
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -37,7 +37,6 @@
     "@types/react-router-3": "npm:@types/react-router@3.0.24",
     "@types/react-router-4": "npm:@types/react-router@5.1.14",
     "@types/react-router-5": "npm:@types/react-router@5.1.14",
-    "eslint": "7.6.0",
     "eslint-plugin-react": "^7.20.5",
     "eslint-plugin-react-hooks": "^4.0.8",
     "history-4": "npm:history@4.6.0",
diff --git a/packages/serverless/package.json b/packages/serverless/package.json
@@ -33,7 +33,6 @@
     "@sentry-internal/eslint-config-sdk": "6.5.0",
     "@types/node": "^14.6.4",
     "aws-sdk": "^2.765.0",
-    "eslint": "7.6.0",
     "find-up": "^5.0.0",
     "google-gax": "^2.9.0",
     "jest": "^24.7.1",
diff --git a/packages/serverless/src/awslambda.ts b/packages/serverless/src/awslambda.ts
@@ -221,7 +221,7 @@ export function wrapHandler<TEvent, TResult>(
             // This should never happen, but still can if someone writes a handler as
             // `async (event, context, callback) => {}`
             if (isPromise(rv)) {
-              (rv as Promise<NonNullable<TResult>>).then(resolve, reject);
+              void (rv as Promise<NonNullable<TResult>>).then(resolve, reject);
             }
           })
       : (handler as AsyncHandler<typeof handler>);
diff --git a/packages/serverless/src/gcpfunction/cloud_events.ts b/packages/serverless/src/gcpfunction/cloud_events.ts
@@ -59,7 +59,7 @@ function _wrapCloudEventFunction(
       }
       transaction.finish();
 
-      flush(options.flushTimeout)
+      void flush(options.flushTimeout)
         .then(() => {
           callback(...args);
         })
@@ -72,7 +72,7 @@ function _wrapCloudEventFunction(
       return (fn as CloudEventFunctionWithCallback)(context, newCallback);
     }
 
-    Promise.resolve()
+    void Promise.resolve()
       .then(() => (fn as CloudEventFunction)(context))
       .then(
         result => {
diff --git a/packages/serverless/src/gcpfunction/events.ts b/packages/serverless/src/gcpfunction/events.ts
@@ -54,7 +54,7 @@ function _wrapEventFunction(
       }
       transaction.finish();
 
-      flush(options.flushTimeout)
+      void flush(options.flushTimeout)
         .then(() => {
           callback(...args);
         })
@@ -67,7 +67,7 @@ function _wrapEventFunction(
       return (fn as EventFunctionWithCallback)(data, context, newCallback);
     }
 
-    Promise.resolve()
+    void Promise.resolve()
       .then(() => (fn as EventFunction)(data, context))
       .then(
         result => {
diff --git a/packages/tracing/package.json b/packages/tracing/package.json
@@ -27,7 +27,6 @@
     "@sentry/browser": "6.5.0",
     "@types/express": "^4.17.1",
     "@types/jsdom": "^16.2.3",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "jsdom": "^16.2.2",
     "npm-run-all": "^4.1.2",
diff --git a/packages/types/package.json b/packages/types/package.json
@@ -17,7 +17,6 @@
   },
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
-    "eslint": "7.6.0",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
     "typescript": "3.7.5"
diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -22,7 +22,6 @@
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
     "chai": "^4.1.2",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
     "prettier": "1.19.0",
diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -29,7 +29,6 @@
   },
   "devDependencies": {
     "@sentry-internal/eslint-config-sdk": "6.5.0",
-    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "jsdom": "^16.2.2",
     "npm-run-all": "^4.1.2",
diff --git a/packages/wasm/package.json b/packages/wasm/package.json
@@ -24,7 +24,6 @@
     "@sentry-internal/eslint-config-sdk": "6.5.0",
     "@types/jest-environment-puppeteer": "^4.4.0",
     "@types/puppeteer": "^5.4.0",
-    "eslint": "7.6.0",
     "express": "^4.17.1",
     "jest": "^24.7.1",
     "jest-puppeteer": "^4.4.0",
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ export abstract class BaseBackend<O extends Options> implements Backend {`
`91`	`91`	`* @inheritDoc`
`92`	`92`	`*/`
`93`	`93`	`public sendEvent(event: Event): void {`
`94`		`- this._transport.sendEvent(event).then(null, reason => {`
	`94`	`+ void this._transport.sendEvent(event).then(null, reason => {`
`95`	`95`	logger.error(`Error while sending event: ${reason}`);
`96`	`96`	`});`
`97`	`97`	`}`
`@@ -105,7 +105,7 @@ export abstract class BaseBackend<O extends Options> implements Backend {`
`105`	`105`	`return;`
`106`	`106`	`}`
`107`	`107`
`108`		`- this._transport.sendSession(session).then(null, reason => {`
	`108`	`+ void this._transport.sendSession(session).then(null, reason => {`
`109`	`109`	logger.error(`Error while sending session: ${reason}`);
`110`	`110`	`});`
`111`	`111`	`}`