Skip to content

Commit 6f069a8

Browse files
committed
Avoid an accidental conflict with using 'event' as a var name
1 parent 66fef97 commit 6f069a8

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/raven.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,8 @@ Raven.setUser = Raven.setUserContext;
432432
Raven.setReleaseContext = Raven.setRelease;
433433

434434
function triggerEvent(eventType, options) {
435-
var event, key;
435+
// NOTE: `event` is a native browser thing, so let's avoid conflicting wiht it
436+
var evt, key;
436437

437438
if (!hasDocument)
438439
return;
@@ -442,25 +443,25 @@ function triggerEvent(eventType, options) {
442443
eventType = 'raven' + eventType.substr(0,1).toUpperCase() + eventType.substr(1);
443444

444445
if (document.createEvent) {
445-
event = document.createEvent('HTMLEvents');
446-
event.initEvent(eventType, true, true);
446+
evt = document.createEvent('HTMLEvents');
447+
evt.initEvent(eventType, true, true);
447448
} else {
448-
event = document.createEventObject();
449-
event.eventType = eventType;
449+
evt = document.createEventObject();
450+
evt.eventType = eventType;
450451
}
451452

452453
for (key in options) if (hasKey(options, key)) {
453-
event[key] = options[key];
454+
evt[key] = options[key];
454455
}
455456

456457
if (document.createEvent) {
457458
// IE9 if standards
458-
document.dispatchEvent(event);
459+
document.dispatchEvent(evt);
459460
} else {
460461
// IE8 regardless of Quirks or Standards
461462
// IE9 if quirks
462463
try {
463-
document.fireEvent('on' + event.eventType.toLowerCase(), event);
464+
document.fireEvent('on' + evt.eventType.toLowerCase(), evt);
464465
} catch(e) {}
465466
}
466467
}

0 commit comments

Comments
 (0)