Skip to content

Commit 7135d8f

Browse files
committed
Remove redirect test from nexctjs-14, remove redirect events from remix
integration tests
1 parent d5c827a commit 7135d8f

File tree

4 files changed

+6
-60
lines changed

4 files changed

+6
-60
lines changed

dev-packages/e2e-tests/test-applications/nextjs-14/app/generation-functions/with-redirect/page.tsx

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/nextjs-14/tests/generation-functions.test.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -108,20 +108,3 @@ test('Should send a transaction and an error event for a faulty generateViewport
108108

109109
expect(errorEvent.transaction).toBe('Page.generateViewport (/generation-functions)');
110110
});
111-
112-
test('Should send a transaction event with correct status for a generateMetadata() function invocation with redirect()', async ({
113-
page,
114-
}) => {
115-
const testTitle = 'redirect-foobar';
116-
117-
const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
118-
return (
119-
transactionEvent.contexts?.trace?.data?.['http.target'] ===
120-
`/generation-functions/with-redirect?metadataTitle=${testTitle}`
121-
);
122-
});
123-
124-
await page.goto(`/generation-functions/with-redirect?metadataTitle=${testTitle}`);
125-
126-
expect((await transactionPromise).contexts?.trace?.status).toBe('ok');
127-
});

packages/remix/test/integration/test/server/instrumentation/action.test.ts

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -152,28 +152,15 @@ describe('Remix API Actions', () => {
152152

153153
const envelopes = await env.getMultipleEnvelopeRequest({
154154
url,
155-
count: 3,
155+
count: 2,
156156
method: 'post',
157157
envelopeType: ['transaction', 'event'],
158158
});
159159

160-
const [transaction_1, transaction_2] = envelopes.filter(envelope => envelope[1].type === 'transaction');
160+
const [transaction] = envelopes.filter(envelope => envelope[1].type === 'transaction');
161161
const [event] = envelopes.filter(envelope => envelope[1].type === 'event');
162162

163-
assertSentryTransaction(transaction_1[2], {
164-
contexts: {
165-
trace: {
166-
op: 'http.server',
167-
status: 'ok',
168-
data: {
169-
'http.response.status_code': 302,
170-
},
171-
},
172-
},
173-
transaction: `POST action-json-response/:id`,
174-
});
175-
176-
assertSentryTransaction(transaction_2[2], {
163+
assertSentryTransaction(transaction[2], {
177164
contexts: {
178165
trace: {
179166
op: 'http.server',

packages/remix/test/integration/test/server/instrumentation/loader.test.ts

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -123,27 +123,14 @@ describe('Remix API Loaders', () => {
123123

124124
const envelopes = await env.getMultipleEnvelopeRequest({
125125
url,
126-
count: 3,
126+
count: 2,
127127
envelopeType: ['transaction', 'event'],
128128
});
129129

130-
const [transaction_1, transaction_2] = envelopes.filter(envelope => envelope[1].type === 'transaction');
130+
const [transaction] = envelopes.filter(envelope => envelope[1].type === 'transaction');
131131
const [event] = envelopes.filter(envelope => envelope[1].type === 'event');
132132

133-
assertSentryTransaction(transaction_1[2], {
134-
contexts: {
135-
trace: {
136-
op: 'http.server',
137-
status: 'ok',
138-
data: {
139-
'http.response.status_code': 302,
140-
},
141-
},
142-
},
143-
transaction: `GET loader-json-response/:id`,
144-
});
145-
146-
assertSentryTransaction(transaction_2[2], {
133+
assertSentryTransaction(transaction[2], {
147134
contexts: {
148135
trace: {
149136
op: 'http.server',

0 commit comments

Comments
 (0)