addressing comments

Author: obecny

dev-packages/e2e-tests/test-applications/firebase/README.md

@@ -5,10 +5,10 @@
 1. Run the docker
 
 ```bash
-npm run docker
+pnpm docker
 ```
 
-2In new tab, enter the docker container by simply running
+2. In new tab, enter the docker container by simply running
 
 ```bash
 docker exec -it sentry-firebase bash

dev-packages/e2e-tests/test-applications/firebase/package.json

@@ -9,24 +9,18 @@
     "dev": "tsc --build --watch",
     "docker": "cd docker && docker compose up --build",
     "proxy": "node start-event-proxy.mjs",
-    "start": "ts-node src/app.ts",
+    "start": "node ./dist/app.js",
     "test": "playwright test",
     "clean": "npx rimraf node_modules pnpm-lock.yaml",
     "test:build": "pnpm install && pnpm build",
     "test:assert": "pnpm test"
   },
-  "dependencies": {
-    "@sentry/core": "latest || *",
-    "@sentry/node": "latest || *",
-    "@sentry/types": "latest || *",
-    "typescript": "4.9.5"
-  },
   "devDependencies": {
     "@playwright/test": "^1.44.1",
     "@sentry-internal/test-utils": "link:../../../test-utils",
     "dotenv": "^16.4.5",
-    "ts-loader": "^9.5.1",
-    "tsconfig-paths": "^4.2.0"
+    "tsconfig-paths": "^4.2.0",
+    "typescript": "4.9.5"
   },
   "volta": {
     "extends": "../../package.json"

dev-packages/e2e-tests/test-applications/firebase/tests/transactions.test.ts

@@ -91,13 +91,13 @@ test.afterAll(() => {
 });
 
 test('should add, set, get and delete document', async ({ baseURL, page }) => {
-  const pageloadTransactionEventPromise = waitForTransaction('firebase', transactionEvent => {
+  const serverTransactionPromise = waitForTransaction('firebase', () => {
     return true;
   });
 
   await fetch(`${baseURL}/test`);
 
-  const transactionEvent = await pageloadTransactionEventPromise;
+  const transactionEvent = await serverTransactionPromise;
 
   expect(transactionEvent.transaction).toEqual('root span');
 

packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts

@@ -92,10 +92,10 @@ export function patchFirestore(
     '@firebase/firestore/dist/lite/index.cjs.js',
   ];
 
-  for (let i = 0, j = files.length; i < j; i++) {
+  for (const file of files) {
     moduleFirestoreCJS.files.push(
       new InstrumentationNodeModuleFile(
-        files[i] as string,
+        file,
         firestoreSupportedVersions,
         moduleExports => wrapMethods(moduleExports, wrap, unwrap, tracer, firestoreSpanCreationHook),
         moduleExports => unwrapMethods(moduleExports, unwrap),