Skip to content

Commit 79c9eba

Browse files
committed
fixes
1 parent e138626 commit 79c9eba

File tree

5 files changed

+19
-25
lines changed

5 files changed

+19
-25
lines changed

packages/cloudflare/src/transport.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
1-
import type {
2-
BaseTransportOptions,
3-
Transport,
4-
TransportMakeRequestResponse,
5-
TransportRequest} from '@sentry/core';
6-
import {
7-
SENTRY_BUFFER_FULL_ERROR,
8-
createTransport,
9-
suppressTracing,
10-
} from '@sentry/core';
1+
import type { BaseTransportOptions, Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/core';
2+
import { SENTRY_BUFFER_FULL_ERROR, createTransport, suppressTracing } from '@sentry/core';
113

124
export interface CloudflareTransportOptions extends BaseTransportOptions {
135
/** Fetch API init parameters. */

packages/cloudflare/test/transport.test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { createEnvelope, serializeEnvelope } from '@sentry/core';
1+
import { SENTRY_BUFFER_FULL_ERROR, createEnvelope, serializeEnvelope } from '@sentry/core';
22
import type { EventEnvelope, EventItem } from '@sentry/core';
33
import { afterAll, describe, expect, it, vi } from 'vitest';
44

@@ -140,7 +140,12 @@ describe('IsolatedPromiseBuffer', () => {
140140
await ipb.add(task2);
141141
await ipb.add(task3);
142142

143-
await expect(ipb.add(task4)).rejects.toThrowError('Not adding Promise because buffer limit was reached.');
143+
try {
144+
await ipb.add(task4);
145+
throw new Error('Should not be called');
146+
} catch (error) {
147+
expect(error).toBe(SENTRY_BUFFER_FULL_ERROR);
148+
}
144149
});
145150

146151
it('should not throw when one of the tasks throws when drained', async () => {

packages/core/src/utils-hoist/promisebuffer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export interface PromiseBuffer<T> {
88
drain(timeout?: number): PromiseLike<boolean>;
99
}
1010

11-
export const SENTRY_BUFFER_FULL_ERROR = Symbol('SentryBufferFullError');
11+
export const SENTRY_BUFFER_FULL_ERROR = Symbol.for('SentryBufferFullError');
1212

1313
/**
1414
* Creates an new PromiseBuffer object with the specified limit

packages/vercel-edge/src/transports/index.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
1-
import type {
2-
BaseTransportOptions,
3-
Transport,
4-
TransportMakeRequestResponse,
5-
TransportRequest} from '@sentry/core';
6-
import {
7-
SENTRY_BUFFER_FULL_ERROR,
8-
createTransport,
9-
suppressTracing,
10-
} from '@sentry/core';
1+
import type { BaseTransportOptions, Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/core';
2+
import { SENTRY_BUFFER_FULL_ERROR, createTransport, suppressTracing } from '@sentry/core';
113

124
export interface VercelEdgeTransportOptions extends BaseTransportOptions {
135
/** Fetch API init parameters. */

packages/vercel-edge/test/transports/index.test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { afterAll, describe, expect, it, vi } from 'vitest';
22

3-
import { createEnvelope, serializeEnvelope } from '@sentry/core';
3+
import { SENTRY_BUFFER_FULL_ERROR, createEnvelope, serializeEnvelope } from '@sentry/core';
44
import type { EventEnvelope, EventItem } from '@sentry/core';
55

66
import type { VercelEdgeTransportOptions } from '../../src/transports';
@@ -139,7 +139,12 @@ describe('IsolatedPromiseBuffer', () => {
139139
await ipb.add(task2);
140140
await ipb.add(task3);
141141

142-
await expect(ipb.add(task4)).rejects.toThrowError('Not adding Promise because buffer limit was reached.');
142+
try {
143+
await ipb.add(task4);
144+
throw new Error('Should not be called');
145+
} catch (error) {
146+
expect(error).toBe(SENTRY_BUFFER_FULL_ERROR);
147+
}
143148
});
144149

145150
it('should not throw when one of the tasks throws when drained', async () => {

0 commit comments

Comments
 (0)