Skip to content

Commit 7a10db7

Browse files
committed
update request and response spans and update tests
1 parent 8ff8ac9 commit 7a10db7

File tree

2 files changed

+3
-2
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics

2 files changed

+3
-2
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-browser-spans/test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ sentryTest('should add browser-related spans to pageload transaction', async ({
2121
['loadEvent', 'request', 'response'].forEach(eventDesc =>
2222
expect(browserSpans).toContainEqual(
2323
expect.objectContaining({
24-
description: eventDesc,
24+
op: `browser.${eventDesc}`,
25+
description: page.url(),
2526
parent_span_id: eventData.contexts?.trace?.span_id,
2627
}),
2728
),

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ sentryTest('should add browser-related spans to pageload transaction', async ({
2121

2222
const requestSpan = browserSpans!.find(({ op }) => op === 'browser.request');
2323
expect(requestSpan).toBeDefined();
24-
expect(requestSpan?.description).toBe('test');
24+
expect(requestSpan?.description).toBe(page.url());
2525

2626
const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
2727
expect(measureSpan).toBeDefined();

0 commit comments

Comments
 (0)