make shouldSkipLaunchDarklyTest to be generic for feature flags

Author: billyvg

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/basic/test.ts

@@ -2,12 +2,12 @@ import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../../../utils/fixtures';
 
-import { envelopeRequestParser, shouldSkipLaunchDarklyTest, waitForErrorRequest } from '../../../../../utils/helpers';
+import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
 const FLAG_BUFFER_SIZE = 100; // Corresponds to constant in featureFlags.ts, in browser utils.
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestPath, page }) => {
-  if (shouldSkipLaunchDarklyTest()) {
+  if (shouldSkipFeatureFlagsTest()) {
     sentryTest.skip();
   }
 

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/withScope/test.ts

@@ -2,12 +2,12 @@ import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../../../utils/fixtures';
 
-import { envelopeRequestParser, shouldSkipLaunchDarklyTest, waitForErrorRequest } from '../../../../../utils/helpers';
+import { envelopeRequestParser, shouldSkipFeatureFlagsTest, waitForErrorRequest } from '../../../../../utils/helpers';
 
 import type { Scope } from '@sentry/browser';
 
 sentryTest('Flag evaluations in forked scopes are stored separately.', async ({ getLocalTestPath, page }) => {
-  if (shouldSkipLaunchDarklyTest()) {
+  if (shouldSkipFeatureFlagsTest()) {
     sentryTest.skip();
   }
 

dev-packages/browser-integration-tests/utils/helpers.ts

@@ -274,13 +274,13 @@ export function shouldSkipMetricsTest(): boolean {
 }
 
 /**
- * We can only test the launchdarkly browser integration in certain bundles/packages:
+ * We only test feature flags integrations in certain bundles/packages:
  * - NPM (ESM, CJS)
  * - Not CDNs.
  *
  * @returns `true` if we should skip the launchdarkly test
  */
-export function shouldSkipLaunchDarklyTest(): boolean {
+export function shouldSkipFeatureFlagsTest(): boolean {
   const bundle = process.env.PW_BUNDLE as string | undefined;
   return bundle != null && !bundle.includes('esm') && !bundle.includes('cjs');
 }