fix: [browser/LinkedErrors] Fix limit to include the original exception (#1699)

Up until now the `limit` option only counted the linked errors, but not the original exception. After this commit the `limit` will correspond to the number of exceptions that are actually being displayed by Sentry in the end.

Author: Turbo87

packages/browser/src/integrations/linkederrors.ts

@@ -72,7 +72,7 @@ export class LinkedErrors implements Integration {
    * @inheritDoc
    */
   public walkErrorTree(error: ExtendedError, key: string, stack: SentryException[] = []): SentryException[] {
-    if (!(error[key] instanceof Error) || stack.length >= this.limit) {
+    if (!(error[key] instanceof Error) || stack.length + 1 >= this.limit) {
       return stack;
     }
     const stacktrace = computeStackTrace(error[key]);

packages/browser/test/integrations/linkederrors.test.ts

@@ -114,5 +114,35 @@ describe('LinkedErrors', () => {
       expect(result!.exception!.values![2].value).equal('three');
       expect(result!.exception!.values![2].stacktrace).to.have.property('frames');
     });
+
+    it('should allow to change stack size limit', async () => {
+      linkedErrors = new LinkedErrors({
+        limit: 2,
+      });
+
+      const three: ExtendedError = new SyntaxError('three');
+
+      const two: ExtendedError = new TypeError('two');
+      two.cause = three;
+
+      const one: ExtendedError = new Error('one');
+      one.cause = two;
+
+      const originalException = one;
+      const backend = new BrowserBackend({});
+      const event = await backend.eventFromException(originalException);
+      const result = linkedErrors.handler(event, {
+        originalException,
+      });
+
+      // It shouldn't include root exception, as it's already processed in the event by the main error handler
+      expect(result!.exception!.values!.length).equal(2);
+      expect(result!.exception!.values![0].type).equal('Error');
+      expect(result!.exception!.values![0].value).equal('one');
+      expect(result!.exception!.values![0].stacktrace).to.have.property('frames');
+      expect(result!.exception!.values![1].type).equal('TypeError');
+      expect(result!.exception!.values![1].value).equal('two');
+      expect(result!.exception!.values![1].stacktrace).to.have.property('frames');
+    });
   });
 });