test(core): Add unit test for the updated log level function

Signed-off-by: Kaung Zin Hein <[email protected]>

Author: Zen-cronic

packages/core/src/breadcrumbs.ts

@@ -1,7 +1,6 @@
 import type { Breadcrumb, BreadcrumbHint } from '@sentry/types';
 import { consoleSandbox, dateTimestampInSeconds } from '@sentry/utils';
 import { getClient, getIsolationScope } from './currentScopes';
-import { assignBreadcrumbLogLevel } from './utils/breadcrumbsUtils';
 
 /**
  * Default maximum number of breadcrumbs added to an event. Can be overwritten
@@ -26,7 +25,7 @@ export function addBreadcrumb(breadcrumb: Breadcrumb, hint?: BreadcrumbHint): vo
   if (maxBreadcrumbs <= 0) return;
 
   const timestamp = dateTimestampInSeconds();
-  const mergedBreadcrumb = { timestamp, ...assignBreadcrumbLogLevel(breadcrumb) };
+  const mergedBreadcrumb = { timestamp, breadcrumb };
   const finalBreadcrumb = beforeBreadcrumb
     ? (consoleSandbox(() => beforeBreadcrumb(mergedBreadcrumb, hint)) as Breadcrumb | null)
     : mergedBreadcrumb;

packages/core/src/scope.ts

@@ -24,7 +24,6 @@ import type {
 import { dateTimestampInSeconds, generatePropagationContext, isPlainObject, logger, uuid4 } from '@sentry/utils';
 
 import { updateSession } from './session';
-import { assignBreadcrumbLogLevel } from './utils/breadcrumbsUtils';
 import { _getSpanForScope, _setSpanForScope } from './utils/spanOnScope';
 
 /**
@@ -413,7 +412,7 @@ class ScopeClass implements ScopeInterface {
 
     const mergedBreadcrumb = {
       timestamp: dateTimestampInSeconds(),
-      ...assignBreadcrumbLogLevel(breadcrumb),
+      breadcrumb,
     };
 
     const breadcrumbs = this._breadcrumbs;

packages/core/src/utils/breadcrumbsUtils.ts

@@ -1,20 +1,17 @@
-import type { Breadcrumb } from '@sentry/types';
+import type { SeverityLevel } from '@sentry/types';
 
 /**
- * Set a Fetch/XHR breadcrumb's log level based on the returned status code
- * @param breadcrumb
+ * Determine a breadcrumb's log level based on the response status code
+ * @param statusCode
  */
-export function assignBreadcrumbLogLevel(breadcrumb: Breadcrumb): Breadcrumb {
-  const statusCode = breadcrumb.data?.status_code;
-  if (typeof statusCode !== 'number') {
-    return breadcrumb;
-  }
-
-  if (statusCode >= 400 && statusCode < 500) {
-    breadcrumb.level = 'warning';
+export function getBreadcrumbLogLevel(statusCode: number | undefined): SeverityLevel {
+  if (statusCode === undefined) {
+    return 'info';
+  } else if (statusCode >= 400 && statusCode < 500) {
+    return 'warning';
   } else if (statusCode >= 500) {
-    breadcrumb.level = 'error';
+    return 'error';
+  } else {
+    return 'info';
   }
-
-  return breadcrumb;
 }

packages/core/test/lib/utils/breadcrumbsUtils.test.ts

@@ -0,0 +1,15 @@
+import type { SeverityLevel } from '@sentry/types';
+import { getBreadcrumbLogLevel } from '../../../src/utils/breadcrumbsUtils';
+
+describe('getBreadcrumbLogLevel()', () => {
+  it.each([
+    ['warning', '4xx', 403],
+    ['error', '5xx', 500],
+    ['info', '3xx', 307],
+    ['info', '2xx', 200],
+    ['info', '1xx', 103],
+    ['info', 'undefined', undefined],
+  ] as [SeverityLevel, string, number | undefined][])('should return `%s` for %s', (output, _codeRange, input) => {
+    expect(getBreadcrumbLogLevel(input)).toBe(output);
+  });
+});