Skip to content

Commit 8256be8

Browse files
committed
ref isDevMode
1 parent 8abbfa5 commit 8256be8

File tree

6 files changed

+7
-5
lines changed

6 files changed

+7
-5
lines changed

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/client-errors.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
3+
import { isDevMode } from './isDevMode';
34

45
const packageJson = require('../package.json');
56

67
test('Sends a client-side exception to Sentry', async ({ page }) => {
78
const nextjsVersion = packageJson.dependencies.next;
89
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
9-
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');
1010

1111
await page.goto('/');
1212

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/devErrorSymbolification.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForError } from '@sentry-internal/test-utils';
3+
import { isDevMode } from './isDevMode';
34

45
test('should have symbolicated dev errors', async ({ page }) => {
5-
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');
66
test.skip(!isDevMode, 'should be skipped for non-dev mode');
77

88
await page.goto('/');
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/transactions.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
3+
import { isDevMode } from './isDevMode';
34

45
const packageJson = require('../package.json');
56

67
test('Sends a pageload transaction', async ({ page }) => {
78
const nextjsVersion = packageJson.dependencies.next;
89
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
9-
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');
1010

1111
const pageloadTransactionEventPromise = waitForTransaction('nextjs-app-dir', transactionEvent => {
1212
return transactionEvent?.contexts?.trace?.op === 'pageload' && transactionEvent?.transaction === '/';
@@ -78,7 +78,7 @@ test('Should send a transaction for instrumented server actions', async ({ page
7878
test('Should send a wrapped server action as a child of a nextjs transaction', async ({ page }) => {
7979
const nextjsVersion = packageJson.dependencies.next;
8080
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
81-
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');
81+
8282
test.skip(!isNaN(nextjsMajor) && nextjsMajor < 14, 'only applies to nextjs apps >= version 14');
8383
test.skip(isDevMode, 'this magically only works in production');
8484

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');

dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/transactions.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
3+
import { isDevMode } from './isDevMode';
34

45
const packageJson = require('../package.json');
56

67
test('Sends a pageload transaction', async ({ page }) => {
78
const nextjsVersion = packageJson.dependencies.next;
89
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
9-
const isDevMode = process.env.TEST_ENV?.includes('development');
1010

1111
const pageloadTransactionEventPromise = waitForTransaction('nextjs-pages-dir', transactionEvent => {
1212
return transactionEvent?.contexts?.trace?.op === 'pageload' && transactionEvent?.transaction === '/';

0 commit comments

Comments
 (0)