Skip to content

Commit 851129a

Browse files
authored
feat: core/browser additions (#1175)
* fix: Disable @sentry/browser tests because of flaky travis * feat: Add setRelease, Make everything a promise Up test coverage * fix: tests for fetch api * ci: Reenable travis tests * ci: Fix core dep * test(core): Remove unnecessary asserts * meta: Bump core/browser
1 parent 7d7eee2 commit 851129a

File tree

12 files changed

+439
-199
lines changed

12 files changed

+439
-199
lines changed

.travis.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,16 @@ matrix:
2323
sauce_connect: true
2424
script:
2525
- npm run test && if [ "$TRAVIS_SECURE_ENV_VARS" == "true" ]; then npm run test:ci; else exit 0; fi
26+
- env: NAME="@sentry/core"
27+
install: true
28+
script:
29+
- cd packages/core && yarn install && yarn test
2630
- env: NAME="@sentry/browser"
2731
install: true
2832
script:
2933
- yarn link
3034
- cd packages/core && yarn link && yarn install && yarn dist
3135
- cd ../browser
32-
- yarn remove @sentry/core # this has to be removed once we released the package
3336
- yarn link "@sentry/core"
3437
- yarn link "raven-js"
3538
- yarn install && yarn test
36-
- env: NAME="@sentry/core"
37-
install: true
38-
script:
39-
- cd packages/core && yarn install && yarn test

packages/browser/__tests__/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ describe('Browser Interface', () => {
3434

3535
page.on('request', async request => {
3636
// @ts-ignore
37-
if (request.resourceType === 'xhr') {
37+
if (request.resourceType === 'other' || request.resourceType === 'xhr') {
3838
const data = JSON.parse(request.postData as any);
3939
if (data.exception) {
4040
expect(data.exception).not.toBeUndefined();

packages/browser/lib/SentryBrowser.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class SentryBrowser implements IAdapter {
2323
return Raven;
2424
}
2525

26-
public setOptions(options: ISentryBrowserOptions) {
26+
public async setOptions(options: ISentryBrowserOptions) {
2727
Object.assign(this.options, options);
2828
Object.assign(Raven._globalOptions, this.options);
2929
return this;
@@ -74,23 +74,28 @@ export class SentryBrowser implements IAdapter {
7474
});
7575
}
7676

77-
public setUserContext(user?: IUser) {
77+
public async setUserContext(user?: IUser) {
7878
Raven.setUserContext(user);
7979
return this;
8080
}
8181

82-
public setTagsContext(tags?: { [key: string]: any }) {
82+
public async setTagsContext(tags?: { [key: string]: any }) {
8383
Raven.setTagsContext(tags);
8484
return this;
8585
}
8686

87-
public setExtraContext(extra?: { [key: string]: any }) {
87+
public async setExtraContext(extra?: { [key: string]: any }) {
8888
Raven.setExtraContext(extra);
8989
return this;
9090
}
9191

92-
public clearContext() {
92+
public async clearContext() {
9393
Raven.clearContext();
9494
return this;
9595
}
96+
97+
public async setRelease(release: string) {
98+
Raven.setRelease(release);
99+
return this;
100+
}
96101
}

packages/browser/package.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
11
{
22
"name": "@sentry/browser",
3-
"version": "0.0.1",
3+
"version": "0.2.1",
44
"description": "Offical Sentry SDK for browsers",
55
"main": "dist/index.js",
66
"typings": "dist/index.d.ts",
77
"typescript": {
88
"definition": "dist/index.d.ts"
99
},
1010
"dependencies": {
11-
"@sentry/core": "^0.1.0",
12-
"raven-js": "^3.18.1"
11+
"@sentry/core": "^0.2.1",
12+
"raven-js": "^3.21.0"
1313
},
1414
"devDependencies": {
15-
"@types/jest": "^21.1.6",
16-
"@types/node": "^8.0.51",
17-
"@types/puppeteer": "^0.12.4",
15+
"@types/jest": "^21.1.8",
16+
"@types/node": "^8.5.1",
17+
"@types/puppeteer": "^0.13.8",
1818
"jest": "^21.2.1",
1919
"npm-run-all": "^4.1.2",
20-
"prettier": "^1.8.2",
20+
"prettier": "^1.9.2",
2121
"puppeteer": "^0.13.0",
2222
"rollup": "^0.52.1",
2323
"rollup-plugin-commonjs": "^8.2.6",
2424
"rollup-plugin-node-resolve": "^3.0.0",
2525
"rollup-plugin-uglify": "^2.0.1",
26-
"ts-jest": "^21.2.2",
27-
"ts-loader": "^3.1.1",
28-
"ts-node": "^3.3.0",
26+
"ts-jest": "^21.2.4",
27+
"ts-loader": "^3.2.0",
28+
"ts-node": "^4.0.2",
2929
"tslint": "^5.8.0",
3030
"tslint-config-prettier": "^1.6.0",
3131
"tslint-eslint-rules": "^4.1.1",
32-
"typescript": "^2.6.1",
32+
"typescript": "^2.6.2",
3333
"vrsource-tslint-rules": "^5.8.0"
3434
},
3535
"engines": {

0 commit comments

Comments
 (0)