remove flakey browser test and move test to integration test

Author: billyvg

dev-packages/browser-integration-tests/suites/replay/bufferStalledRequests/test.ts

@@ -269,75 +269,3 @@ sentryTest(
     expect(secondSession.session?.segmentId).toBe(0);
   },
 );
-
-sentryTest(
-  'marks session as dirty immediately when error is sampled in buffer mode',
-  async ({ getLocalTestUrl, page, browserName }) => {
-    if (shouldSkipReplayTest() || browserName === 'webkit') {
-      sentryTest.skip();
-    }
-
-    await page.route('https://dsn.ingest.sentry.io/**/*', route => {
-      return route.fulfill({
-        status: 200,
-        contentType: 'application/json',
-        body: JSON.stringify({ id: 'test-id' }),
-      });
-    });
-
-    const replayRequestPromise = waitForReplayRequest(page, 0);
-
-    const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
-    await page.goto(url);
-
-    // Wait for replay to initialize
-    await new Promise(resolve => setTimeout(resolve, 100));
-
-    // Verify initial state - buffer mode, not sampled
-    const initialSession = await getReplaySnapshot(page);
-    expect(initialSession.recordingMode).toBe('buffer');
-    expect(initialSession.session?.sampled).toBe('buffer');
-    expect(initialSession.session?.segmentId).toBe(0);
-
-    // Trigger error which should immediately mark session as sampled
-    const reqErrorPromise = waitForErrorRequest(page);
-    await page.locator('#error1').click();
-
-    // await this later otherwise we have a timing issue w/ this and `getReplaySnapshot`
-    const sessionDataOnErrorPromise = page.evaluate(() => {
-      const sessionKey = 'sentryReplaySession';
-      const data = sessionStorage.getItem(sessionKey);
-      return data ? JSON.parse(data) : null;
-    });
-
-    const duringErrorProcessing = await getReplaySnapshot(page);
-    expect(duringErrorProcessing.session?.sampled).toBe('buffer');
-    expect(duringErrorProcessing.session?.dirty).toBe(true);
-    expect(duringErrorProcessing.recordingMode).toBe('buffer'); // Still in buffer recording mode
-
-    const sessionDataOnError = await sessionDataOnErrorPromise;
-    expect(sessionDataOnError).toBeDefined();
-    expect(sessionDataOnError.sampled).toBe('buffer');
-    expect(sessionDataOnError.dirty).toBe(true);
-
-    await reqErrorPromise;
-
-    // Verify the session was persisted to sessionStorage (if sticky sessions enabled)
-    const sessionData = await page.evaluate(() => {
-      const sessionKey = 'sentryReplaySession';
-      const data = sessionStorage.getItem(sessionKey);
-      return data ? JSON.parse(data) : null;
-    });
-
-    expect(sessionData).toBeDefined();
-    expect(sessionData.sampled).toBe('buffer');
-    expect(sessionData.dirty).toBe(false);
-
-    // Need to wait for replay request before checking `recordingMode` and `dirty`,
-    // since they update after replay gets flushed
-    await replayRequestPromise;
-    const afterReplay = await getReplaySnapshot(page);
-    expect(afterReplay.recordingMode).toBe('session');
-    expect(afterReplay.session?.dirty).toBe(false);
-  },
-);

packages/replay-internal/test/integration/errorSampleRate.test.ts

@@ -80,10 +80,21 @@ describe('Integration | errorSampleRate', () => {
 
       captureException(new Error('testing'));
 
+      // session gets immediately marked as dirty since error will
+      // be linked to current session (replay) id. there's a possibility
+      // that replay never gets flushed so we must mark as dirty so we
+      // know to refresh session in the future.
+      expect(replay.recordingMode).toBe('buffer');
+      expect(replay.session?.dirty).toBe(true);
+
       await vi.advanceTimersToNextTimerAsync();
       // need 2nd tick to wait for `saveSession` to complete in `handleGlobalEvents
       await vi.advanceTimersToNextTimerAsync();
 
+      // dirty gets reset after replay is flushed
+      expect(replay.recordingMode).toBe('session');
+      expect(replay.session?.dirty).toBe(false);
+
       expect(replay).toHaveLastSentReplay({
         recordingPayloadHeader: { segment_id: 0 },
         replayEventPayload: expect.objectContaining({