Skip to content

Commit 8e9ab5e

Browse files
author
Luca Forstner
committed
.
1 parent e996bc8 commit 8e9ab5e

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

packages/e2e-tests/test-applications/nextjs-app-dir/test-recipe.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
"dependencyOverrides": {
1818
"next": "latest"
1919
}
20+
},
21+
{
22+
"dependencyOverrides": {
23+
"next": "canary"
24+
}
2025
}
2126
]
2227
}

packages/e2e-tests/test-applications/nextjs-app-dir/tests/devErrorSymbolification.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ test.describe('dev mode error symbolification', () => {
88
}
99

1010
test('should have symbolicated dev errors', async ({ page }) => {
11-
await page.goto('/client-component/parameter/42');
11+
await page.goto('/');
1212

1313
const errorEventPromise = waitForError('nextjs-13-app-dir', errorEvent => {
1414
return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
@@ -21,15 +21,15 @@ test.describe('dev mode error symbolification', () => {
2121

2222
expect(errorEventFrames?.[errorEventFrames?.length - 1]).toEqual(
2323
expect.objectContaining({
24-
filename: 'app/client-component/page.tsx',
25-
abs_path: 'webpack-internal:///(app-client)/./app/client-component/page.tsx',
24+
filename: 'components/client-error-debug-tools.tsx',
25+
abs_path: 'webpack-internal:///(app-client)/./components/client-error-debug-tools.tsx',
2626
function: 'onClick',
2727
in_app: true,
28-
lineno: 10,
28+
lineno: 32,
2929
colno: 16,
30-
pre_context: [' id="exception-button"', ' onClick={() => {'],
31-
context_line: " throw new Error('client-component-button-click-error');",
32-
post_context: [' }}', ' >', ' throw'],
30+
post_context: [' }}', ' >', ' Throw error'],
31+
context_line: " throw new Error('Click Error');",
32+
pre_context: [' <button', ' onClick={() => {'],
3333
}),
3434
);
3535
});

packages/e2e-tests/test-applications/nextjs-app-dir/tests/exceptions.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@ test('Sends a client-side exception to Sentry', async ({ page }) => {
1111
await page.goto('/');
1212

1313
const errorEventPromise = waitForError('nextjs-13-app-dir', errorEvent => {
14-
return errorEvent?.exception?.values?.[0]?.value === 'I am a click error!';
14+
return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
1515
});
1616

17-
const exceptionButton = page.locator('id=exception-button');
18-
await exceptionButton.click();
17+
await page.getByText('Throw error').click();
1918

2019
const errorEvent = await errorEventPromise;
2120
const exceptionEventId = errorEvent.event_id;

packages/e2e-tests/test-applications/nextjs-app-dir/tests/transactions.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ if (process.env.TEST_ENV === 'production') {
5252
const serverComponentTransactionPromise = waitForTransaction('nextjs-13-app-dir', transactionEvent => {
5353
return (
5454
transactionEvent?.contexts?.trace?.op === 'function.nextjs' &&
55-
transactionEvent?.transaction === 'Page Server Component (/user/[id])'
55+
transactionEvent?.transaction === 'Page Server Component (/server-component/parameter/[...parameters])'
5656
);
5757
});
5858

59-
await page.goto('/user/4');
59+
await page.goto('/server-component/parameter/1337/42');
6060

6161
const transactionEvent = await serverComponentTransactionPromise;
6262
const transactionEventId = transactionEvent.event_id;

0 commit comments

Comments
 (0)