Review comments, fix buffer size import, clean up todos

Author: aliu39

dev-packages/browser-integration-tests/package.json

@@ -55,8 +55,7 @@
     "@types/glob": "8.0.0",
     "@types/node": "^14.18.0",
     "@types/pako": "^2.0.0",
-    "glob": "8.0.3",
-    "launchdarkly-js-client-sdk": "^3.5.0"
+    "glob": "8.0.3"
   },
   "volta": {
     "extends": "../../package.json"

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/init.js

@@ -1,32 +1,33 @@
 import * as Sentry from '@sentry/browser';
 import { launchDarklyIntegration, buildLaunchDarklyFlagUsedHandler } from '@sentry/browser';
 
-
 window.Sentry = Sentry;
-window.LDIntegration = launchDarklyIntegration();
+window.sentryLDIntegration = launchDarklyIntegration();
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
   sampleRate: 1.0,
-  integrations: [window.LDIntegration],
+  integrations: [window.sentryLDIntegration],
 });
 
+// Manually mocking this because LD only has mock test utils for the React SDK.
+// Also, no SDK has mock utils for FlagUsedHandler's.
 const MockLaunchDarkly = {
   initialize(_clientId, context, options) {
     const flagUsedHandler = (options && options.inspectors) ? options.inspectors[0].method : undefined;
 
     return {
       variation(key, defaultValue) {
         if (flagUsedHandler) {
-          flagUsedHandler(key, { value: defaultValue }, context); // TODO:this is async atm
+          flagUsedHandler(key, { value: defaultValue }, context);
         }
         return defaultValue;
       },
     };
   },
 };
 
-window.InitializeLD = () => {
+window.initializeLD = () => {
   return MockLaunchDarkly.initialize(
     'example-client-id',
     { kind: 'user', key: 'example-context-key' },

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/test.ts

@@ -3,8 +3,7 @@ import { expect } from '@playwright/test';
 import { sentryTest } from '../../../../utils/fixtures';
 
 import { envelopeRequestParser, waitForErrorRequest } from '../../../../utils/helpers';
-// import { FLAG_BUFFER_SIZE } from '@sentry/browser'; // TODO: not picking up export atm
-const FLAG_BUFFER_SIZE = 100;
+import { FLAG_BUFFER_SIZE } from '@sentry/browser';
 
 sentryTest('e2e test', async ({ getLocalTestPath, page }) => {
   await page.route('https://dsn.ingest.sentry.io/**/*', route => {
@@ -18,22 +17,22 @@ sentryTest('e2e test', async ({ getLocalTestPath, page }) => {
   const url = await getLocalTestPath({ testDir: __dirname, skipDsnRouteHandler: true });
   await page.goto(url);
 
-  await page.waitForFunction(() => {
-    const ldClient = (window as any).InitializeLD();
-    for (let i = 1; i <= FLAG_BUFFER_SIZE; i++) { // TODO: import constant for buffer size
+  await page.waitForFunction((bufferSize) => {
+    const ldClient = (window as any).initializeLD();
+    for (let i = 1; i <= bufferSize; i++) {
       ldClient.variation(`feat${i}`, false);
     }
-    ldClient.variation(`feat${FLAG_BUFFER_SIZE+1}`, true); // eviction
+    ldClient.variation(`feat${bufferSize + 1}`, true); // eviction
     ldClient.variation('feat3', true);   // update
     return true;
-  });
+  }, FLAG_BUFFER_SIZE);
 
   const reqPromise = waitForErrorRequest(page);
   await page.locator('#error').click();
   const req = await reqPromise;
   const event = envelopeRequestParser(req);
 
-  const expectedFlags = [{ flag: 'feat2', result: false }];
+  const expectedFlags = [{ flag: 'feat2', result: false }]
   for (let i = 4; i <= FLAG_BUFFER_SIZE; i++) {
     expectedFlags.push({ flag: `feat${i}`, result: false });
   }