feat: Try size-limit gh action (#2750)

HazAT · web-flow · commit 913b0ca3ce93 · 2020-07-17T15:34:59.000+02:00
* feat: Try size-limit gh action

* ref: Fix version

* feat: Lock typescript version

* feat: Pin typescript and lint version

* ci: Try skip scripts

* ref: Add size check for tracing and react
diff --git a/.github/workflows/size-limit.yml b/.github/workflows/size-limit.yml
@@ -0,0 +1,16 @@
+name: 'Bundle Size'
+on:
+  pull_request:
+    branches:
+      - master
+jobs:
+  job_1:
+    name: Size Check
+    runs-on: ubuntu-latest
+    env:
+      CI_JOB_NUMBER: 1
+    steps:
+      - uses: actions/checkout@v2
+      - uses: andresz1/size-limit-action@v1.4.0
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.size-limit.js b/.size-limit.js
@@ -0,0 +1,26 @@
+module.exports = [
+  {
+    name: '@sentry/browser - CDN Bundle (gzipped)',
+    path: 'packages/browser/build/bundle.min.js',
+    gzip: true,
+    limit: '18 KB',
+  },
+  {
+    name: '@sentry/browser - Webpack',
+    path: 'packages/browser/esm/index.js',
+    import: '{ init }',
+    limit: '18 KB',
+  },
+  {
+    name: '@sentry/react - Webpack',
+    path: 'packages/react/esm/index.js',
+    import: '{ init }',
+    limit: '19 KB',
+  },
+  {
+    name: '@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)',
+    path: 'packages/tracing/build/bundle.tracing.min.js',
+    gzip: true,
+    limit: '23 KB',
+  },
+];
diff --git a/.travis.yml b/.travis.yml
@@ -7,7 +7,7 @@ branches:
     - /^release\/.+$/
     - /^major\/.+$/
 
-install: yarn --ignore-engines
+install: yarn --ignore-engines --ignore-scripts
 os: linux
 
 language: node_js
diff --git a/package.json b/package.json
@@ -15,7 +15,7 @@
     "postpublish": "make publish-docs"
   },
   "volta": {
-    "node": "10.15.3",
+    "node": "10.18.1",
     "yarn": "1.13.0"
   },
   "workspaces": [
@@ -35,6 +35,7 @@
   ],
   "devDependencies": {
     "@google-cloud/storage": "^2.5.0",
+    "@size-limit/preset-big-lib": "^4.5.5",
     "@strictsoftware/typedoc-plugin-monorepo": "^0.2.1",
     "@types/chai": "^4.1.3",
     "@types/jest": "^24.0.11",
@@ -56,10 +57,11 @@
     "replace-in-file": "^4.0.0",
     "rimraf": "^2.6.3",
     "sinon": "^7.3.2",
+    "size-limit": "^4.5.5",
     "ts-jest": "^24.0.2",
-    "tslint": "^5.16.0",
+    "tslint": "5.16.0",
     "typedoc": "^0.14.2",
-    "typescript": "^3.4.5",
+    "typescript": "3.4.5",
     "typescript-tslint-plugin": "^0.3.1"
   },
   "resolutions": {
diff --git a/packages/apm/package.json b/packages/apm/package.json
@@ -36,8 +36,8 @@
     "rollup-plugin-node-resolve": "^4.2.3",
     "rollup-plugin-terser": "^4.0.4",
     "rollup-plugin-typescript2": "^0.21.0",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm build:bundle",
diff --git a/packages/apm/src/integrations/tracing.ts b/packages/apm/src/integrations/tracing.ts
@@ -350,9 +350,7 @@ export class Tracing implements Integration {
       if (Tracing._heartbeatCounter >= 3) {
         if (Tracing._activeTransaction) {
           Tracing._log(
-            `[Tracing] Transaction: ${
-              SpanStatus.Cancelled
-            } -> Heartbeat safeguard kicked in since content hasn't changed for 3 beats`,
+            `[Tracing] Transaction: ${SpanStatus.Cancelled} -> Heartbeat safeguard kicked in since content hasn't changed for 3 beats`,
           );
           Tracing._activeTransaction.setStatus(SpanStatus.DeadlineExceeded);
           Tracing._activeTransaction.setTag('heartbeat', 'failed');
diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -49,8 +49,8 @@
     "rollup-plugin-terser": "^4.0.4",
     "rollup-plugin-typescript2": "^0.21.0",
     "sinon": "^7.3.2",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5",
+    "tslint": "5.16.0",
+    "typescript": "3.4.5",
     "webpack": "^4.30.0"
   },
   "scripts": {
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -28,8 +28,8 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/core/test/lib/base.test.ts b/packages/core/test/lib/base.test.ts
@@ -804,9 +804,15 @@ describe('BaseClient', () => {
       const client = new TestClient({ dsn: PUBLIC_DSN });
 
       return Promise.all([
-        client.flush(1).then(() => expect(true).toEqual(true)),
-        client.flush(1).then(() => expect(true).toEqual(true)),
-        client.flush(1).then(() => expect(true).toEqual(true)),
+        client.flush(1).then(() => {
+          expect(true).toEqual(true);
+        }),
+        client.flush(1).then(() => {
+          expect(true).toEqual(true);
+        }),
+        client.flush(1).then(() => {
+          expect(true).toEqual(true);
+        }),
       ]);
     });
   });
diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json
@@ -38,8 +38,8 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
-    "typescript": "^3.5.1"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/hub/package.json b/packages/hub/package.json
@@ -26,8 +26,8 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/hub/src/scope.ts b/packages/hub/src/scope.ts
@@ -268,7 +268,7 @@ export class Scope implements ScopeInterface {
     }
 
     if (typeof captureContext === 'function') {
-      const updatedScope = (captureContext as (<T>(scope: T) => T))(this);
+      const updatedScope = (captureContext as <T>(scope: T) => T)(this);
       return updatedScope instanceof Scope ? updatedScope : this;
     }
 
diff --git a/packages/integrations/package.json b/packages/integrations/package.json
@@ -32,8 +32,8 @@
     "rollup-plugin-node-resolve": "^4.2.3",
     "rollup-plugin-terser": "^4.0.4",
     "rollup-plugin-typescript2": "^0.21.0",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm build:bundle",
diff --git a/packages/integrations/src/ember.ts b/packages/integrations/src/ember.ts
@@ -50,21 +50,18 @@ export class Ember implements Integration {
       }
     };
 
-    this._Ember.RSVP.on(
-      'error',
-      (reason: any): void => {
-        if (getCurrentHub().getIntegration(Ember)) {
-          getCurrentHub().withScope(scope => {
-            if (isInstanceOf(reason, Error)) {
-              scope.setExtra('context', 'Unhandled Promise error detected');
-              getCurrentHub().captureException(reason, { originalException: reason });
-            } else {
-              scope.setExtra('reason', reason);
-              getCurrentHub().captureMessage('Unhandled Promise error detected');
-            }
-          });
-        }
-      },
-    );
+    this._Ember.RSVP.on('error', (reason: any): void => {
+      if (getCurrentHub().getIntegration(Ember)) {
+        getCurrentHub().withScope(scope => {
+          if (isInstanceOf(reason, Error)) {
+            scope.setExtra('context', 'Unhandled Promise error detected');
+            getCurrentHub().captureException(reason, { originalException: reason });
+          } else {
+            scope.setExtra('reason', reason);
+            getCurrentHub().captureMessage('Unhandled Promise error detected');
+          }
+        });
+      }
+    });
   }
 }
diff --git a/packages/integrations/src/reportingobserver.ts b/packages/integrations/src/reportingobserver.ts
@@ -89,7 +89,7 @@ export class ReportingObserver implements Integration {
 
     this._getCurrentHub = getCurrentHub;
 
-    const observer = new (getGlobalObject<any>()).ReportingObserver(this.handler.bind(this), {
+    const observer = new (getGlobalObject<any>().ReportingObserver)(this.handler.bind(this), {
       buffered: true,
       types: this._options.types,
     });
diff --git a/packages/minimal/package.json b/packages/minimal/package.json
@@ -26,8 +26,8 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/node/package.json b/packages/node/package.json
@@ -37,8 +37,8 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts
@@ -88,7 +88,7 @@ function extractTransaction(req: { [key: string]: any }, type: boolean | Transac
         stack: [
           {
             name: string;
-          }
+          },
         ];
       };
     };
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -42,10 +42,10 @@
     "react-test-renderer": "^16.13.1",
     "redux": "^4.0.5",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
+    "tslint": "5.16.0",
     "tslint-react": "^5.0.0",
     "tslint-react-hooks": "^2.2.2",
-    "typescript": "^3.5.1"
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/tracing/package.json b/packages/tracing/package.json
@@ -38,8 +38,8 @@
     "rollup-plugin-node-resolve": "^4.2.3",
     "rollup-plugin-terser": "^4.0.4",
     "rollup-plugin-typescript2": "^0.21.0",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm build:bundle",
diff --git a/packages/tracing/src/browser/backgroundtab.ts b/packages/tracing/src/browser/backgroundtab.ts
@@ -17,9 +17,7 @@ export function registerBackgroundTabDetection(): void {
       const activeTransaction = getActiveTransaction() as IdleTransaction;
       if (global.document.hidden && activeTransaction) {
         logger.log(
-          `[Tracing] Transaction: ${SpanStatus.Cancelled} -> since tab moved to the background, op: ${
-            activeTransaction.op
-          }`,
+          `[Tracing] Transaction: ${SpanStatus.Cancelled} -> since tab moved to the background, op: ${activeTransaction.op}`,
         );
         activeTransaction.setStatus(SpanStatus.Cancelled);
         activeTransaction.setTag('visibilitychange', 'document.hidden');
diff --git a/packages/tracing/src/idletransaction.ts b/packages/tracing/src/idletransaction.ts
@@ -115,9 +115,7 @@ export class IdleTransaction extends Transaction {
 
     if (this._heartbeatCounter >= 3) {
       logger.log(
-        `[Tracing] Transaction: ${
-          SpanStatus.Cancelled
-        } -> Heartbeat safeguard kicked in since content hasn't changed for 3 beats`,
+        `[Tracing] Transaction: ${SpanStatus.Cancelled} -> Heartbeat safeguard kicked in since content hasn't changed for 3 beats`,
       );
       this.setStatus(SpanStatus.DeadlineExceeded);
       this.setTag('heartbeat', 'failed');
diff --git a/packages/tracing/test/tslint.json b/packages/tracing/test/tslint.json
@@ -1,6 +1,7 @@
 {
   "extends": ["../tslint.json"],
   "rules": {
-    "no-unsafe-any": false
+    "no-unsafe-any": false,
+    "no-implicit-dependencies": false
   }
 }
diff --git a/packages/types/package.json b/packages/types/package.json
@@ -19,8 +19,8 @@
     "npm-run-all": "^4.1.2",
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/typescript/package.json b/packages/typescript/package.json
@@ -15,7 +15,7 @@
     "tslint-consistent-codestyle": "^1.15.1"
   },
   "peerDependencies": {
-    "tslint": "^5.11.0",
+    "tslint": "5.16.0",
     "typescript": "^3.2.0"
   },
   "scripts": {
diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -26,8 +26,8 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
-    "typescript": "^3.4.5"
+    "tslint": "5.16.0",
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
diff --git a/packages/utils/src/path.ts b/packages/utils/src/path.ts
@@ -60,7 +60,10 @@ export function resolve(...args: string[]): string {
   // handle relative paths to be safe (might happen when process.cwd() fails)
 
   // Normalize the path
-  resolvedPath = normalizeArray(resolvedPath.split('/').filter(p => !!p), !resolvedAbsolute).join('/');
+  resolvedPath = normalizeArray(
+    resolvedPath.split('/').filter(p => !!p),
+    !resolvedAbsolute,
+  ).join('/');
 
   return (resolvedAbsolute ? '/' : '') + resolvedPath || '.';
 }
@@ -125,7 +128,10 @@ export function normalizePath(path: string): string {
   const trailingSlash = path.substr(-1) === '/';
 
   // Normalize the path
-  let normalizedPath = normalizeArray(path.split('/').filter(p => !!p), !isPathAbsolute).join('/');
+  let normalizedPath = normalizeArray(
+    path.split('/').filter(p => !!p),
+    !isPathAbsolute,
+  ).join('/');
 
   if (!normalizedPath && !isPathAbsolute) {
     normalizedPath = '.';
diff --git a/packages/utils/test/object.test.ts b/packages/utils/test/object.test.ts
@@ -204,7 +204,10 @@ describe('normalize()', () => {
       obj.children[1].self = obj.children[1];
       expect(normalize(obj)).toEqual({
         name: 'Alice',
-        children: [{ name: 'Bob', self: '[Circular ~]' }, { name: 'Eve', self: '[Circular ~]' }],
+        children: [
+          { name: 'Bob', self: '[Circular ~]' },
+          { name: 'Eve', self: '[Circular ~]' },
+        ],
       });
     });
 
@@ -219,7 +222,10 @@ describe('normalize()', () => {
       const obj: object[] = [];
       obj.push({ name: 'Alice', self: obj });
       obj.push({ name: 'Bob', self: obj });
-      expect(normalize(obj)).toEqual([{ name: 'Alice', self: '[Circular ~]' }, { name: 'Bob', self: '[Circular ~]' }]);
+      expect(normalize(obj)).toEqual([
+        { name: 'Alice', self: '[Circular ~]' },
+        { name: 'Bob', self: '[Circular ~]' },
+      ]);
     });
 
     test('repeated objects in objects', () => {
diff --git a/packages/utils/test/promisebuffer.test.ts b/packages/utils/test/promisebuffer.test.ts
diff --git a/scripts/test.sh b/scripts/test.sh
diff --git a/yarn.lock b/yarn.lock
